I think we lack a little backwards compatibility here and since the "wrong" link can be a little annoying when having your own CSS link styles, we should make this work as at Limesurvey 2.0.

Over to you Denis - https://github.com/LimeSurvey/LimeSurvey/commit/cd16db1dc0ae63e1d462991206b0a3afe6f89aac

No button, leave a link but fix included template.

We don't have global css actually, then can not fix for all.

Denis, I don't consider fixing the shipped templates a reasonable solution. What about all those users with custom templates? They all need to adjust their templates as well.
It would be of a far bigger help if we just stick to the original button element.

We already broke a lot of user template between 2.0 and 2.05. And here, it's only a css issue.

All citronade based template are completely broken: JS broken ...

PS: why not stick to original : because clear all is a link, it's really a link. Why don't use link if it's a link ?
PS2: in 1.90 version and older : clearall are already an a link

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13908

We can do :
$(function() {
$("a.confirm-needed").each(function(){
$(this).replaceWith($("<button id='"+$(this).attr('id')+"'class='"+$(this).attr('class')+"' title='"+$(this).attr('title')+"'>"+$(this).html()+"</button>"));
});
});

But i think it's not really needed.

Topic for tomorrow ;)

Denis, thanks for the fix but I think we should discuss this at today's DEV meeting because from my point of view there can be a far easier fix and I don't see the benefit of your solution for our users.
So please put your commit on hold until we have discussed this.

Benefits : a link is a link. Work in all browser even without javascript. More clean for screen reader (tested by a friend of mine).

I don't think that just because of "We already broke a lot of user template between 2.0 and 2.05" that justifies breaking some more stuff. I don't understand what speaks against making this a button as it was at the previous Limesurvey 2.0 version.

The current solution causes me quite some trouble using Limesurvey because I need to fix several custom templates manually and I am sure I am not the only user having that problem.

Decision based on dev meeting.

• Revert <a> tag to a <button> tag.
• Add a class to it that identifies this is a delete button.
• Add script that:
  • Uses the forms data-confirmation attribute to show a confirmation message.
  • After confirmation sends a HTTP DELETE request.
• Update the clear and exit function to only accept DELETE requests.

This will solve the OPs problem and will remove 1 incorrect usage of HTTP GET.

Why not move to $_POST and redirect ? With a confirmed=="Y" ?

For remind :

• http://www.w3.org/TR/WCAG20-TECHS/client-side-script.html
• http://www.csun.edu/~comp508/websitecheck.html
• http://webaim.org/techniques/javascript/alternatives

Think best is :

• Clicking in this button open a new form
  One with DELETE (confirm)
  And one with cancel

And after we can do it ajax : with a beatifull confirm box or with a javascript confirm() like now ...

Remind:
1.92 and 1.00 are : <input type="button" onclick="if (confirm('Êtes-vous sûr de vouloir effacer toutes vos réponses?')) {
window.open('/index.php/975921/move/clearall/lang/fr', '_self')}" class="clearall" value="Sortir et effacer vos réponses" name="clearallbtn">

A window open only too ...

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13912

Fix the button only : other must be in 2.06 or 2.1

I think that the solution with that extra dialog (separate form) is the best one, but as you said, for 2.06 or 2.1

Yes and need rewriting controllers/survey/index.php .....

2.05+ Build 140226 released