View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
08730Bug reportsSurvey takingpublic2014-02-26 13:32
ReporterTMSWhite Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary08730: Allways take default language radix separator for all survey
Description

The survey does not have an logic problems, but at run-time, it is not possible to enter commas even though the specified decimal separator is a comma. Instead, the data entry fields only allow periods as the decimal separator, and some of the generated strings (like the sum in question [K] Enter several numbers, show a period as the decimal point instead of a comma.

Steps To Reproduce

The run-time functionality works properly in 2.00+

TagsNo tags attached.
Attached Files
period-instead-of-comma.PNG (12,565 bytes)   
period-instead-of-comma.PNG (12,565 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)Release 2.05+ Build 140217
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL 5.6.14
Server OS (if known)Windows 7 64 bit
Webserver software & version (if known)XAMPP 1.8.3
PHP Version5.5.6

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2014-02-17 16:48

developer   ~28790

Can not reproduce : js caching issue ?

DenisChenu

DenisChenu

2014-02-17 16:51

developer   ~28791

Can reproduce only for 'total value'

TMSWhite

TMSWhite

2014-02-17 17:13

reporter   ~28792

Denis-
I just used a different computer, and F5, and the problem persists, so I think we can rule out JS caching. See attached screenshot.

Could it be related to the admin or default language, and whether that language expects a period or comma by default?

DenisChenu

DenisChenu

2014-02-17 17:28

developer   ~28793

I'm logged in en, maybe something other.

Can you look at source code for this part:
<script type="text/javascript">
/<![CDATA[/
LSvar={"bFixNumAuto":1,"bNumRealValue":0,"sLEMradix":","};
showpopup=1;
startPopups=[];
/]]>/
</script>

DenisChenu

DenisChenu

2014-02-17 17:29

developer   ~28794

Maybe something related with this bug : http://bugs.limesurvey.org/view.php?id=8714

Somewhere we put a fix fixed this 2 part ?

DenisChenu

DenisChenu

2014-02-20 08:33

developer   ~28829

Hi Thomas,

Can you give me this information:
Did you have:
Can you look at source code for this part:
<script type="text/javascript">
/<![CDATA[/
LSvar={"bFixNumAuto":1,"bNumRealValue":0,"sLEMradix":","};
showpopup=1;
startPopups=[];
/]]>/
</script>
in your HTML code.

And what is the browser used ?

Thanks

TMSWhite

TMSWhite

2014-02-20 14:41

reporter   ~28834

Denis-

On Chrome and IE 11, I see this in the source code before <title>:
<script type="text/javascript">
/<![CDATA[/
LSvar={"bFixNumAuto":1,"bNumRealValue":0,"sLEMradix":"."}
showpopup=1;
startPopups=[];
/]]>/
</script>

I am using the demo.limsurvey.org website, and am logging in with an admin language of English. I see the same code when logging into that site using French as the admin language (even after pressing F5 to reload the Javascript).

I test both from a Windows 7 computer, and from Chrome on my smart phone, and in all cases am seeing a sLEMradix value of "." instead of ","

DenisChenu

DenisChenu

2014-02-20 14:52

developer   ~28835

OK,

Then it's not the javascript here :
"sLEMradix":"."

The LEMradix are not good.

PHP issue, i look in demo too.

DenisChenu

DenisChenu

2014-02-20 17:55

developer   ~28841

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=13916

DenisChenu

DenisChenu

2014-02-20 17:56

developer   ~28842

Thanks, fixed now.

And it's not admin language, it's global settings language ;)

c_schmitz

c_schmitz

2014-02-26 13:32

administrator   ~28946

2.05+ Build 140226 released

Related Changesets

LimeSurvey: master e9b6e11f

2014-02-20 16:54:43

DenisChenu

Details Diff
Fixed issue 08730: Allways take default language radix separator for all s
Dev: sLEMradix is a survey settings, then put it in SurveyRuntimeHelper
Dev: Allways add 'default' settings in run, but replace it in SurveyRuntime
Affected Issues
08730
mod - application/controllers/survey/index.php Diff File
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - scripts/survey_runtime.js Diff File

Issue History

Date Modified Username Field Change
2014-02-17 06:24 TMSWhite New Issue
2014-02-17 06:24 TMSWhite File Added: ls205_comma_as_radix_separator.lss
2014-02-17 16:44 DenisChenu Assigned To => DenisChenu
2014-02-17 16:44 DenisChenu Status new => assigned
2014-02-17 16:48 DenisChenu Note Added: 28790
2014-02-17 16:48 DenisChenu File Added: Capture du 2014-02-17 16:46:14.png
2014-02-17 16:50 DenisChenu File Added: limesurvey.sondages.pro 2014-2-17 16 49 49.png
2014-02-17 16:51 DenisChenu Note Added: 28791
2014-02-17 17:13 TMSWhite Note Added: 28792
2014-02-17 17:13 TMSWhite File Added: period-instead-of-comma.PNG
2014-02-17 17:28 DenisChenu Note Added: 28793
2014-02-17 17:29 DenisChenu Note Added: 28794
2014-02-20 08:33 DenisChenu Note Added: 28829
2014-02-20 08:33 DenisChenu Status assigned => feedback
2014-02-20 14:41 TMSWhite Note Added: 28834
2014-02-20 14:41 TMSWhite Status feedback => assigned
2014-02-20 14:52 DenisChenu Note Added: 28835
2014-02-20 17:52 DenisChenu Summary /docs/demosurveys/ls205_comma_as_radix_separator.lss does not accept commas => Allways take default language radix separator for all survey
2014-02-20 17:55 DenisChenu Changeset attached => LimeSurvey master e9b6e11f
2014-02-20 17:55 DenisChenu Note Added: 28841
2014-02-20 17:55 DenisChenu Resolution open => fixed
2014-02-20 17:56 DenisChenu Note Added: 28842
2014-02-20 17:56 DenisChenu Status assigned => resolved
2014-02-20 17:56 DenisChenu Fixed in Version => 2.05+
2014-02-26 13:32 c_schmitz Note Added: 28946
2014-02-26 13:32 c_schmitz Status resolved => closed