 |
I do not see a problem - a linefeed is entered by pressing ENTER ? |
 |
Here is a screenshot of the "problem" : http://awesomescreenshot.com/0be2c6jbfe When I reset the mail template strings are picked from translation files but the line feed is missing and some html codes are put in. I can't see how it is possible to insert line feeds in the translation system at www.translate.limesurvey.com. The original English text contains some arrows to indicate a line feed but I can not see how to put them in the translated language. Copy/paste don't help. |
|
|
I can't see a problem on the screenshot. You are using HTML email which does not use linebreaks anyway. The linebreaks entered in the translation are automatically translated to (br/) tags if you switch to HTML email mode. If you switch your emails to text mode then the line breaks are properly used and shown. |
|
|
Hm, It it correct if I choose inline HTML. HTML popup shows nothing (another bug?). Plain text shows the enclosed screenshot, e.g. HTML codes in text and no line feeds. I thought it should be more or less the same wether I choose html og plain ascii text. Wrong? |
|
|
??? Your screenhot is HTML popup, the edit icon can be seen beside the edit field. If you switch the format to either HTML or plain text you have to use the 'Set default' button to pull the correctly formatted text. The translated text is ASCII but if you switch to HTML and pull the default text the line breaks are converted automatically to (br/). |
|
|
Have you tested this with e.g. Norwegian bokmål user interface? The icon to the html pop up window only shows a new window without any strings at all. See enclosed screenshot. |
|
|
The html popup window works fine if I use in in question editing, but not here... |
|
|
I can reproduce the HTML popup issue and I can see that the 'Use default' button does not work in HTML mode. I will fix the latter one. |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13882 |
|
|
Tony, can you check please why the HTML popup editor is broken in email templates? pop_nofields_view was originally intended for CKeditor using only the basic replacement fields (like in email templates) and \application\views\admin\htmleditor\pop_editor_view.php for the rest (like questions, labels, answer options, etc). Maybe we can adjust \application\views\admin\htmleditor\pop_editor_view.php so it covers both? |
|
|
Carsten, I'm confused... In 2.0, as far as I can see, pop_editor_view was used for everything including the email templates. The only difference I can see between the editors was the LS replacement fields available and this is controlled by limereplacementfields.php. Now, in 2.05, for some reason unknown to me, the pop_nofields_view is triggered for email templates. I don't see how that view could ever have worked and why it is required at all. What editor differences (aside from LS replacement fields) should there be between email templates and other uses? Having said all of that, if there are no real differences and we go with pop_editor_view.php for all uses, we will need to fix some bugs in limereplacementfields.php. Some of the $fieldtype values are different in 2.05 so the switch on $fieldtype doesn't work for 'email-inv' and 'email-rem' (and perhaps some other values). Thoughts? |
|
|
Tony, you are right. I found the issue in a completely different place and fixed it. I don't understand the $fieldtype problem you are mentioning. Can you check if this is still a issue with my fix applied? |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13918 |
|
|
No, the problem still exists, there are no replacement fields available in the email templates. See my screenshot - no_replacement_fields_for_emails.png. |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13920 |
|
|
How about this fix? |
|
|
Tony, that looks great to me, nicely done! I guess we can close this issue now. |
|
|
2.05+ Build 140226 released |
- Anonymous
