Looks like the survey column still sorts after SID.

It's actually sorting on SID and Survey combined...

I don't see anything amiss with the JavaScript. The colModel (which would be the most likely offender) appears to be correct.

Also I find that, when loaded, the table is not being sorted by SID as it should be. (although the sortname and sortorder options appear to be correct)

Could it be a problem with the JSONized grid data? (dunno if it helps but this data is also not sorted)

Maybe a bug in jqGrid? It should not matter how the grid data is sorted as the JS takes care of it?

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13790

Well, dunno whether it's really a jqGrid bug but the sort function is including the anchor tags in those cells. Therefor it's effectively sorting by a combination of survey ID and name.

I have added a custom sorting function to strip the <a> tag before sorting.

This still does not solve the non sorting by ID on page load...

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13791

It seems that the JSON data should be sorted - http://www.trirand.com/blog/?page_id=393/help/how-to-do-default-sorting-when-grid-first-time-load/

I have incorporated the fix from that post but it would be preferable to sort before delivery.

Thoughts?

It's my fault here ....

Didn't understand why there are a comment before the link ...
https://github.com/LimeSurvey/LimeSurvey/commit/f188b85d567ae2e3730c15a968d5d4598bb265ab#diff-ae6ef646cdcd6b65eca67ba2a3b15a27L626

Then removing it.

Still the main issue is getsurveyJson need to return text only and not HTML. Started a fix, but no time to accomplish.

The alternative here is to remove the link, and do it in JavaScript only.

Okay, now I get what changed to break the sorting by "Survey" :)

Should we put the comment back in or just leave it with the new sorttype function?

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13792

Denis, if we want to remove the link(s) from getSurveys_json(), we can use a custom jqGrid formatter - http://www.trirand.com/jqgridwiki/doku.php?id=wiki:custom_formatter

Something like this:
function surveyColumnFormatter (cellvalue, options, rowObject) {
return '<a href="view/surveyid/' + options.rowId + '">'+cellvalue+'</a>';
}

My concerns with that are:

1) How to pass translations in the link(s) - for title, etc
2) Where else is getSurveys_json() used?

Hi tpartner, i start to work on this, but need more than just this column here.

For this one : We just need to do a link to survey. Then i think we can "just" do a link with sid and text.

Something like that:
gridComplete: function(data){
updateCells();
},

function updateCells(){
$("#displaysurveys tbody tr").each(function(){
$(this).find("td:eq(4)").html("<a href=".calculatedSurveyLink.">".$(this).text()."</a>"); // QUickliy done, surely broken

});
}

But in this function we need:

• Update the first column (get state and replace with piture according to state)
• Update survey name column
• Update the owner column

For survey name and owner : maybe we can use something like:
$(document).on("click","#displaysurveys tbody tr ts:eq(4)",finction(){
});
Think it's better, but need too a some time to work on it.

The quicly is to add again the <!-- surveyname -->

Just remind to purify surveyname

Okay, over to you - I think you may be over-complicating it.

It's great now ?

I think of a devloppment bug (for 2.1/2.2/2.3), not a 'bug report' bug.

Sorry,

You made it now ?

It is now working as expected:

• On load, the table is sorted by ID
• Sorting by "Survey" now works correctly

Move to jqgrid/autoencode;true is not this bug ;)

Thanks Tony

LimeSurvey 2-05+ Build 140131 released

The sort of survey name is still a little odd as it differs between upper and lower case letters. Uppercae names are sorted before lowercase, making the list show like e.g. this:

My survey
a survey example

The sorting routine should be case insensitive. Make no sense elsewhere.

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13810

That seems to be a jqGrid bug - the "ignoreCase" option is set to true. However, I have put in a workaround.

Version 2.05+ Build 140204 released