View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
08536Bug reportsData Entry (non public)public2014-01-13 23:382014-01-25 17:22
Reportermfairchild365 Assigned Toc_schmitz  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary08536: single and double quotes in upload title/comment cause corrupted json in the database
Description

single and double quotes in upload title/comment cause corrupted json in the database and causes all js to fail in the survey.

I thought that I had fixed this issue with this pull request: https://github.com/LimeSurvey/LimeSurvey/pull/164

However, it is still broken. I'm not sure of a proper fix.

Steps To Reproduce
  1. Create a quiz with an upload question
  2. Make sure that you can resume the survey.
  3. Upload a file and enter a single quote or/and double quote anywhere in the 'title' or 'comment' fields for the upload.
  4. Click 'resume later'
  5. Reload the survey.

Note: you may need to click 'resume later' twice.

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)ab1136dec2d0c366a866ecb43263
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql
Server OS (if known)linux
Webserver software & version (if known)apache 2.2
PHP Version5.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2014-01-17 16:49

administrator   ~27966

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13709
c_schmitz

c_schmitz

2014-01-17 16:51

administrator   ~27967

The problem was the embedding of the already captured data in the page on re-display. I reverted your patch and applied the correct fix. Feel free to re-open if you still have problems.
Data captured already using your patch might still make problems, so please test on new records only ;).
c_schmitz

c_schmitz

2014-01-25 17:22

administrator   ~28164

2.05+ Build 140125 released

Related Changesets

LimeSurvey: master 528a218d

2014-01-17 15:50:04

c_schmitz

Details Diff 		Fixed issue 08536: Double quotes in upload title/comment caused survey page not to re-display correctly
Dev Also reverts commit e0a15889b702942673e6642d9f28dc00b7fcf16e)		 Affected Issues
08536
mod - application/helpers/qanda_helper.php Diff File
mod - scripts/uploader.js Diff File

Issue History

Date Modified Username Field Change
2014-01-13 23:38 mfairchild365 New Issue
2014-01-17 15:48 c_schmitz Assigned To => c_schmitz
2014-01-17 15:48 c_schmitz Status new => assigned
2014-01-17 16:49 c_schmitz Changeset attached => LimeSurvey master 528a218d
2014-01-17 16:49 c_schmitz Note Added: 27966
2014-01-17 16:49 c_schmitz Resolution open => fixed
2014-01-17 16:51 c_schmitz Note Added: 27967
2014-01-17 16:51 c_schmitz Status assigned => resolved
2014-01-17 16:51 c_schmitz Fixed in Version => 2.05+
2014-01-25 17:22 c_schmitz Note Added: 28164
2014-01-25 17:22 c_schmitz Status resolved => closed