View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
08517 | Bug reports | Other | public | 2014-01-08 09:56 | 2014-01-16 16:45 |
Reporter | mmirasol | Assigned To | DenisChenu | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Fixed in Version | 2.05+ | ||||
Summary | 08517: Quota Answers not in Base Language | ||||
Description | The answers on the quota screen are displayed based on the first additional language and not the base language. | ||||
Steps To Reproduce |
Here you'll see that the language shown for the answer is the first additional language. | ||||
Tags | No tags attached. | ||||
Attached Files | CException.html (22,614 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>CException</title> <style type="text/css"> /*<![CDATA[*/ html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;} body{line-height:1;} ol,ul{list-style:none;} blockquote,q{quotes:none;} blockquote:before,blockquote:after,q:before,q:after{content:none;} :focus{outline:0;} ins{text-decoration:none;} del{text-decoration:line-through;} table{border-collapse:collapse;border-spacing:0;} body { font: normal 9pt "Verdana"; color: #000; background: #fff; } h1 { font: normal 18pt "Verdana"; color: #f00; margin-bottom: .5em; } h2 { font: normal 14pt "Verdana"; color: #800000; margin-bottom: .5em; } h3 { font: bold 11pt "Verdana"; } pre { font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace; } pre span.error { display: block; background: #fce3e3; } pre span.ln { color: #999; padding-right: 0.5em; border-right: 1px solid #ccc; } pre span.error-ln { font-weight: bold; } .container { margin: 1em 4em; } .version { color: gray; font-size: 8pt; border-top: 1px solid #aaa; padding-top: 1em; margin-bottom: 1em; } .message { color: #000; padding: 1em; font-size: 11pt; background: #f3f3f3; -webkit-border-radius: 10px; -moz-border-radius: 10px; border-radius: 10px; margin-bottom: 1em; line-height: 160%; } .source { margin-bottom: 1em; } .code pre { background-color: #ffe; margin: 0.5em 0; padding: 0.5em; line-height: 125%; border: 1px solid #eee; } .source .file { margin-bottom: 1em; font-weight: bold; } .traces { margin: 2em 0; } .trace { margin: 0.5em 0; padding: 0.5em; } .trace.app { border: 1px dashed #c00; } .trace .number { text-align: right; width: 2em; padding: 0.5em; } .trace .content { padding: 0.5em; } .trace .plus, .trace .minus { display:inline; vertical-align:middle; text-align:center; border:1px solid #000; color:#000; font-size:10px; line-height:10px; margin:0; padding:0 1px; width:10px; height:10px; } .trace.collapsed .minus, .trace.expanded .plus, .trace.collapsed pre { display: none; } .trace-file { cursor: pointer; padding: 0.2em; } .trace-file:hover { background: #f0ffff; } /*]]>*/ </style> </head> <body> <div class="container"> <h1>CException</h1> <p class="message"> Property "Quota.defaultlanguage" is not defined. </p> <div class="source"> <p class="file">/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/db/ar/CActiveRecord.php(145)</p> <div class="code"><pre><span class="ln">133</span> */ <span class="ln">134</span> public function __get($name) <span class="ln">135</span> { <span class="ln">136</span> if(isset($this->_attributes[$name])) <span class="ln">137</span> return $this->_attributes[$name]; <span class="ln">138</span> elseif(isset($this->getMetaData()->columns[$name])) <span class="ln">139</span> return null; <span class="ln">140</span> elseif(isset($this->_related[$name])) <span class="ln">141</span> return $this->_related[$name]; <span class="ln">142</span> elseif(isset($this->getMetaData()->relations[$name])) <span class="ln">143</span> return $this->getRelated($name); <span class="ln">144</span> else <span class="error"><span class="ln error-ln">145</span> return parent::__get($name); </span><span class="ln">146</span> } <span class="ln">147</span> <span class="ln">148</span> /** <span class="ln">149</span> * PHP setter magic method. <span class="ln">150</span> * This method is overridden so that AR attributes can be accessed like properties. <span class="ln">151</span> * @param string $name property name <span class="ln">152</span> * @param mixed $value property value <span class="ln">153</span> */ <span class="ln">154</span> public function __set($name,$value) <span class="ln">155</span> { <span class="ln">156</span> if($this->setAttribute($name,$value)===false) <span class="ln">157</span> { </pre></div> </div> <div class="traces"> <h2>Stack Trace</h2> <table style="width:100%;"> <tbody><tr class="trace core collapsed"> <td class="number"> #0 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/db/ar/CActiveRecord.php(145): <strong>CComponent</strong>-><strong>__get</strong>("defaultlanguage") </div> <div class="code"><pre><span class="ln">140</span> elseif(isset($this->_related[$name])) <span class="ln">141</span> return $this->_related[$name]; <span class="ln">142</span> elseif(isset($this->getMetaData()->relations[$name])) <span class="ln">143</span> return $this->getRelated($name); <span class="ln">144</span> else <span class="error"><span class="ln error-ln">145</span> return parent::__get($name); </span><span class="ln">146</span> } <span class="ln">147</span> <span class="ln">148</span> /** <span class="ln">149</span> * PHP setter magic method. <span class="ln">150</span> * This method is overridden so that AR attributes can be accessed like properties. </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #1 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/helpers/common_helper.php(6128): <strong>CActiveRecord</strong>-><strong>__get</strong>("defaultlanguage") </div> <div class="code"><pre><span class="ln">6123</span> //while ($survey_quotas = $result->FetchRow()) <span class="ln">6124</span> foreach ($result as $_survey_quotas) <span class="ln">6125</span> { <span class="ln">6126</span> $survey_quotas = $_survey_quotas->attributes; <span class="ln">6127</span> // !!! Doubting this <span class="error"><span class="ln error-ln">6128</span> foreach ($_survey_quotas->defaultlanguage as $k => $v) </span><span class="ln">6129</span> $survey_quotas[$k] = $v; <span class="ln">6130</span> <span class="ln">6131</span> array_push($quota_info,array('Name' => $survey_quotas['name'], <span class="ln">6132</span> 'Limit' => $survey_quotas['qlimit'], <span class="ln">6133</span> 'Action' => $survey_quotas['action'], </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #2 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/helpers/common_helper.php(5935): <strong>getQuotaInformation</strong>("151331", "en", "14") </div> <div class="code"><pre><span class="ln">5930</span> * @return mixed - Integer of matching entries in the result DB or 'N/A' <span class="ln">5931</span> */ <span class="ln">5932</span> function getQuotaCompletedCount($iSurveyId, $quotaid) <span class="ln">5933</span> { <span class="ln">5934</span> $result = "N/A"; <span class="error"><span class="ln error-ln">5935</span> $quota_info = getQuotaInformation($iSurveyId, Survey::model()->findByPk($iSurveyId)->language, $quotaid); </span><span class="ln">5936</span> $quota = $quota_info[0]; <span class="ln">5937</span> <span class="ln">5938</span> if (Yii::app()->db->schema->getTable('{{survey_' . $iSurveyId . '}}') && <span class="ln">5939</span> count($quota['members']) > 0) <span class="ln">5940</span> { </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #3 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/controllers/admin/quotas.php(118): <strong>getQuotaCompletedCount</strong>("151331", "14") </div> <div class="code"><pre><span class="ln">113</span> $aViewUrls['output'] = ''; <span class="ln">114</span> //loop through all quotas <span class="ln">115</span> foreach ($aResult as $aQuotaListing) <span class="ln">116</span> { <span class="ln">117</span> $totalquotas += $aQuotaListing['qlimit']; <span class="error"><span class="ln error-ln">118</span> $completed = getQuotaCompletedCount($iSurveyId, $aQuotaListing['id']); </span><span class="ln">119</span> $highlight = ($completed >= $aQuotaListing['qlimit']) ? '' : "style='color: orange'"; //Incomplete quotas displayed in red <span class="ln">120</span> $totalcompleted = $totalcompleted + $completed; <span class="ln">121</span> $csvoutput[] = $aQuotaListing['name'] . "," . $aQuotaListing['qlimit'] . "," . $completed . "," . ($aQuotaListing['qlimit'] - $completed) . "\r\n"; <span class="ln">122</span> <span class="ln">123</span> if ($quickreport != false) </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #4 </td> <td class="content"> <div class="trace-file"> unknown(0): <strong>quotas</strong>-><strong>index</strong>("151331", false) </div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #5 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/actions/CAction.php(108): <strong>ReflectionMethod</strong>-><strong>invokeArgs</strong>(quotas, array("151331", false)) </div> <div class="code"><pre><span class="ln">103</span> elseif($param->isDefaultValueAvailable()) <span class="ln">104</span> $ps[]=$param->getDefaultValue(); <span class="ln">105</span> else <span class="ln">106</span> return false; <span class="ln">107</span> } <span class="error"><span class="ln error-ln">108</span> $method->invokeArgs($object,$ps); </span><span class="ln">109</span> return true; <span class="ln">110</span> } <span class="ln">111</span> } </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #6 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/core/Survey_Common_Action.php(99): <strong>CAction</strong>-><strong>runWithParamsInternal</strong>(quotas, ReflectionMethod, array("surveyid" => "151331", "sa" => "index", "iSurveyId" => "151331", "iSurveyID" => "151331")) </div> <div class="code"><pre><span class="ln">094</span> $oMethod = new ReflectionMethod($this, $sDefault); <span class="ln">095</span> } <span class="ln">096</span> <span class="ln">097</span> // We're all good to go, let's execute it <span class="ln">098</span> // runWithParamsInternal would automatically get the parameters of the method and populate them as required with the params <span class="error"><span class="ln error-ln">099</span> return parent::runWithParamsInternal($this, $oMethod, $params); </span><span class="ln">100</span> } <span class="ln">101</span> <span class="ln">102</span> /** <span class="ln">103</span> * Some functions have different parameters, which are just an alias of the <span class="ln">104</span> * usual parameters we're getting in the url. This function just populates </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #7 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(308): <strong>Survey_Common_Action</strong>-><strong>runWithParams</strong>(array("surveyid" => "151331", "sa" => "index")) </div> <div class="code"><pre><span class="ln">303</span> { <span class="ln">304</span> $priorAction=$this->_action; <span class="ln">305</span> $this->_action=$action; <span class="ln">306</span> if($this->beforeAction($action)) <span class="ln">307</span> { <span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false) </span><span class="ln">309</span> $this->invalidActionParams($action); <span class="ln">310</span> else <span class="ln">311</span> $this->afterAction($action); <span class="ln">312</span> } <span class="ln">313</span> $this->_action=$priorAction; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #8 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(quotas) </div> <div class="code"><pre><span class="ln">281</span> * @see runAction <span class="ln">282</span> */ <span class="ln">283</span> public function runActionWithFilters($action,$filters) <span class="ln">284</span> { <span class="ln">285</span> if(empty($filters)) <span class="error"><span class="ln error-ln">286</span> $this->runAction($action); </span><span class="ln">287</span> else <span class="ln">288</span> { <span class="ln">289</span> $priorAction=$this->_action; <span class="ln">290</span> $this->_action=$action; <span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run(); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #9 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(quotas, array()) </div> <div class="code"><pre><span class="ln">260</span> { <span class="ln">261</span> if(($parent=$this->getModule())===null) <span class="ln">262</span> $parent=Yii::app(); <span class="ln">263</span> if($parent->beforeControllerAction($this,$action)) <span class="ln">264</span> { <span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters()); </span><span class="ln">266</span> $parent->afterControllerAction($this,$action); <span class="ln">267</span> } <span class="ln">268</span> } <span class="ln">269</span> else <span class="ln">270</span> $this->missingAction($actionID); </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #10 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/controllers/AdminController.php(169): <strong>CController</strong>-><strong>run</strong>("quotas") </div> <div class="code"><pre><span class="ln">164</span> $this->redirect(array('/admin/authentication/sa/login')); <span class="ln">165</span> } <span class="ln">166</span> <span class="ln">167</span> } <span class="ln">168</span> <span class="error"><span class="ln error-ln">169</span> return parent::run($action); </span><span class="ln">170</span> } <span class="ln">171</span> <span class="ln">172</span> /** <span class="ln">173</span> * Routes all the actions to their respective places <span class="ln">174</span> * </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #11 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CWebApplication.php(282): <strong>AdminController</strong>-><strong>run</strong>("quotas") </div> <div class="code"><pre><span class="ln">277</span> { <span class="ln">278</span> list($controller,$actionID)=$ca; <span class="ln">279</span> $oldController=$this->_controller; <span class="ln">280</span> $this->_controller=$controller; <span class="ln">281</span> $controller->init(); <span class="error"><span class="ln error-ln">282</span> $controller->run($actionID); </span><span class="ln">283</span> $this->_controller=$oldController; <span class="ln">284</span> } <span class="ln">285</span> else <span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".', <span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route))); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #12 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("admin/quotas/sa/index") </div> <div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value) <span class="ln">137</span> $_GET[$name]=$value; <span class="ln">138</span> } <span class="ln">139</span> else <span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest()); <span class="error"><span class="ln error-ln">141</span> $this->runController($route); </span><span class="ln">142</span> } <span class="ln">143</span> <span class="ln">144</span> /** <span class="ln">145</span> * Registers the core application components. <span class="ln">146</span> * This method overrides the parent implementation by registering additional core components. </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #13 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/base/CApplication.php(180): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div> <div class="code"><pre><span class="ln">175</span> public function run() <span class="ln">176</span> { <span class="ln">177</span> if($this->hasEventHandler('onBeginRequest')) <span class="ln">178</span> $this->onBeginRequest(new CEvent($this)); <span class="ln">179</span> register_shutdown_function(array($this,'end'),0,false); <span class="error"><span class="ln error-ln">180</span> $this->processRequest(); </span><span class="ln">181</span> if($this->hasEventHandler('onEndRequest')) <span class="ln">182</span> $this->onEndRequest(new CEvent($this)); <span class="ln">183</span> } <span class="ln">184</span> <span class="ln">185</span> /** </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #14 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/index.php(190): <strong>CApplication</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">185</span> die (sprintf('%s should be writable by the webserver (755 or 775).', $runtimePath)); <span class="ln">186</span> } <span class="ln">187</span> } <span class="ln">188</span> <span class="ln">189</span> <span class="error"><span class="ln error-ln">190</span> Yii::createApplication('LSYii_Application', $config)->run(); </span><span class="ln">191</span> <span class="ln">192</span> /* End of file index.php */ <span class="ln">193</span> /* Location: ./index.php */</pre></div> </td> </tr> </tbody></table> </div> <div class="version"> 2014-01-09 16:48:47 Apache/2.2.16 (Debian) <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.14 </div> </div> <script type="text/javascript"> /*<![CDATA[*/ var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)"); var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)"); var e = document.getElementsByTagName("div"); for(var j=0,len=e.length;j<len;j++){ if(traceReg.test(e[j].className)){ e[j].onclick = function(){ var trace = this.parentNode.parentNode; if(collapsedReg.test(trace.className)) trace.className = trace.className.replace("collapsed", "expanded"); else trace.className = trace.className.replace("expanded", "collapsed"); } } } /*]]>*/ </script> </body></html> | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 131206 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Firefox and Google Chrome | ||||
Database type & version | MySQL 5.0.45 | ||||
Server OS (if known) | Red Hat Enterprise Linux Server release 5.3 (Tikanga) | ||||
Webserver software & version (if known) | Apache/2.2.3 (CentOS) | ||||
PHP Version | PHP Version 5.1.6 | ||||
I have imported the attached survey. When adding an answer to the existing quota, the answer options are in Portuguese, though the main language is English. |
|
Yeah !!! And i have : |
|
Thanks for checking this, Denis. Can you also provide a fix? |
|
Not now : because it's more complicated than i think : fix can affect public survey too and al quota system must be reviewed here. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13693 |
|
2.05+ Build 140116 released |
|
LimeSurvey: master f93f9c4a 2014-01-15 17:21 Details Diff |
Fixed issue 08517: Quota Answers not in Base Language Dev: 08517 fixed by $surveyinfo=getSurveyInfo($surveyid,$language); Dev: Don't understand where we can found defaultlanguage ? Dev: Quick fix : Quota need some rewrite |
Affected Issues 08517 |
|
mod - application/helpers/common_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2014-01-08 09:56 | mmirasol | New Issue | |
2014-01-08 09:56 | mmirasol | File Added: limesurvey_survey_151331.lss | |
2014-01-08 11:12 | Mazi | Note Added: 27755 | |
2014-01-08 11:18 | Mazi | Assigned To | => DenisChenu |
2014-01-08 11:18 | Mazi | Status | new => assigned |
2014-01-09 17:49 | DenisChenu | Note Added: 27792 | |
2014-01-09 17:49 | DenisChenu | File Added: CException.html | |
2014-01-09 17:50 | DenisChenu | Issue Monitored: DenisChenu | |
2014-01-09 17:50 | DenisChenu | Assigned To | DenisChenu => |
2014-01-09 17:50 | DenisChenu | Status | assigned => new |
2014-01-09 21:36 | Mazi | Assigned To | => DenisChenu |
2014-01-09 21:36 | Mazi | Status | new => assigned |
2014-01-09 21:36 | Mazi | Note Added: 27794 | |
2014-01-10 08:28 | DenisChenu | Note Added: 27813 | |
2014-01-15 17:22 | DenisChenu | Changeset attached | => LimeSurvey master f93f9c4a |
2014-01-15 17:22 | DenisChenu | Note Added: 27887 | |
2014-01-15 17:22 | DenisChenu | Resolution | open => fixed |
2014-01-15 17:22 | DenisChenu | Status | assigned => resolved |
2014-01-15 17:22 | DenisChenu | Fixed in Version | => 2.05+ |
2014-01-16 16:45 | c_schmitz | Note Added: 27907 | |
2014-01-16 16:45 | c_schmitz | Status | resolved => closed |
2021-08-04 05:18 | guest | Bug heat | 6 => 8 |