View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
08174Bug reportsConditionspublic2013-09-23 13:18
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Summary08174: Unable to remove bad conditions
Description

If you import a question with bad condition, there are no way to remove it.

Steps To Reproduce

Create en english survey, add a group, import lsq file joined.
Look at EM: error on condition.

Try to remove the condition with condition GUI editor : no condition

Additional Information

Trying Check integrity too : this one is broken too .
Before check integrity remove bad condition from GUI.

TagsNo tags attached.
Attached Files
h18f2be1.lsq (88,795 bytes)
Bug heat4
Complete LimeSurvey version number (& build)130919
I will donate to the project if issue is resolvedNo
BrowserFF22
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

child of 08137 closedc_schmitz Relevance equation incorrectly saved for questions 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-09-19 19:27

developer   ~26296

Correction : There are no condition in Models. But the new 'condition' detection finc a condition.
It's OK in 2.05 : we can remove the text in equation.

In 2.05, addinf a new $data:
$eqrow['conditions_number'] = Condition::Model()->count("qid=:qid", array('qid' => $qid));
and test if >0.

in 2.00:
$aData['bRelevanceReadOnly']= Questions::model()->hasConditions($aData['qid'])>0;

But seems Questions::model()->hasConditions broken:
It return allways one if i don't make error:

return self::model()->count('qid = '.$iQuestionID);
is same than
return Question::model()->count('qid = '.$iQuestionID);

DenisChenu

DenisChenu

2013-09-19 19:28

developer   ~26297

Last edited: 2013-09-20 08:59

Questions::model()->hasConditions broken: confirmed: add a new question : can not edit condition :)

PS: think Questions::model()->hasConditions must return TRUE if there are Expression in Relevance too.

Return FALSE only if this relevance return allways true (empty or 1 for start).

c_schmitz

c_schmitz

2013-09-23 13:18

administrator   ~26316

Thank you! Dumb me!

Related Changesets

LimeSurvey: 2.05 854d3c3e

2013-05-23 16:35:18

DenisChenu

Details Diff
Fixed issue : Relevance equation seems to be editable even if not.
Dev: add a test if condition exist
Affected Issues
08137, 08174
mod - application/controllers/admin/questions.php Diff File
mod - application/views/admin/survey/Question/editQuestion_view.php Diff File

Issue History

Date Modified Username Field Change
2013-09-19 17:47 DenisChenu New Issue
2013-09-19 17:47 DenisChenu File Added: h18f2be1.lsq
2013-09-19 19:27 DenisChenu Note Added: 26296
2013-09-19 19:27 DenisChenu Assigned To => c_schmitz
2013-09-19 19:27 DenisChenu Status new => assigned
2013-09-19 19:28 DenisChenu Note Added: 26297
2013-09-19 21:06 DenisChenu Relationship added child of 08137
2013-09-19 21:17 DenisChenu Changeset attached => LimeSurvey 2.05 854d3c3e
2013-09-20 08:59 DenisChenu Note Edited: 26297
2013-09-23 13:18 c_schmitz Status assigned => closed
2013-09-23 13:18 c_schmitz Resolution open => fixed
2013-09-23 13:18 c_schmitz Note Added: 26316