View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
08130 | Bug reports | RemoteControl | public | 2013-09-04 23:08 | 2013-09-29 15:27 |
Reporter | blueimpb | Assigned To | trougakoss | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00+ | ||||
Fixed in Version | 2.00+ | ||||
Summary | 08130: RemoteControl import_survey erroneously reports failure | ||||
Description | import_survey() in remotecontrol.php is supposed to deliver the ID of the newly created survey as the result parameter. Instead it delivers an empty error string ("Error: ") because importSurveyResults() (in import_helper.php) returns a hash with an empty, but non-null, entry for "error". This can be fixed by testing for a non-empty 'error' string:
| ||||
Steps To Reproduce | Send an import_survey request to RemoteControl, and check the result string. Rather than: "result":123456 it'll contain: "result":{"status":"Error: ","error":null} | ||||
Tags | No tags attached. | ||||
Attached Files | policy.txt (30,398 bytes)
class type/scale name relevance text help language validation mandatory other default same_default allowed_filetypes alphasort answer_width array_filter array_filter_exclude assessment_value category_separator display_columns display_rows dropdown_dates_year_min dropdown_dates dropdown_dates_year_max dropdown_prefix dropdown_prepostfix dropdown_separators dropdown_size dualscale_headerA dualscale_headerB em_validation_q_tip em_validation_q em_validation_sq em_validation_sq_tip equals_num_value exclude_all_others exclude_all_others_auto hidden hide_tip input_boxes location_city location_country location_defaultcoordinates location_mapheight location_mapservice location_mapwidth location_mapzoom location_nodefaultfromip location_postal location_state max_answers max_filesize max_num_of_files max_num_value max_num_value_n maximum_chars min_answers min_num_of_files min_num_value min_num_value_n multiflexible_checkbox multiflexible_max multiflexible_min multiflexible_step num_value_int_only numbers_only other_comment_mandatory other_numbers_only other_replace_text page_break prefix public_statistics random_group random_order reverse scale_export show_comment show_grand_total show_title show_totals slider_accuracy slider_default slider_layout slider_max slider_middlestart slider_min slider_rating slider_separator slider_showminmax suffix text_input_width time_limit_action time_limit_countdown_message time_limit_disable_next time_limit_disable_prev time_limit_message time_limit_message_delay time_limit_message_style time_limit_timer_style time_limit_warning_2_display_time time_limit_warning_2_message time_limit_warning_2_style time_limit_warning_2 time_limit_warning time_limit time_limit_warning_display_time time_limit_warning_message time_limit_warning_style use_dropdown S sid S owner_id 1 S admin Administrator S active N S adminemail lance@measurabl.com S anonymized N S format G S savetimings N S template skeletonquest S language en S datestamp N S usecookie N S allowregister N S allowsave Y S autonumber_start 8 S autoredirect N S allowprev Y S printanswers N S ipaddr N S refurl N S datecreated S publicstatistics N S publicgraphs N S listpublic N S htmlemail Y S sendconfirmation Y S tokenanswerspersistence N S assessments N S usecaptcha N S usetokens N S bounce_email lance@getgnb.com S attributedescriptions a:0:{} S tokenlength 15 S showxquestions N S showgroupinfo X S shownoanswer Y S showqnumcode X S bounceprocessing N S showwelcome N S showprogress N S allowjumps N S navigationdelay 0 S nokeyboard N S alloweditaftercompletion N S googleanalyticsstyle 0 SL surveyls_title Policy & Disclosure en SL surveyls_email_invite_subj Invitation to participate in a survey en SL surveyls_email_invite Dear {FIRSTNAME}, you have been invited to participate in a survey. The survey is titled: "{SURVEYNAME}" "{SURVEYDESCRIPTION}" To participate, please click on the link below. Sincerely, {ADMINNAME} ({ADMINEMAIL}) ---------------------------------------------- Click here to do the survey: {SURVEYURL} If you do not want to participate in this survey and don't want to receive any more invitations please click the following link: {OPTOUTURL} If you are blacklisted but want to participate in this survey and want to receive invitations please click the following link: {OPTINURL} en SL surveyls_email_remind_subj Reminder to participate in a survey en SL surveyls_email_remind Dear {FIRSTNAME}, Recently we invited you to participate in a survey. We note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part. The survey is titled: "{SURVEYNAME}" "{SURVEYDESCRIPTION}" To participate, please click on the link below. Sincerely, {ADMINNAME} ({ADMINEMAIL}) ---------------------------------------------- Click here to do the survey: {SURVEYURL} If you do not want to participate in this survey and don't want to receive any more invitations please click the following link: {OPTOUTURL} en SL surveyls_email_register_subj Survey registration confirmation en SL surveyls_email_register Dear {FIRSTNAME}, You, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}. To complete this survey, click on the following URL: {SURVEYURL} If you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}. en SL surveyls_email_confirm_subj Confirmation of your participation in our survey en SL surveyls_email_confirm Dear {FIRSTNAME}, this email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating. If you have any further questions about this email, please contact {ADMINNAME} on {ADMINEMAIL}. Sincerely, {ADMINNAME} en SL surveyls_dateformat 9 en SL surveyls_attributecaptions a:0:{} en SL email_admin_notification_subj Response submission for survey {SURVEYNAME} en SL email_admin_notification Hello, A new response was submitted for your survey '{SURVEYNAME}'. Click the following link to reload the survey: {RELOADURL} Click the following link to see the individual response: {VIEWRESPONSEURL} Click the following link to edit the individual response: {EDITRESPONSEURL} View statistics by clicking here: {STATISTICSURL} en SL email_admin_responses_subj Response submission for survey {SURVEYNAME} with results en SL email_admin_responses Hello, A new response was submitted for your survey '{SURVEYNAME}'. Click the following link to reload the survey: {RELOADURL} Click the following link to see the individual response: {VIEWRESPONSEURL} Click the following link to edit the individual response: {EDITRESPONSEURL} View statistics by clicking here: {STATISTICSURL} The following answers were given by the participant: {ANSWERTABLE} en SL surveyls_numberformat 0 en G Page 1 1 en Q Y PD1 1 Did {PC1} disclose its sustainability performance last year? en N N 1 Q M PD1A ((PD1.NAOK == "Y")) Wonderful! In what ways did {PC1} disclose?<script type="text/javascript" charset="utf-8">$(document).ready(function() { NestedQuestionPD1A_A6_2();NestedQuestionPD1A_A6_1();NestedQuestionPD1A_A5_2();NestedQuestionPD1A_A5_1();NestedQuestionPD1A_A4_1();NestedQuestionPD1A_A3_2();NestedQuestionPD1A_A3_1();NestedQuestionPD1A_A2_1();NestedQuestionPD1A_A1_2();NestedQuestionPD1A_A1_1();});</script> en N N 1 SQ A1 Section in annual report en SQ A2 Stand-alone Corporate Social Responsibility or Corporate Sustainability report en SQ A3 Integrated Report An integrated report is one that includes sustainability as part of your larger annual company report as opposed to being a stand alone report.If you follow the <a href="https://www.globalreporting.org/reporting/reporting-framework-overview/Pages/default.aspx">Global Reporting Initiative (GRI) methodology</a> you issue an integrated report. en SQ A4 Dedicated section on our corporate website en SQ A5 Section in our report to investors en SQ A6 Other en Q S PD1A_A1_1 ((PD1A_A1.NAOK == "Y")) Page of {PC1}'s report on which information appears:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A1_1() { var q = document.getElementById(LEMalias2varName.PD1A_A1).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. 27 1 Q S PD1A_A1_2 ((PD1A_A1.NAOK == "Y")) Link to report:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A1_2() { var q = document.getElementById(LEMalias2varName.PD1A_A1).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD1A_A2_1 ((PD1A_A2.NAOK == "Y")) Link to report:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A2_1() { var q = document.getElementById(LEMalias2varName.PD1A_A2).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD1A_A3_1 ((PD1A_A3.NAOK == "Y")) Page of {PC1}'s report on which information appears:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A3_1() { var q = document.getElementById(LEMalias2varName.PD1A_A3).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. 27 1 Q S PD1A_A3_2 ((PD1A_A3.NAOK == "Y")) Link to report:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A3_2() { var q = document.getElementById(LEMalias2varName.PD1A_A3).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD1A_A4_1 ((PD1A_A4.NAOK == "Y")) Link to report:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A4_1() { var q = document.getElementById(LEMalias2varName.PD1A_A4).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD1A_A5_1 ((PD1A_A5.NAOK == "Y")) Frequency of reports:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A5_1() { var q = document.getElementById(LEMalias2varName.PD1A_A5).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. Monthly 1 Q S PD1A_A5_2 ((PD1A_A5.NAOK == "Y")) Link to report:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A5_2() { var q = document.getElementById(LEMalias2varName.PD1A_A5).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD1A_A6_1 ((PD1A_A6.NAOK == "Y")) Please specify:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A6_1() { var q = document.getElementById(LEMalias2varName.PD1A_A6).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. GRESB 1 Q S PD1A_A6_2 ((PD1A_A6.NAOK == "Y")) Link to report:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1A_A6_2() { var q = document.getElementById(LEMalias2varName.PD1A_A6).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 G Page 2 1 en Q M PD1B 1 Which framework was followed in preparing your disclosure?<script type="text/javascript" charset="utf-8">$(document).ready(function() { NestedQuestionPD1B_A1_3();NestedQuestionPD1B_A1_2();NestedQuestionPD1B_A1_1();});</script> en N N 1 SQ A1 Global Reporting Initative (GRI) GRI is the world's oldest and largest sustainability reporting protocol. Many organizations follow it's guidelines when creating their annual reports.<a href="https://www.globalreporting.org/Pages/default.aspx">You can learn more here.</a> en SQ A2 Carbon Disclosure Project (CDP) CDP is a sustainability reporting protocol similar to GRESB except that organizations of all types use it to report on sustainability, not just real estate companies. CDP holds the largest repository of corporate carbon emissions data en SQ A3 AA 1000 AA 1000 is a methodology assurance providers follow when evaluating your sustainability performance.<a href="http://www.accountability.org/standards/">You can learn more here.</a> en SQ A4 ISAE 3000 ISAE is an assurance standard often used by auditors to guide their review of sustainability disclosures.<a href="http://www.ifac.org/publications-resources/isae-3000-revised-assurance-engagements-other-audits-or-reviews-historical-fi">You can learn more here.</a> en SQ A5 ISO ISO stands for "International Organization for Standardization". It's the world's largest standards body and companies frequently use their Environmental Management standard, 14001, when creating a sustainability program.<a href="http://www.iso.org/iso/home.html">You can learn more here.</a> en SQ A6 Other en SQ A7 We didn't use a reporting or accounting standard en Q S PD1B_A1_1 ((PD1B_A1.NAOK == "Y")) What GRI grade level did you earn?<script type="text/javascript" charset="utf-8">function NestedQuestionPD1B_A1_1() { var q = document.getElementById(LEMalias2varName.PD1B_A1).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. A+ 1 Q S PD1B_A1_2 ((PD1B_A5.NAOK == "Y")) Which ISO standard?<script type="text/javascript" charset="utf-8">function NestedQuestionPD1B_A1_2() { var q = document.getElementById(LEMalias2varName.PD1B_A5).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. 14001 1 Q S PD1B_A1_3 ((PD1B_A7.NAOK == "Y")) Please specify:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1B_A1_3() { var q = document.getElementById(LEMalias2varName.PD1B_A7).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***Name of standard 1 G Page 3 1 en Q L PD1C 1 Was your disclosure externally assured?<script type="text/javascript" charset="utf-8">$(document).ready(function() { NestedQuestionPD1C_A1_3();NestedQuestionPD1C_A1_2();NestedQuestionPD1C_A1_1();});</script> en N N 1 A A1 Yes, fully assured by a third party. en A A2 Yes, partially assured by a third party. en A A3 No, but a third party reviewed the information. en A A4 Neither assured nor reviewed by a third party. en Q S PD1C_A1_1 ((PD1C.NAOK == "A1")) Great, what's your assurer's name?<script type="text/javascript" charset="utf-8">function NestedQuestionPD1C_A1_1() { var q = document.getElementById('answer' + (LEMvarNameAttr[LEMalias2varName.PD1C]).sgqa + 'A1').parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. Measurabl 1 Q S PD1C_A1_2 ((PD1C.NAOK == "A2")) Great, what's your assurer's name?<script type="text/javascript" charset="utf-8">function NestedQuestionPD1C_A1_2() { var q = document.getElementById('answer' + (LEMvarNameAttr[LEMalias2varName.PD1C]).sgqa + 'A2').parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. Measurabl 1 Q S PD1C_A1_3 ((PD1C.NAOK == "A3")) Name of your reviewer:<script type="text/javascript" charset="utf-8">function NestedQuestionPD1C_A1_3() { var q = document.getElementById('answer' + (LEMvarNameAttr[LEMalias2varName.PD1C]).sgqa + 'A3').parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. Measurabl 1 G Page 4 1 en Q M PD2 1 Did {PC1} have a policy addressing any of the following last year?<script type="text/javascript" charset="utf-8">$(document).ready(function() { NestedQuestionPD2_A1_8();NestedQuestionPD2_A1_7();NestedQuestionPD2_A1_6();NestedQuestionPD2_A1_5();NestedQuestionPD2_A1_4();NestedQuestionPD2_A1_3();NestedQuestionPD2_A1_2();NestedQuestionPD2_A1_1();});</script> A policy is a formal declaration of principles and objectives.It's implemented via procedures that also come with their own set of supporting documentation. en N N 1 SQ A1 Energy consumption en SQ A2 GHG emissions en SQ A3 Water consumption en SQ A4 Waste management en SQ A5 Climate change en SQ A6 Health and safety en SQ A7 Other en SQ A8 None of the above en Q S PD2_A1_1 ((PD2_A1.NAOK == "Y")) Link to supporting documents:<script type="text/javascript" charset="utf-8">function NestedQuestionPD2_A1_1() { var q = document.getElementById(LEMalias2varName.PD2_A1).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD2_A1_2 ((PD2_A2.NAOK == "Y")) Link to supporting documents:<script type="text/javascript" charset="utf-8">function NestedQuestionPD2_A1_2() { var q = document.getElementById(LEMalias2varName.PD2_A2).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD2_A1_3 ((PD2_A3.NAOK == "Y")) Link to supporting documents:<script type="text/javascript" charset="utf-8">function NestedQuestionPD2_A1_3() { var q = document.getElementById(LEMalias2varName.PD2_A3).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD2_A1_4 ((PD2_A4.NAOK == "Y")) Link to supporting documents:<script type="text/javascript" charset="utf-8">function NestedQuestionPD2_A1_4() { var q = document.getElementById(LEMalias2varName.PD2_A4).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD2_A1_5 ((PD2_A5.NAOK == "Y")) Link to supporting documents:<script type="text/javascript" charset="utf-8">function NestedQuestionPD2_A1_5() { var q = document.getElementById(LEMalias2varName.PD2_A5).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD2_A1_6 ((PD2_A6.NAOK == "Y")) Link to supporting documents:<script type="text/javascript" charset="utf-8">function NestedQuestionPD2_A1_6() { var q = document.getElementById(LEMalias2varName.PD2_A6).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 Q S PD2_A1_7 ((PD2_A7.NAOK == "Y")) Please specify the issue:<script type="text/javascript" charset="utf-8">function NestedQuestionPD2_A1_7() { var q = document.getElementById(LEMalias2varName.PD2_A7).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***e.g. Air pollution 1 Q S PD2_A1_8 ((PD2_A8.NAOK == "Y")) Link to supporting documents:<script type="text/javascript" charset="utf-8">function NestedQuestionPD2_A1_8() { var q = document.getElementById(LEMalias2varName.PD2_A8).parentNode;var sq = document.getElementById('question' + '{QID}');$(q).after(sq);};</script> en N N ***http://www.website.com 1 | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 130708 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | n/a | ||||
Database type & version | mysql 5.5.31 | ||||
Server OS (if known) | Ubuntu 13.04 | ||||
Webserver software & version (if known) | nginx 1.2.6 | ||||
PHP Version | 5.4.9 | ||||
blueimpb, can you provide me with the survey file you are trying to import so as to test the exact case? |
|
I'd be happy to, but the only file format I have available is TSV (.txt) so using that format with the RemoteControl API requires fixing http://bugs.limesurvey.org/view.php?id=8129 (which is very easy, just a matter of adding "txt" to the list of allowed types in remotecontrol.php). I've attached the JSON-RPC request that contains the TSV file. |
|
I have already fixed the issue 8129 and will do the pull request probably along side with issue 8130. So if its not a problem please attach the tsv file |
|
Not at all, please find policy.txt attached |
|
Pull request sent |
|
Version 2.00+ Build 130929 released |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2013-09-04 23:08 | blueimpb | New Issue | |
2013-09-05 11:55 | Mazi | Assigned To | => trougakoss |
2013-09-05 11:55 | Mazi | Status | new => assigned |
2013-09-06 10:07 | trougakoss | Note Added: 26164 | |
2013-09-06 14:28 | blueimpb | Note Added: 26167 | |
2013-09-06 14:29 | blueimpb | File Added: tsv.json | |
2013-09-06 15:37 | trougakoss | Note Added: 26169 | |
2013-09-06 15:54 | blueimpb | Note Added: 26170 | |
2013-09-06 15:54 | blueimpb | File Added: policy.txt | |
2013-09-06 16:26 | trougakoss | Note Added: 26171 | |
2013-09-25 22:41 | c_schmitz | Changeset attached | => LimeSurvey master e2a45764 |
2013-09-25 22:41 | c_schmitz | Status | assigned => resolved |
2013-09-25 22:41 | c_schmitz | Fixed in Version | => 2.00+ |
2013-09-25 22:41 | c_schmitz | Resolution | open => fixed |
2013-09-29 15:27 | c_schmitz | Note Added: 26431 | |
2013-09-29 15:27 | c_schmitz | Status | resolved => closed |