View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
08120Bug reportsOtherpublic2013-09-02 03:092013-09-15 14:36
ReporterDeveloperChris Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary08120: users with IE 8 cannot delete a survey response
Description

Due to javascript errors users with IE 8 cannot delete a surveys response

Steps To Reproduce

Give a user delete rights
open survey results table (last 50)
Try to delete a response.

Nothing happens.

IE reports an error: "Object doesn't support this property or method"

Additional Information

The problem is the way the jquery.trim funcion is called. it is not called as documented here..
http://api.jquery.com/jQuery.trim/

instead it is incorrectly called as a chained function
if($(this).text().trim().length > 30) { ... }

The attached patch fixes it

TagsNo tags attached.
Attached Files
browse.js.patch (2,060 bytes)    
diff --git a/public_html/scripts/admin/browse.js b/public_html/scripts/admin/browse.js
index 524f089..b90b082 100644
--- a/public_html/scripts/admin/browse.js
+++ b/public_html/scripts/admin/browse.js
@@ -14,7 +14,7 @@
 $(document).ready(function(){
     $('ul.sf-menu').superfish({
         speed:'fast'
-    }); 
+    });
     $("#selectall").click(function(){
         $('.cbResponseMarker').attr('checked',$(this).attr('checked'));
     });
@@ -23,7 +23,7 @@ $(document).ready(function(){
         $("#limit").val('');
         $("#browseresults").submit();
     });
-    
+
     $('#browseresponses').qtip({
         content:{
             text:$('#browselangpopup')
@@ -54,12 +54,12 @@ $(document).ready(function(){
 
     // Fix the heigh of the cell
     $('.browsetable td').each(function(){
-        if ($(this).text().trim().length > 30){
+        if ($.trim($(this).text()).length > 30){
             $(this).html("<span class=\"content\" title=\""+htmlspecialchars(htmlspecialchars($(this).text(),'ENT_HTML_QUOTE_DOUBLE'),'ENT_QUOTES')+"\">"+$(this).html()+"</span>");
         }
     });
     $('.browsetable th strong').each(function(){
-        if ($(this).text().trim().length > 30){
+        if ($.trim($(this).text()).length > 30){
             $(this).addClass("content");
             $(this).attr("title",$(this).text());
         }
@@ -231,7 +231,7 @@ Dowload a file from a response
 */
 function getFile(id, field, filename)
 {
-    sendPost(siteURL + "/admin/responses/" + surveyID + "/grid", 
+    sendPost(siteURL + "/admin/responses/" + surveyID + "/grid",
         new Array(
             'id',
             'fieldname',
@@ -253,13 +253,13 @@ Get an archive containing all the file from a response
 */
 function getArchive(id)
 {
-    sendPost(siteURL + "/admin/responses/" + surveyID + "/grid", 
+    sendPost(siteURL + "/admin/responses/" + surveyID + "/grid",
         new Array(
             'oper',
             'id'),
         new Array(
             'downloadarchive',
-            id)        
+            id)
     );
 }
browse.js.patch (2,060 bytes)   
Bug heat2
Complete LimeSurvey version number (& build)130802
I will donate to the project if issue is resolvedNo
BrowserIE 8
Database type & versionNA
Server OS (if known)NA
Webserver software & version (if known)NA
PHP VersionNA

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2013-09-12 23:35

administrator   ~26209

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12973
c_schmitz

c_schmitz

2013-09-12 23:40

administrator   ~26210

Thank you!
c_schmitz

c_schmitz

2013-09-13 08:49

administrator   ~26211

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12978

Related Changesets

LimeSurvey: master ab0088e0

2013-09-12 23:34

c_schmitz


Details Diff		 Fixed issue 08120: Users with IE 8 cannot delete a survey response Affected Issues
08120
mod - scripts/admin/browse.js Diff File

LimeSurvey: 2.05 d5b42da9

2013-09-12 23:39

c_schmitz


Details Diff		 Fixed issue 08120: Users with IE 8 cannot delete a survey response Affected Issues
08120
mod - scripts/admin/browse.js Diff File

Issue History

Date Modified Username Field Change
2013-09-02 03:09 DeveloperChris New Issue
2013-09-02 03:09 DeveloperChris File Added: browse.js.patch
2013-09-12 23:31 c_schmitz Assigned To => c_schmitz
2013-09-12 23:31 c_schmitz Status new => assigned
2013-09-12 23:35 c_schmitz Changeset attached => LimeSurvey master ab0088e0
2013-09-12 23:35 c_schmitz Note Added: 26209
2013-09-12 23:35 c_schmitz Resolution open => fixed
2013-09-12 23:40 c_schmitz Note Added: 26210
2013-09-12 23:40 c_schmitz Status assigned => resolved
2013-09-12 23:40 c_schmitz Fixed in Version => 2.00+
2013-09-13 08:49 c_schmitz Changeset attached => LimeSurvey 2.05 d5b42da9
2013-09-13 08:49 c_schmitz Note Added: 26211
2013-09-15 14:36 c_schmitz Status resolved => closed