can someone have a look and merge if ok? Thanks, M

Fix on github: https://github.com/LimeSurvey/LimeSurvey/pull/100

same procedure for master (2.0+) :)
https://github.com/LimeSurvey/LimeSurvey/pull/101

I'm afraid there might be more of those typing problems in the code.

Will now consider more often to use

"if (!isset($val))" instead of "if ($val)"
whenever appropriate to also catch $string='0' or $int=0

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12834

Thanks for merging the pull request for the master branch. Can you also merge the one for 2.05?
https://github.com/LimeSurvey/LimeSurvey/pull/100

Thanks!
M

Hi mfaber,

I can be in IRC tomorrow.

I think , it can be best if we use Yii.
In function returnGlobal
$urlParam=Yii::app()->request->getParam($stringname) give NULL if $stringname is not in $_REQUEST.

Then we have allways isset is same than is_nul here (because we set $urlparm).

Then change all
!$urlParam to !is_null($urlParam) seems OK for me ?
And it's more clear :).

(Same behaviour but more clean and explicit).

If you're OK: update your pull request for 2.05 (not needed for 2.0)

Hi Denis, I updated the PR...hope I understood you correctly. If not, feel free to reject the PR (no problem) and fix as you think it is appropriate. Thanks, M :)

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12891

Hi mfaber !

No, great.

The important think it's not if you do what i want, it's : what did you think of using is_null and not isset ?

Version 2.00+ Build 130923 released