View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
07970Bug reportsExpression Managerpublic2013-07-04 10:582013-10-23 14:40
Reportersammousa Assigned Tosammousa  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.05 RC 
Fixed in Version2.05+ 
Summary07970: Duplicate question codes.
Description

At this moment unique question codes are not being enforced by the system.
Should we change this before 2.05 goes production?

Duplicate questioncodes basically break expression manager and many new users might be tempted to duplicate question codes before they fully understand the consequences.

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)111111
I will donate to the project if issue is resolvedNo
Browser
Database type & version1
Server OS (if known)1
Webserver software & version (if known)1
PHP Version1

Relationships

Relationship GraphDependency Graph
related to 07885 closedmdekker Multiple issues with excel/tsv export and subsequent import 

Users monitoring this issue

mfaber

Activities

mfaber

mfaber

2013-07-04 13:01

reporter   ~25711

I would vote for enforcing unique codes.
Apart from EM, also because question codes become variable names when exporting data to statistics software. These software usually rely on unique variable names and import fails if they are not. Last but not least...to me it just makes no sense to have two questions with the same question code...
DenisChenu

DenisChenu

2013-10-03 14:57

developer   ~26507

Last edited: 2013-10-04 17:50

Yes, but what for old survey compatibility ?
Only in "HTML new question" ?

Maybe just an "Confirm before save"
mfaber

mfaber

2013-10-04 20:42

reporter   ~26524

Old surveys is indeed a problem...
When updating the database from 2.00 to 2.05...there should for sure be no change to the old codes.

When importing old .lss/.txt files...most probably also no change...

When editing older surveys that are already in the database...a hint like you suggested would be best I think. "This code has already been used in this survey. It is strongly recommended that the question code be unique throughout the survey. Please be aware that, if you change the code her, you may also need to change it in other parts of the survey as well (eg., relevance equations, tailoring)."

When creating a new question (also in old surveys): we can enforce the "unique rule".
c_schmitz

c_schmitz

2013-10-11 21:35

administrator   ~26750

Yes, I agree. I will look into it.
DenisChenu

DenisChenu

2013-10-13 21:47

developer   ~26769

For models : maybe use scenario ?
http://www.yiiframework.com/wiki/266/understanding-scenarios/
sammousa

sammousa

2013-10-22 14:07

reporter   ~26901

Resolved in ae2a46cd5c33738b621bcd23360d8c4db7402830
c_schmitz

c_schmitz

2013-10-23 14:40

administrator   ~26959

2.05RC3 released

Issue History

Date Modified Username Field Change
2013-07-04 10:58 sammousa New Issue
2013-07-04 13:01 mfaber Note Added: 25711
2013-07-04 13:15 mfaber Issue Monitored: mfaber
2013-07-21 19:37 mfaber Relationship added related to 07885
2013-10-03 14:57 DenisChenu Note Added: 26507
2013-10-04 17:50 DenisChenu Note Edited: 26507
2013-10-04 20:42 mfaber Note Added: 26524
2013-10-11 21:35 c_schmitz Note Added: 26750
2013-10-11 21:35 c_schmitz Assigned To => c_schmitz
2013-10-11 21:35 c_schmitz Status new => assigned
2013-10-13 21:47 DenisChenu Note Added: 26769
2013-10-15 14:20 c_schmitz Assigned To c_schmitz => sammousa
2013-10-22 14:07 sammousa Note Added: 26901
2013-10-22 14:07 sammousa Status assigned => resolved
2013-10-22 14:07 sammousa Resolution open => fixed
2013-10-23 14:40 c_schmitz Fixed in Version => 2.05+
2013-10-23 14:40 c_schmitz Note Added: 26959
2013-10-23 14:40 c_schmitz Status resolved => closed
2021-08-02 17:32 guest Bug heat 8 => 10