View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
07951Bug reportsPrint Viewpublic2013-06-24 22:012013-07-08 13:50
Reportermfaber Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary07951: Print view don't allways take survey template
Description

When question numbers are turned on, LS shows question numbers in brackets, e.g. [23] What ist your age?

When numbering ist turned off, LS still shows the brackets on print view in front of every question:
[] What ist your age?

Steps To Reproduce

Choose any survey
Turn off question codes and numbers in survey settings
choose print view from menu

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)130611
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL 5.0.10
Server OS (if known)Win7
Webserver software & version (if known)Apache/2.4.3 (Win32)
PHP VersionPhP 5.4.7

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-06-26 11:14

developer   ~25644

Print view is a "must be move in Plugin and updated" function ;)
DenisChenu

DenisChenu

2013-06-26 11:14

developer   ~25645

mfaber: think you can take it, if no : give it to me :)
c_schmitz

c_schmitz

2013-06-26 11:29

administrator   ~25647

The [] is in the template so this is not a bug.
DenisChenu

DenisChenu

2013-06-26 11:54

developer   ~25650

2.1 dev : when print template are in new system ;)
mfaber

mfaber

2013-06-26 12:56

reporter   ~25651

aah, now I understand...have looked up and down in print-related php-file but (apparently) without success.
mfaber

mfaber

2013-06-26 13:00

reporter   ~25653

oops...just noticed my new status. I'm honored and will do my very best not to break anything!

I will use my newly given power to officially close this no-bug-report. ;)
mfaber

mfaber

2013-06-26 18:09

reporter   ~25663

c_schmitz: Ok, I found the brackets in print_question.pstpl in templates/default.

Trouble is: If I choose a template for the survey which does NOT contain the brackets in print_question.pstpl (eg. limespired or vallender) the brackets only go away when I delete them from print_question.pstpl in the DEFAULT template.

It seems the print_question.pstpl file in the respective template folder is ignored and always the one from the DEFAULT template used.
Interestingly, this seems to happen with all stock templates but when choosing one from upload/templates everything works fine (the print_question.pstpl is used).

Tested in 2.05 and in 2.00+
DenisChenu

DenisChenu

2013-06-26 19:54

developer   ~25669

<quote>Trouble is: If I choose a template for the survey which does NOT contain the brackets in print_question.pstpl (eg. limespired or vallender) the brackets only go away when I delete them from print_question.pstpl in the DEFAULT template.</quote>
Think i fixed this in 1.92 ....

Did you take it mfaber ? Else give it to me.
DenisChenu

DenisChenu

2013-06-30 16:56

developer   ~25688

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12675
DenisChenu

DenisChenu

2013-06-30 17:00

developer   ~25689

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12676
c_schmitz

c_schmitz

2013-07-08 13:50

administrator   ~25716

2.00+ Build 130708 released.

Related Changesets

LimeSurvey: master db5b2dd1

2013-06-30 16:52

DenisChenu


Details Diff		 Fixed issue 07951: Print view don't allways take survey template
Dev: fix the way $templatename is choosen, leave control of existing print_survey.pstpl (for old survey template ?)
Dev: use included function is allways best to construct again and again !..		 Affected Issues
07951
mod - application/controllers/admin/printablesurvey.php Diff File

LimeSurvey: 2.05 f9ff450a

2013-06-30 16:56

DenisChenu


Details Diff		 Fixed issue 07951: Print view don't allways take survey template
Dev: fix the way $templatename is choosen, leave control of existing print_survey.pstpl (for old survey template ?)
Dev: use included function is allways best to construct again and again !..		 Affected Issues
07951
mod - application/controllers/admin/printablesurvey.php Diff File

Issue History

Date Modified Username Field Change
2013-06-24 22:01 mfaber New Issue
2013-06-26 11:14 DenisChenu Note Added: 25644
2013-06-26 11:14 DenisChenu Note Added: 25645
2013-06-26 11:29 c_schmitz Note Added: 25647
2013-06-26 11:54 DenisChenu Note Added: 25650
2013-06-26 12:56 mfaber Note Added: 25651
2013-06-26 13:00 mfaber Note Added: 25653
2013-06-26 18:09 mfaber Note Added: 25663
2013-06-26 19:54 DenisChenu Note Added: 25669
2013-06-26 20:21 mfaber Assigned To => DenisChenu
2013-06-26 20:21 mfaber Status new => assigned
2013-06-30 16:54 DenisChenu Summary Print view shows "[]" for every question, when question numbers are turned off => Print view don't allways take survey template
2013-06-30 16:56 DenisChenu Changeset attached => LimeSurvey master db5b2dd1
2013-06-30 16:56 DenisChenu Note Added: 25688
2013-06-30 16:56 DenisChenu Resolution open => fixed
2013-06-30 17:00 DenisChenu Changeset attached => LimeSurvey 2.05 f9ff450a
2013-06-30 17:00 DenisChenu Note Added: 25689
2013-06-30 17:04 DenisChenu Status assigned => resolved
2013-06-30 17:04 DenisChenu Fixed in Version => 2.00+
2013-07-08 13:50 c_schmitz Note Added: 25716
2013-07-08 13:50 c_schmitz Status resolved => closed