View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
07950Bug reportsImport/Exportpublic2013-09-24 14:20
Reportermfaber Assigned Toadamzammit  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.05 RC 
Fixed in Version2.05 RC 
Summary07950: queXML export produces unusable PDF, "/**/" on every line, 2.00+ seems ok
Description

When exporting a Survey using quexml-export, the resulting PDF contains lots of
"/**/".
Zip-file creation also takes longer than usual (several seconds).

This only seems to be a problem in beta 2.05.
2.00+ works quick and as expected.

Steps To Reproduce

choose any survey
export quexml
open PDF in created zip-file

TagsNo tags attached.
Attached Files
quexmlpdf.php (69,744 bytes)
Bug heat10
Complete LimeSurvey version number (& build)130624
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL 5.0.10
Server OS (if known)Win7
Webserver software & version (if known)Apache/2.4.3 (Win32)
PHP VersionPhP 5.4.7

Users monitoring this issue

adamzammit, mfaber

Activities

mfaber

mfaber

2013-07-19 14:18

reporter   ~25815

OK, I think I found the problem....

in quexmlpdf.php the following line pulls the style information from the style-file.
$this->style = $controller->render('/admin/export/quexmlpdf_view','',true);

Unfortunately, in LS 2.05 there are some css/JS files registered using e.g. registerCssFile() in CClientscript.php.

Now, together with the style information from the style-file comes alist of these registered files and some other stuff created by the renderer. The whole style variable looks like this on my system:

<link rel="stylesheet" type="text/css" href="http://localhost/github/limesurvey/tmp/assets/b52d3e57/css/bootstrap.min.css&quot; />
<link rel="stylesheet" type="text/css" href="http://localhost/github/limesurvey/tmp/assets/b52d3e57/css/bootstrap-yii.css&quot; />
<script type="text/javascript" src="/github/limesurvey/third_party/jquery/jquery-1.10.2.min.js"></script>
<script type="text/javascript" src="http://localhost/github/limesurvey/tmp/assets/b52d3e57/js/bootstrap.bootbox.min.js&quot;>&lt;/script>
<script type="text/javascript" src="http://localhost/github/limesurvey/tmp/assets/b52d3e57/js/bootstrap.min.js&quot;>&lt;/script>
<script type="text/javascript" src="/github/limesurvey/scripts/admin/admin_core.js"></script>
<style>
td.questionTitle {font-weight:bold; font-size:12pt;}
td.questionTitleSkipTo {font-weight:bold; font-size:16pt;}
td.questionText {font-weight:bold; font-size:12pt;}
td.questionSpecifier {font-weight:normal; font-size:12pt;}
td.vasLabel {font-weight:bold; font-size:10pt; text-align:center;}
td.questionHelp {font-weight:normal; text-align:right; font-style:italic; font-size:8pt;}
td.questionHelpAfter {text-align:center; font-weight:bold; font-size:10pt;}
td.questionHelpBefore {text-align:center; font-weight:bold; font-size:12pt;}
td.responseAboveText {font-weight:normal; font-style:normal; text-align:left; font-size:12pt;}
span.sectionTitle {font-size:18pt; font-weight:bold;}
span.sectionDescription {font-size:14pt; font-weight:bold;}
div.sectionInfo {font-style:normal; font-size:10pt; text-align:left; font-weight:normal;}
td.questionnaireInfo {font-size:16pt; text-align:center; font-weight:bold;}
</style>
<script type="text/javascript">
/<![CDATA[/
jQuery('a[rel="tooltip"]').tooltip();
jQuery('a[rel="popover"]').popover();
/]]>/
</script>

Only the middle part is the style information from the file and the last bit of these lines is where the /**/ is coming from in the quexml-PDF.

I am unsure how to deal with this...Adam, can you please advice? Do we need to pull the styles through the renderer? Apply filtering before passing it to tcpdf..?

adamzammit

adamzammit

2013-07-23 06:54

developer   ~25846

Hi mfaber,

I see this problem too. I'll post a solution shortly.

Regards,
Adam Zammit

adamzammit

adamzammit

2013-07-23 07:15

developer   ~25847

Hi again mfaber,

Attached is a new quexmlpdf.php file that doesn't use the renderer. I think this is more appropriate as the class style is specific to queXMLPDF and doesn't need to be separated. Let me know if this works and I'll update 2.05.

Regards,
Adam Zammit

mfaber

mfaber

2013-07-23 08:11

reporter   ~25848

Works! Yeeha :)

Thanks,
MF

adamzammit

adamzammit

2013-07-23 08:17

developer   ~25849

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=12769

mfaber

mfaber

2013-07-23 08:30

reporter   ~25850

Suggest to also remove the now obsolete quexmlpdf_view.php from the repository...

adamzammit

adamzammit

2013-07-23 08:42

developer   ~25851

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=12770

c_schmitz

c_schmitz

2013-09-24 14:20

administrator   ~26340

2.05RC1 released

Related Changesets

LimeSurvey: 2.05 ad758f0e

2013-07-23 06:17:36

adamzammit

Details Diff
Fixed issue 07950: queXML export produces unusable PDF, "/**/" on every line, 2.00+ seems ok Affected Issues
07950
mod - application/libraries/admin/quexmlpdf.php Diff File

LimeSurvey: 2.05 bc1c6135

2013-07-23 06:42:34

adamzammit

Details Diff
Fixed issue 07950: queXML export produces unusable PDF, "/**/" on every line, 2.00+ seems ok

Dev Remove now obsolete view
Affected Issues
07950
rm - application/views/admin/export/quexmlpdf_view.php Diff File

Issue History

Date Modified Username Field Change
2013-06-24 21:55 mfaber New Issue
2013-07-18 13:12 mfaber File Added: quexmlpdf_784912_en.pdf
2013-07-19 14:18 mfaber Note Added: 25815
2013-07-19 14:18 mfaber Assigned To => adamzammit
2013-07-19 14:18 mfaber Status new => assigned
2013-07-19 14:18 mfaber Issue Monitored: mfaber
2013-07-23 06:54 adamzammit Note Added: 25846
2013-07-23 06:54 adamzammit Status assigned => acknowledged
2013-07-23 07:13 adamzammit File Added: quexmlpdf.php
2013-07-23 07:15 adamzammit Note Added: 25847
2013-07-23 07:17 adamzammit Issue Monitored: adamzammit
2013-07-23 08:11 mfaber Note Added: 25848
2013-07-23 08:17 adamzammit Changeset attached => LimeSurvey 2.05 ad758f0e
2013-07-23 08:17 adamzammit Note Added: 25849
2013-07-23 08:17 adamzammit Resolution open => fixed
2013-07-23 08:30 mfaber Note Added: 25850
2013-07-23 08:42 adamzammit Changeset attached => LimeSurvey 2.05 bc1c6135
2013-07-23 08:42 adamzammit Note Added: 25851
2013-07-23 13:43 mfaber Status acknowledged => resolved
2013-09-23 13:37 c_schmitz Fixed in Version => 2.05 RC
2013-09-24 14:20 c_schmitz Note Added: 26340
2013-09-24 14:20 c_schmitz Status resolved => closed
2021-08-02 21:00 guest Bug heat 6 => 10