View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
07764Bug reportsTranslationpublic2013-04-13 13:492013-05-26 21:06
Reporterpmonstad Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary07764: missing translation
Description

In attribute Control an error message is not translated. When I try to add a new attributt without giving a name for it, a message is shown in a pop up: Field is required This string is not translated.

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)130406
I will donate to the project if issue is resolvedNo
Browserall
Database type & versionall
Server OS (if known)all
Webserver software & version (if known)all
PHP Versionall

Relationships

Relationship GraphDependency Graph
has duplicate 07766 closedmdekker missing translation 

Users monitoring this issue

There are no users monitoring this issue.

Activities

mdekker

mdekker

2013-04-16 11:12

reporter   ~24967

Apparently we do not use the built in localization for jqgrid. We have two options, use built in localizaton or add strings for this kind of messages.

Default localization (at least on 2.05) is in third_party\jqgrid\js\i18n\grid.locale-xx.js
pmonstad

pmonstad

2013-04-16 17:52

updater   ~24972

I'd prefer you don't rely on the translations in jqgrid\js\i18n\grid.locale-xx.js as there are probably missing translations compared to the existing LS language files. Maintain translations in third party code is not a good choice in my opinion.
c_schmitz

c_schmitz

2013-04-22 15:09

administrator   ~25046

Last edited: 2013-04-22 15:14

In general we translate 'on-the-fly' by embedding the strings. However this string seems to be one of the case where jqGrid does ignore the configuration. (see my commit) and it does not work.
c_schmitz

c_schmitz

2013-04-22 15:11

administrator   ~25047

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12327
mdekker

mdekker

2013-04-23 10:58

reporter   ~25063

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12330
c_schmitz

c_schmitz

2013-05-10 14:56

administrator   ~25207

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12387
c_schmitz

c_schmitz

2013-05-17 13:21

administrator   ~25286

mdekker: According to the jqGrid author your solution is the right one. Thank you!
c_schmitz

c_schmitz

2013-05-17 13:21

administrator   ~25287

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12434
c_schmitz

c_schmitz

2013-05-26 21:06

administrator   ~25380

New version 2.00+ Build 130526 released

Related Changesets

LimeSurvey: master 8f664343

2013-04-22 15:10

c_schmitz


Details Diff		 Fixed issue 07764: Missing translation
Dev Not really working due to bug? in jqGrid		 Affected Issues
07764
mod - application/views/admin/participants/attributeControl_view.php Diff File
mod - scripts/admin/attributeControl.js Diff File

LimeSurvey: 2.05 07afcf9d

2013-04-22 15:10

c_schmitz


Details Diff		 Fixed issue 07764: Missing translation
Dev Not really working due to bug? in jqGrid		 Affected Issues
07764
mod - application/views/admin/participants/attributeControl_view.php Diff File
mod - scripts/admin/attributeControl.js Diff File

LimeSurvey: master 232f2ffb

2013-04-23 10:57

mdekker


Details Diff		 Fixed issue 07764: Missing translation Affected Issues
07764
mod - scripts/admin/attributeControl.js Diff File

LimeSurvey: 2.05 95566d2d

2013-05-17 13:20

c_schmitz


Details Diff		 Fixed issue 07764: Missing translation Affected Issues
07764
mod - scripts/admin/attributeControl.js Diff File

Issue History

Date Modified Username Field Change
2013-04-13 13:49 pmonstad New Issue
2013-04-16 11:12 mdekker Note Added: 24967
2013-04-16 11:12 mdekker Assigned To => c_schmitz
2013-04-16 11:12 mdekker Status new => feedback
2013-04-16 11:13 mdekker Relationship added has duplicate 07766
2013-04-16 17:52 pmonstad Note Added: 24972
2013-04-16 17:52 pmonstad Status feedback => assigned
2013-04-22 15:09 c_schmitz Note Added: 25046
2013-04-22 15:11 c_schmitz Changeset attached => LimeSurvey master 8f664343
2013-04-22 15:11 c_schmitz Note Added: 25047
2013-04-22 15:11 c_schmitz Resolution open => fixed
2013-04-22 15:14 c_schmitz Note Edited: 25046
2013-04-23 10:58 mdekker Changeset attached => LimeSurvey master 232f2ffb
2013-04-23 10:58 mdekker Note Added: 25063
2013-04-23 10:58 mdekker Assigned To c_schmitz => mdekker
2013-05-10 14:56 c_schmitz Changeset attached => LimeSurvey 2.05 07afcf9d
2013-05-10 14:56 c_schmitz Note Added: 25207
2013-05-10 14:56 c_schmitz Assigned To mdekker => c_schmitz
2013-05-17 13:21 c_schmitz Note Added: 25286
2013-05-17 13:21 c_schmitz Status assigned => resolved
2013-05-17 13:21 c_schmitz Fixed in Version => 2.00+
2013-05-17 13:21 c_schmitz Changeset attached => LimeSurvey 2.05 95566d2d
2013-05-17 13:21 c_schmitz Note Added: 25287
2013-05-26 21:06 c_schmitz Note Added: 25380
2013-05-26 21:06 c_schmitz Status resolved => closed