View Issue Details

This bug affects 1 person(s).
 252
IDProjectCategoryView StatusLast Update
06810Bug reportsSecuritypublic2012-11-02 11:18
Reporterjtate Assigned Toc_schmitz  
PrioritynormalSeverityblock 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary06810: When you add a group to a survey's permissions list and set the permissions you get a SQL error on the permissions page.
Description

After I added a group to my survey, I started getting the following traceback:

CDbCommand failed to execute the SQL statement: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: "2 OR ugid=1"
LINE 1: SELECT FROM "user_groups" "t" WHERE ugid = '2 OR ugid=1'
^. The SQL statement executed was: SELECT
FROM "user_groups" "t" WHERE ugid = :ugid

This stems from code in admin/surveypermission.php
84 if(isset($group_ids) && $group_ids[0] != NULL)
85 {
86 $group_ids_query = implode(" OR ugid=", $group_ids);
87 unset($group_ids);
88
89 $result4 = User_groups::model()->findAll('ugid = :ugid',array(':ugid' => $group_ids_query));
90
91 foreach ($result4 as $resul4row)
92 {
93 $group_names[] = $resul4row->name;
94 }

Steps To Reproduce

Create a survey
Create a group
Add a group to the survey and check all the boxes.

Load the survey permissions page again.

Additional Information

This patch fixed it for me:

diff --git a/application/controllers/admin/surveypermission.php b/application/controllers/admin/surveypermission.php
index f7184f0..5e3163a 100644
--- a/application/controllers/admin/surveypermission.php
+++ b/application/controllers/admin/surveypermission.php
@@ -83,10 +83,10 @@ class surveypermission extends Survey_Common_Action {

                 if(isset($group_ids) && $group_ids[0] != NULL)
                 {
  • $group_ids_query = implode(" OR ugid=", $group_ids);

  • $group_ids_query = implode(",", $group_ids);
    unset($group_ids);

  • $result4 = User_groups::model()->findAll('ugid = :ugid',array(':ugid' => $group_ids_query));

  • $result4 = User_groups::model()->findAll("ugid IN ($group_ids_query)");

                     foreach ($result4 as $resul4row)
                     {
TagsNo tags attached.
Bug heat252
Complete LimeSurvey version number (& build)121024
I will donate to the project if issue is resolvedNo
Browser
Database type & versionPostgresql
Server OS (if known)Linux
Webserver software & version (if known)Apache 2.2
PHP Version5.3.17

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2012-11-01 09:26

administrator   ~21851

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10086

c_schmitz

c_schmitz

2012-11-01 09:26

administrator   ~21852

Thank you very much!

c_schmitz

c_schmitz

2012-11-01 13:13

administrator   ~21864

2.00+ build 201101 released. Please update.

c_schmitz

c_schmitz

2012-11-02 11:18

administrator   ~21899

Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10106

Related Changesets

LimeSurvey: master 48b888be

2012-11-01 08:26:21

c_schmitz

Details Diff
Fixed issue 06810: When you add a group to a survey's permissions list and set the permissions you get a SQL error on the permissions page - patch by jtate Affected Issues
06810
mod - application/controllers/admin/surveypermission.php Diff File

LimeSurvey: 2.1 fcd11dbe

2012-11-01 08:26:21

c_schmitz

Details Diff
Fixed issue 06810: When you add a group to a survey's permissions list and set the permissions you get a SQL error on the permissions page - patch by jtate Affected Issues
06810
mod - application/controllers/admin/surveypermission.php Diff File

Issue History

Date Modified Username Field Change
2012-10-30 22:11 jtate New Issue
2012-11-01 00:12 c_schmitz Assigned To => c_schmitz
2012-11-01 00:12 c_schmitz Status new => assigned
2012-11-01 09:26 c_schmitz Changeset attached => LimeSurvey master 48b888be
2012-11-01 09:26 c_schmitz Note Added: 21851
2012-11-01 09:26 c_schmitz Resolution open => fixed
2012-11-01 09:26 c_schmitz Note Added: 21852
2012-11-01 09:26 c_schmitz Status assigned => resolved
2012-11-01 09:26 c_schmitz Fixed in Version => 2.00+
2012-11-01 13:13 c_schmitz Note Added: 21864
2012-11-01 13:13 c_schmitz Status resolved => closed
2012-11-02 11:18 c_schmitz Changeset attached => LimeSurvey 2.1 fcd11dbe
2012-11-02 11:18 c_schmitz Note Added: 21899