Seems to the underlying problem stems from an incorrect variable used. Yii::app()->getConfig('generalscripts') returns a URL relative to the root domain.
When including php files of course a path relative to the file system should be used. I've (partly) solved this by introdoucing a new variable in config-defaults.php: $config['generalscriptspath'] = $config['rootdir'] .'/scripts/';

Which uses the root dir instead of the base url. Furthermore the method of inclusion only works for the PHP files; all assets like javascript files and images do not work.

I think this controller should be rewritten to be more structured:

• Separate function for initiating kcfinder configuration.
• Passthrough function that checks if a file is a php file, if so execute it.
• If the file exists and is not a php file return the file.

I can partly reproduce the problem. When trying to upload an image and clicking the "search server" button, I see the Limesurvey root page ("the following surveys are available:..."), URL is http://localhost/git/dev/Limesurvey/admin/kcfinder/index/load/browse?type=images&CKEditor=description_en&CKEditorFuncNum=2&langCode=de

If I select a file from my local PC and click upload, the system also show part of the Limesurvey root page on top of the window (hard to recognize).

So i've been looking at the code and to me it seems a very complex solution to a relatively simple problem.

-- First of all there is the general issue of including 3rd party libraries (like kcfinder) without changing them.
-- Second there is the need to set some variables before referring the user to the libary files.

In my opinion we should not separate any files inside the library; ie. the separation between js / css assets and php scripts should not be applied since the code base is not part of limesurvey.

A solution that in my opinion is the nicest is to create a /vendors directory. (I'm aware of some of the other existing directories /application/third_party)
In this vendors directory we place a kcfinder directory which contains the library.

The complex kcfinder action (/application/controllers/admin/kcfinder.php can now be replaced with the following trivial code:
function index()
{
$this->initializeSession();
$match = '/admin/kcfinder/index/load/';
$replace = '/vendors/kcfinder/';
$url = str_replace($match, $replace, $_SERVER['REQUEST_URI']);
$this->getController()->redirect($url);
}

Note that initializeSession contains the existing code for setting variables in the session.

By using a redirect we are free of all the annoying asset-rewriting stuff. Furthermore we should, in my opinion, not use include on php files that are not meant to be included. (kcfinder uses session_start for example which results in errors since a session is already started by Yii)

Another advantage of such a strict separation is that it becomes easier to upgrade kcfinder.

--> I can create a fix in git and generate a pull request.

--> Someone should create a post about the directory layout and the intentions behind it... It is hard for developers new to limesurvey development to contribute without constantly knowing these design decisions.

This is fixed in my fork, along with some other changes:

• New vendors directory for 3rd party libraries.
• Removed kcfinder controller and added the necessary code to the htmleditor helper instead.

-- Regression:
CKEditor now always shows 3 toolbars, in both minimized and maximized mode. The old behavior required a lot of "hacks" which does not allow us to easily update the library. Since the wanted functionality of switching from 1 to 3 bars on maximize is on their roadmap this can be easily added when they release a new verison of the library.

"Someone should create a post about the directory layout and the intentions behind it... It is hard for developers new to limesurvey development to contribute without constantly knowing these design decisions."

Sam: I'll second that !

Our manual is a wiki, everyone can edit and extend it. Please create a new page at http://docs.limesurvey.org/LimeSurvey+2.x+development+documentation and sum up your findings there.

Thanks!

Mazi, can you plz give me permissions to edit stuff? It seems i dont belong to everyone =(

Hmm... usually you only need to create an account on limesurvey.org and when then being logged in there and clicking on "documentation", you should be logged in at the wiki automatically.
If this doesn't work, please quote the error message and provide your username and we'll have a look.
Thanks!

errorsError
You do not have permission to edit this page.

I am logged in, username: sammousa

c_schmitz, please assign wiki user "sammousa" rights to add articles at the development section of the wiki.

sammousa, please try again now, we have changed your rights.

works! can be closed since this code is in RC8.

Version 2.00 RC 9 released.