View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
06413Bug reportsAccessibilitypublic2012-08-03 13:44
Reportersammousa Assigned Touser16774 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00RC7 
Fixed in Version2.00RC8 
Summary06413: Incorrect css references.
Description

After login the following non-existent css files are referenced:

/scripts/jquery/css/jquery.multiselect.css
/scripts/jquery/css/jquery.multiselect.filter.css

These should be changed to

/styles-public/jquery.multiselect.css
/styles-public/jquery.multiselect.filter.css

Steps To Reproduce

Login to the admin panel.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)000000
I will donate to the project if issue is resolvedNo
BrowserFF
Database type & versionmysql 5.5.24-0ubuntu0.12.04.1
Server OS (if known)Ubuntu 12.04
Webserver software & version (if known)nginx 1.1.19-1
PHP Version5.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

sammousa

sammousa

2012-08-01 10:13

reporter   ~20098

It seems these CSS files are included from several controllers. I'm not that familiar with Yii, however since its mvc shouldn't css includes be defined in a view / layout?

-- The easy fix is obviously just to fix the paths; if you want me to do this assign the bug to me. A better / nicer fix would be to remove this code from the controller and move it to the view / layout instead...

application/controllers/admin/participantsaction.php:
$this->getController()->_css_admin_includes(Yii::app()->getConfig('generalscripts') . 'jquery/css/jquery.multiselect.css');

application/controllers/admin/surveyadmin.php:
$css_admin_includes[] = Yii::app()->getConfig('generalscripts') . "jquery/css/jquery.multiselect.css";

application/controllers/admin/conditionsaction.php:
$this->getController()->_css_admin_includes(Yii::app()->getConfig("generalscripts").'jquery/css/jquery.multiselect.css');

application/controllers/admin/tokens.php:
//$this->getController()->_css_admin_includes(Yii::app()->getConfig('generalscripts') . "jquery/css/jquery.multiselect.css");

Mazi

Mazi

2012-08-01 14:52

updater   ~20101

Aaron, what do you think would be the best approach?

user16774

2012-08-01 19:11

  ~20107

Sorry - I got lost in my project and forgot about the tracker. I don't know the "rules" of mvc too well, but I know that there are literally hundreds of js and css includes that would need to be altered, and it seems that we're not at a good point in the release cycle to do that so I propose we just fix the paths for now.

user16774

2012-08-01 21:51

  ~20108

https://github.com/LimeSurvey/LimeSurvey/pull/19 seems to work for me. Merge it if you can confirm.

Mazi

Mazi

2012-08-02 12:18

updater   ~20114

Fixed by pull request (c_schmitz)

c_schmitz

c_schmitz

2012-08-03 13:44

administrator   ~20134

2.00RC8 released

Issue History

Date Modified Username Field Change
2012-08-01 10:07 sammousa New Issue
2012-08-01 10:13 sammousa Note Added: 20098
2012-08-01 14:52 Mazi Assigned To => user16774
2012-08-01 14:52 Mazi Status new => assigned
2012-08-01 14:52 Mazi Note Added: 20101
2012-08-01 19:11 user16774 Note Added: 20107
2012-08-01 21:51 user16774 Note Added: 20108
2012-08-02 12:18 Mazi Note Added: 20114
2012-08-02 12:18 Mazi Status assigned => resolved
2012-08-02 12:18 Mazi Fixed in Version => 2.00+
2012-08-02 12:18 Mazi Resolution open => fixed
2012-08-03 13:44 c_schmitz Fixed in Version 2.00+ => 2.00RC8
2012-08-03 13:44 c_schmitz Note Added: 20134
2012-08-03 13:44 c_schmitz Status resolved => closed