View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
06401Bug reportsSurvey editingpublic2012-08-03 13:44
Reporterabita1 Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00RC7 
Fixed in Version2.00RC8 
Summary06401: Question Type List and Sample Popups fall off the screen
Description

When selecting question types, the full popup selection list will fall above or below the browser window.

When hovering over question types, on that list, the sample popup will also fall above or below the browser window

Additional Information

Occurs in both 192+ and 200rc7

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)120725
I will donate to the project if issue is resolvedNo
BrowserFireFox 14
Database type & versionMySQL
Server OS (if known)Linux / Apache
Webserver software & version (if known)1.3.3
PHP Version5.2.17

Users monitoring this issue

There are no users monitoring this issue.

Activities

abita1

abita1

2012-07-28 18:43

reporter   ~20048

Scrolling cures it, but I suppose it would be nice if the second popup was smart enough to land above, when that would cure it...

sammousa

sammousa

2012-07-29 01:54

reporter   ~20053

Last edited: 2012-07-29 01:55

Fixed this in my fork. See pull request or alternatively edit admin_core.js
insert at line 248:


, adjust: {
screen: true
}

ps. Note that i removed my old pull request and created a new one; github only allows one and the old one (for the test script for static calls) was not yet pulled.

abita1

abita1

2012-07-30 02:27

reporter   ~20062

Last edited: 2012-07-30 02:40

Thanks, sammousa for your comment.

1)
This may sound basal....but is that between 248 and 249...?

At the moment, I have:
if ($("#question_type:not(.none)").length > 0 && $("#question_type").attr('type')!='hidden'){
$("#question_type").msDropDown({onInit:qTypeDropdownInit});

[248]--> $("#question_type").change(function(event){
var selected_value = qDescToCode[''+$("#question_type_child .selected").text()];
OtherSelection(selected_value);
});
}

1a)
In my admin_core.js
The function: function qTypeDropdownInit() Begins at line 258
And I am tempted to think your edit goes inside the
$(element).qtip({...
Position: adjust: { screen: true },
at line 273-74

1b) why/why not....?
Position: adjust: { screen: true, scroll:true },

2)
Another learning-curve question: is your fork the one that gets amended into the distribution for 1.92+ at next build? Does it end up inside 2.0? Or does someone else have to do something to do that ?

3)
Another learning curve q:
Does your change amend the subPop only? What about the original Pop?

sammousa

sammousa

2012-07-30 07:43

reporter   ~20069

Last edited: 2012-07-30 11:55

  1. Your code looks different from mine; i'm working on the latest version from 2.0 on github...

1a. You are right, that's where I made my adjustments; the way I typed it should be the same but respect the indenting manner used in the rest of the file...

1b. That sample seems to be missing { and } around the adjust value.

  1. I am not part of the limesurvey team so in which distribution it ends up I don't know! I know however that I only made my changes to the 2.0 version since that is what you specified in your bug report. (edit: I just now saw the additional information where you specify it also occurs in 1.92)

  2. It seems yesterday i misread your bug and did not notice it concerns the question type list itself too. I cannot recreate that problem since at the bottom there is not enough room so the dropdown list is always shown towards the top.. (If i make my window smaller there is not enough room to display it anywhere so there is no "fix" for that).
    Tl;dr subPop only (if you mean the screenshot part by that).

abita1

abita1

2012-07-30 15:34

reporter   ~20075

Great...!

thanks for your input. Your change worked for me.

for clarity, for anyone reading this bug report, later....

The change I made added in the adjust clause was ONE of the elements of the "position"

As it happens, this was the only Position element, throughout the whole of the script, that lacked the "adjust". Searching for the other "Position" clauses will reveal the syntax

c_schmitz

c_schmitz

2012-07-30 18:08

administrator   ~20077

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9184

c_schmitz

c_schmitz

2012-08-03 13:44

administrator   ~20136

2.00RC8 released

Related Changesets

LimeSurvey: Yii d1b15e15

2012-07-30 09:07:38

c_schmitz

Details Diff
Merge pull request #18 from SamMousa/Yii

Fixed issue 06401: Question type list and sample popups fall off the screen
Dev Added staticCalls test file. Tests for static calls (using pattern matching).
Affected Issues
06401
add - application/tests/staticCalls.php Diff File
mod - scripts/admin/admin_core.js Diff File

Issue History

Date Modified Username Field Change
2012-07-28 18:39 abita1 New Issue
2012-07-28 18:43 abita1 Note Added: 20048
2012-07-29 01:54 sammousa Note Added: 20053
2012-07-29 01:55 sammousa Note Edited: 20053
2012-07-30 02:27 abita1 Note Added: 20062
2012-07-30 02:33 abita1 Note Edited: 20062
2012-07-30 02:40 abita1 Note Edited: 20062
2012-07-30 07:43 sammousa Note Added: 20069
2012-07-30 11:55 sammousa Note Edited: 20069
2012-07-30 15:34 abita1 Note Added: 20075
2012-07-30 18:08 c_schmitz Status new => resolved
2012-07-30 18:08 c_schmitz Fixed in Version => 2.00+
2012-07-30 18:08 c_schmitz Resolution open => fixed
2012-07-30 18:08 c_schmitz Assigned To => c_schmitz
2012-07-30 18:08 c_schmitz Changeset attached => LimeSurvey Yii d1b15e15
2012-07-30 18:08 c_schmitz Note Added: 20077
2012-08-03 13:44 c_schmitz Fixed in Version 2.00+ => 2.00RC8
2012-08-03 13:44 c_schmitz Note Added: 20136
2012-08-03 13:44 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing