View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
06395 | Bug reports | Survey editing | public | 2012-07-27 01:24 | 2012-08-03 13:44 |
Reporter | abita1 | Assigned To | c_schmitz | ||
Priority | normal | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.00RC7 | ||||
Fixed in Version | 2.00RC8 | ||||
Summary | 06395: Codes entry limited to 5 Characters, but QuickAdd will permit longer | ||||
Description | (This issue appears in both 1.92+ and in 2.00RC7) [builds 120725 and 120721] A) I don't notice in the documentation that there is a stated limit for the Code character length when adding labels. Regardless of whether it is, or is not, perhaps it should be mentioned all over. B1) If there is a limit (of 5 or whatever): B2) If there is -no- limit: | ||||
Additional Information | I seem to sense that this issue, where QuickAdd allows longer codes, and the underlying text box is limited, appears in many situations where QuickAdd is used, ie, question, labels, and sub-questions. | ||||
Tags | No tags attached. | ||||
Bug heat | 4 | ||||
Complete LimeSurvey version number (& build) | 120725 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | FireFox 14 | ||||
Database type & version | MySQL | ||||
Server OS (if known) | Linux / Apache | ||||
Webserver software & version (if known) | 1.3.3 | ||||
PHP Version | 5.2.17 without FastCGI | ||||
Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9154 |
|
Yep, quick-add should not allow longer codes. |
|
Thanks...., CS ! But.... what is the legal limit ? It wasn't stated in the manual, or in the LS versions while operating. Also... 5 characters doesn't seem like the right amount for codes -- too short, certainly, in the mode where the space is, essentially, free in the DB labels codes might not need long label codes, but questions and sub-questions, particularly in the new QCode system could benefit by sensible codes, like VB, or C++ or other programming code systems. 10 for subQs and Labels, but unlimited for question.codes? why even have a limit of 5. why not 10...or 15 or 40? |
|
Also...if your repair to V 2.0 is undertaken...folks who have used longer codes because, well...they were allowed...may discover that their naming regimen flunks on upgrade, when 2 becomes live. This might be a major issue ! |
|
I just noticed something -- You all...that is, Tom and C, are engaging in a back room discussion on the bug, over on Git, that probably would benefit by placement in this bug area, as there will be a far wider dissemination of issues discussed. Tom's issues on regression probably need a wider discussion -- generally, that would be true. It works well in the Fox bugzilla land, and sustains community involvement. Security issues, those should be back door, but the normal realm of issues....up front is best. I would want to suggest that non-security issues should be placed here, in the notes, from here forward...? yes? Just my thought...thanks to you both for your involvement. |
|
Thanks for your input but in this case it is a technical limitation and so the discussion is target towards developers only. |
|
Well, Carsten -- I realize that the first comment, there in Git, on this bug, was Tom's and not yours -- and truly appreciate both of your input and development. My suggestion is that Tom's original comment should have landed here, as well as the subsequent exchange. As abundantly clear as both of your skill sets are on the technical side, for the coding and more, it turned out, Carsten, that this minor, funky error had a wave of related non-technical issues! The problems raised were not technical limitations, rather, they impacted the UI, the backbone of a survey's structure, and more. There is the serious issue of regression, as well as reflections on documentation and the feature set. The raising of all notations, in a open source project, in an open forum, increases the likelihood of discovering conflicts and proposing solutions -- solutions that you would be best poised to select and put into effect -- and accomplishes this by ensuring that the largest number of developers and users contribute. My vote, at least, and a most commonly accepted practice, is that a single repository for comments is best. Technical, or otherwise. In the realm of complex coding, this is standard practice -- even in commercial, closed source development. Where there is a diverse user base, both by distance and use patterns, and a similarly diverse developer crowd with a range of skill sets, the need is increased. The best part about a single repository is that it makes the developers' task simpler and coordinates the wonderful efforts of open source developers with the user community, both sophisticated and casual. In this particular bug, -everything- that you -both- wrote, if landed here, would have been relevant to anyone reading about the bug ! |
|
Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9164 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9165 |
|
Carsten: Does this modify the lengths of codes for for Labels and Questions ? Does this address the way QuickAdd works in those two contexts ? |
|
2.00RC8 released |
|
LimeSurvey: Yii 5421bbd6 2012-07-26 23:41:55 Details Diff |
Fixed issue 06395: QuickAdd permits longer codes than 5 characters |
Affected Issues 06395 |
|
mod - scripts/admin/answers.js | Diff File | ||
mod - scripts/admin/subquestions.js | Diff File | ||
mod - scripts/admin/updateset.js | Diff File | ||
LimeSurvey: Yii c29869b9 2012-07-28 06:36:06 Details Diff |
Fixed issue 06395: QuickAdd permits longer codes than 5 characters |
Affected Issues 06395 |
|
mod - application/helpers/replacements_helper.php | Diff File | ||
mod - application/views/admin/survey/Question/subQuestion_view.php | Diff File | ||
mod - scripts/admin/subquestions.js | Diff File | ||
LimeSurvey: master 1a0f971b 2012-07-28 06:36:19 Details Diff |
Fixed issue 06395: QuickAdd permits longer codes than 5 characters |
Affected Issues 06395 |
|
mod - admin/editsubquestions.php | Diff File | ||
mod - admin/scripts/subquestions.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-07-27 01:24 | abita1 | New Issue | |
2012-07-27 08:38 | c_schmitz | Assigned To | => c_schmitz |
2012-07-27 08:38 | c_schmitz | Status | new => assigned |
2012-07-27 08:41 | c_schmitz | Changeset attached | => LimeSurvey Yii 5421bbd6 |
2012-07-27 08:41 | c_schmitz | Note Added: 20010 | |
2012-07-27 08:41 | c_schmitz | Resolution | open => fixed |
2012-07-27 08:42 | c_schmitz | Note Added: 20011 | |
2012-07-27 08:42 | c_schmitz | Status | assigned => resolved |
2012-07-27 08:42 | c_schmitz | Fixed in Version | => 2.00+ |
2012-07-28 01:50 | abita1 | Note Added: 20032 | |
2012-07-28 01:51 | abita1 | Note Added: 20033 | |
2012-07-28 01:59 | abita1 | Note Added: 20034 | |
2012-07-28 11:39 | c_schmitz | Note Added: 20035 | |
2012-07-28 15:33 | abita1 | Note Added: 20040 | |
2012-07-28 15:36 | c_schmitz | Changeset attached | => LimeSurvey Yii c29869b9 |
2012-07-28 15:36 | c_schmitz | Note Added: 20041 | |
2012-07-28 15:36 | c_schmitz | Changeset attached | => LimeSurvey master 1a0f971b |
2012-07-28 15:36 | c_schmitz | Note Added: 20042 | |
2012-07-28 18:54 | abita1 | Note Added: 20049 | |
2012-08-03 13:44 | c_schmitz | Fixed in Version | 2.00+ => 2.00RC8 |
2012-08-03 13:44 | c_schmitz | Note Added: 20138 | |
2012-08-03 13:44 | c_schmitz | Status | resolved => closed |
2019-11-01 17:25 | c_schmitz | Category | Survey design => Survey editing |