View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
06309 | Bug reports | Survey editing | public | 2012-07-09 20:24 | 2012-07-18 16:33 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 1.92+ | ||||
Fixed in Version | 1.92+ | ||||
Summary | 06309: Bad javascript alert for Multiple choice with "Other option" | ||||
Description | In multi option question, mandatory with other, if the user check the other checkbox and click next whole question are shown in javascript alert. But it can be very bad with:
| ||||
Steps To Reproduce | Import joined survey. | ||||
Additional Information | Think it's best to have: | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 120704 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | FF12 | ||||
Database type & version | Mysql 5 | ||||
Server OS (if known) | debian/linux | ||||
Webserver software & version (if known) | apache | ||||
PHP Version | PHP Version 5.3 | ||||
https://github.com/jositopr/LimeSurvey/commit/2233ee2273d7c256e7551e5ddd6c214914a9ec96 |
|
Thanks jositopr, But maybe it's a good solution to have his control in Expression Manager :) |
|
Hello Tom, I look to add this in Expression Manager (other_comment_mandatory part). I try with: (after set if($type=='M'){$qattr['other_comment_mandatory']=1;}) Do you have an idea ? Denis |
|
Quick and dirty solution: (use $othertext if attribute other_replace_text is set) |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8954 |
|
Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8955 |
|
TODO : move it to EM |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8969 |
|
Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8970 |
|
1.92+ version released. |
|
LimeSurvey: master 9e506613 2012-07-11 05:07 Details Diff |
Fixed issue 06309 : Bad javascript for Multiple choice with "Other option" Dev : if question is mandatory : checked in $mandatoryTip Dev : if not, input.text is selected when click in cbox Dev : TODO : move it in Expression manager |
Affected Issues 06309 |
|
mod - qanda.php | Diff File | ||
LimeSurvey: Yii 590b055b 2012-07-11 05:16 Details Diff |
Fixed issue 06309 : Bad javascript for Multiple choice with "Other option" Dev : if question is mandatory : checked in $mandatoryTip Dev : if not, input.text is selected when click in cbox Dev : TODO : move it in Expression manager |
Affected Issues 06309 |
|
mod - application/helpers/qanda_helper.php | Diff File | ||
LimeSurvey: master 74656104 2012-07-11 13:28 Details Diff |
Dev : better fix 06309 : othercbox are not need, then hide in CSS |
Affected Issues 06309 |
|
mod - qanda.php | Diff File | ||
LimeSurvey: Yii c50def60 2012-07-11 13:30 Details Diff |
Dev : better fix 06309 : othercbox are not need, then hide in CSS |
Affected Issues 06309 |
|
mod - application/helpers/qanda_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-07-09 20:24 | DenisChenu | New Issue | |
2012-07-09 20:24 | DenisChenu | File Added: limesurvey_survey_46647.lss | |
2012-07-10 14:16 |
|
Note Added: 19686 | |
2012-07-10 14:24 | DenisChenu | Note Added: 19687 | |
2012-07-10 14:25 | DenisChenu | Assigned To | => TMSWhite |
2012-07-10 14:25 | DenisChenu | Status | new => assigned |
2012-07-10 14:27 | DenisChenu | Note Added: 19688 | |
2012-07-10 17:37 | DenisChenu | Note Added: 19691 | |
2012-07-11 10:56 | DenisChenu | Assigned To | TMSWhite => DenisChenu |
2012-07-11 12:09 | DenisChenu | Changeset attached | => LimeSurvey master 9e506613 |
2012-07-11 12:09 | DenisChenu | Note Added: 19701 | |
2012-07-11 12:09 | DenisChenu | Resolution | open => fixed |
2012-07-11 12:19 | DenisChenu | Changeset attached | => LimeSurvey Yii 590b055b |
2012-07-11 12:19 | DenisChenu | Note Added: 19702 | |
2012-07-11 12:19 | DenisChenu | Note Added: 19703 | |
2012-07-11 12:19 | DenisChenu | Status | assigned => resolved |
2012-07-11 12:19 | DenisChenu | Fixed in Version | => 1.92+ |
2012-07-11 20:31 | DenisChenu | Changeset attached | => LimeSurvey master 74656104 |
2012-07-11 20:31 | DenisChenu | Note Added: 19713 | |
2012-07-11 20:33 | DenisChenu | Changeset attached | => LimeSurvey Yii c50def60 |
2012-07-11 20:33 | DenisChenu | Note Added: 19714 | |
2012-07-18 16:33 | c_schmitz | Note Added: 19777 | |
2012-07-18 16:33 | c_schmitz | Status | resolved => closed |
2019-11-01 17:25 | c_schmitz | Category | Survey design => Survey editing |