06240: conversion of conditions to relevance can fail for multiple choice tests during some upgrades

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

06240	Bug reports	Conditions	public	2012-06-20 16:15	2012-06-22 10:05

Reporter	TMSWhite	Assigned To	TMSWhite
Priority	urgent	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	1.92+
Fixed in Version	1.92+

Summary	06240: conversion of conditions to relevance can fail for multiple choice tests during some upgrades
Description	Some older versions of LS are using inconsistent representation of "no answer" Some use " " to mean no answer - those convert fine (to is_empty(x)) Some use "" to mean no answer - those convert wrong (to !is_empty(x) && x=="")
Tags	No tags attached.

Bug heat	6
Complete LimeSurvey version number (& build)	120620
I will donate to the project if issue is resolved	No
Browser
Database type & version	Mysql 5.3
Server OS (if known)	Windows XP
Webserver software & version (if known)	XAMPP
PHP Version	5.3

User List	marcrichter

marcrichter 2012-06-20 16:25 reporter ~19421	Looks related to my problem... #-/ M

TMSWhite 2012-06-20 16:27 reporter ~19422	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8813

TMSWhite 2012-06-20 16:32 reporter ~19423	Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8815

TMSWhite 2012-06-20 16:46 reporter ~19424	This problem was introduced in commit https://github.com/LimeSurvey/LimeSurvey/commit/6a43810b20733fabfe9eea6238c9c940adb22aab to resolve issue 06171 on June 5, 2012

marcrichter 2012-06-21 10:27 reporter ~19427	Thanks Thomas, this fixes an issue that remained with the survey attached to issue 06188 (the conditions for questions A1++ and A2++). Any chance this fix could make it into a release really soon (ideally before the end of the week)? :-)

LimeSurvey: master 8f81682b 2012-06-20 09:25 TMSWhite Details Diff	Fixed issue 06240: conversion of conditions to relevance can fail for multiple choice tests during some upgrades Dev included a minor DB upgrade from 155.5 to 155.6 so that affected users automatically have ConvertConditionsToRelevance() run for them.	Affected Issues 06240
	mod - admin/install/create-mssql.sql	Diff File
	mod - admin/install/create-mssqlnative.sql	Diff File
	mod - admin/install/create-mysql.sql	Diff File
	mod - admin/install/create-postgres.sql	Diff File
	mod - admin/update/upgrade-mssql.php	Diff File
	mod - admin/update/upgrade-mssqlnative.php	Diff File
	mod - admin/update/upgrade-mysql.php	Diff File
	mod - admin/update/upgrade-postgres.php	Diff File
	mod - classes/expressions/LimeExpressionManager.php	Diff File
LimeSurvey: Yii 6bfea3b6 2012-06-20 09:31 TMSWhite Details Diff	Fixed issue 06240: conversion of conditions to relevance can fail for multiple choice tests during some upgrades.	Affected Issues 06240
	mod - application/helpers/expressions/em_manager_helper.php	Diff File

Date Modified	Username	Field	Change
2012-06-20 16:15	TMSWhite	New Issue
2012-06-20 16:22	TMSWhite	Relationship added	related to 06188
2012-06-20 16:24	marcrichter	Issue Monitored: marcrichter
2012-06-20 16:25	marcrichter	Note Added: 19421
2012-06-20 16:27	TMSWhite	Changeset attached	=> LimeSurvey master 8f81682b
2012-06-20 16:27	TMSWhite	Note Added: 19422
2012-06-20 16:27	TMSWhite	Assigned To	=> TMSWhite
2012-06-20 16:27	TMSWhite	Resolution	open => fixed
2012-06-20 16:27	TMSWhite	Status	new => resolved
2012-06-20 16:27	TMSWhite	Fixed in Version	=> 1.92+
2012-06-20 16:32	TMSWhite	Changeset attached	=> LimeSurvey Yii 6bfea3b6
2012-06-20 16:32	TMSWhite	Note Added: 19423
2012-06-20 16:43	TMSWhite	Relationship added	related to 06171
2012-06-20 16:44	TMSWhite	Relationship deleted	related to 06188
2012-06-20 16:46	TMSWhite	Note Added: 19424
2012-06-20 16:51	TMSWhite	Category	Data Entry (non public) => Conditions
2012-06-21 10:27	marcrichter	Note Added: 19427
2012-06-22 10:05	c_schmitz	Status	resolved => closed
2021-08-02 16:41	guest	Bug heat	4 => 6