Please attach the survey

Please also check the "Show Logic File" (http://docs.limesurvey.org/Show+Logic+File) for your survey. If there are any question names (column 2) shown in red with a pink line around them, then you have errors in your survey that will prevent re-import without first fixing them. The easiest way to do so is to export the survey to Excel (that will work fine). Then, you need to change the problem question names so that you have unique, valid variable names for the import to work. Otherwise, you will get the duplicate key violations you describe.

File uploaded. Sorry, I thought I did it the first time.

You are exactly correct in your suggestion about red with pink borders. This is indeed the case, but I missed that when I looked at the file, since the text at the top says "No syntax errors detected in this survey."

Three suggestions, then:

1. Modify logic file page to say something like "There are invalid question names".
2. When exporting the survey structure, issue a warning about some of the issues.
3. But most importantly, when importing, we should issue a graceful error message that indicates the issue (and possibly some tips for fixing it), rather than a database crash.

The file you uploaded imports fine. Although all of the question names have warnings, none of them is duplicated.

That is the true root cause - if you re-use the same question code for multiple questions, you will get the import error. You should, but are not required, to also ensure that the question names are all valid.

Yes, more graceful error messages would be helpful, rather than calling "safe_die". Moreover, if the file partially loads but doesn't succeed, the whole survey should be deleted so that you don't have dangling partial surveys.

Yes, the file I uploaded is the valid lss file, not the excel survey structure file. To replicate: import the lss, export to survey structure, import survey structure.

I am now working through the Excel file to try and get it to a point where I can import. I have already renamed all the questions to Q1, Q2, etc. Still no luck.

I am in the #limesurvey-team IRC channel at the moment, if you want to continue the discussion there.

Andrie - thanks for taking a stab at these.

Committed partial fix.

Added:

• Error checking for errors in question and answer importing
• Array of error messages (and excel line numbers) get displayed on completion