View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
06080Bug reportsSurvey takingpublic2012-05-17 10:27
ReporterMazi Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.92+ 
Target Version1.92+Fixed in Version1.92+ 
Summary06080: Wrong validation for multiple numeric questions
Description

When setting the following question attribute at a multiple numeric question, EM marks them as valid on page load (which is wrong), while other fields are correctly color coded red:

  • min answers
  • max answers
  • equals sum value

Once you enter a value, the clor coding is corrected.

Steps To Reproduce

Import the attached survey, activate and run it

Additional Information

See attached screen shots

TagsNo tags attached.
Attached Files
survey_runtime.png (18,378 bytes)   
survey_runtime.png (18,378 bytes)   
settings.png (32,731 bytes)   
settings.png (32,731 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)120510
I will donate to the project if issue is resolvedNo
BrowserFirefox 12
Database type & versionMySQL 5
Server OS (if known)Win 7
Webserver software & version (if known)Apache 2.2
PHP Version5.3.1

Relationships

duplicate of 05762 closedDenisChenu Difference betwwen good and not-applicable 

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2012-05-10 20:05

updater   ~18668

Tom, not sure if you are still available for some little bugfixing. So if not, please assign this one to Carsten.

DenisChenu

DenisChenu

2012-05-11 00:44

developer   ~18689

Mazi,

For 2 multiNumInput2 Multiple numerical input 2 : It's OK because question isn't mandatory: Yes ?

Then put error on dynamic_sum only if question is mandatory is right : OK ?

Denis

Mazi

Mazi

2012-05-11 08:53

updater   ~18690

Hmm, we need to think about how to handle mandatory questions. Even if a question is NOT mandatory, I think we shouldn't mark the text green. Instead of marking it red, we could just leave it black while for mandatory questions we should mark ti red because the user has to answer the question so validation will always be taken into account.

DenisChenu

DenisChenu

2012-05-11 08:59

developer   ~18691

minimum answers => question is "pseudo mandatory"
minimum sum value => question is "pseudo mandatory" (not if minimum sum value==0 :silly:)

question validation equation : we can't say ... depend on the equation.

I add questionInfo['mandatory'] on this part, we can work after on other "bug". But some "bug" can very difficult to manage: exception of exception of exception .... etc.

DenisChenu

DenisChenu

2012-05-11 09:58

developer   ~18692

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8394

DenisChenu

DenisChenu

2012-05-11 11:00

developer   ~18693

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8395

c_schmitz

c_schmitz

2012-05-17 10:27

administrator   ~18820

New 1.92+ version released.

Related Changesets

LimeSurvey: master 294e0af8

2012-05-11 00:57:45

DenisChenu

Details Diff
Fixed issue 06080 : wrong validation for multiple numeric questions
Fixed issue : misaligned input with multi column on citronade
Dev : add 'mandatory' at q2subqInfo for more control
Dev : fixed : mandatory minimum sum value and mandatory min_num_value_n
Affected Issues
06080
mod - classes/expressions/LimeExpressionManager.php Diff File
mod - templates/citronade/template.css Diff File

LimeSurvey: Yii 591414d8

2012-05-11 01:59:26

DenisChenu

Details Diff
Fixed issue 06080 : wrong validation for multiple numeric questions
Fixed issue : misaligned input with multi column on citronade
Dev : add 'mandatory' at q2subqInfo for more control
Dev : fixed : mandatory minimum sum value and mandatory min_num_value_n
Affected Issues
06080
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - templates/citronade/template.css Diff File

Issue History

Date Modified Username Field Change
2012-05-10 11:50 Mazi New Issue
2012-05-10 11:50 Mazi Status new => assigned
2012-05-10 11:50 Mazi Assigned To => c_schmitz
2012-05-10 11:50 Mazi File Added: limesurvey_survey_22791.lss
2012-05-10 11:52 Mazi File Added: survey_runtime.png
2012-05-10 11:52 Mazi File Added: settings.png
2012-05-10 20:05 Mazi Assigned To c_schmitz => TMSWhite
2012-05-10 20:05 Mazi Note Added: 18668
2012-05-10 20:12 TMSWhite Relationship added duplicate of 05762
2012-05-10 20:13 TMSWhite Assigned To TMSWhite => DenisChenu
2012-05-11 00:44 DenisChenu Note Added: 18689
2012-05-11 08:53 Mazi Note Added: 18690
2012-05-11 08:59 DenisChenu Note Added: 18691
2012-05-11 09:58 DenisChenu Changeset attached => LimeSurvey master 294e0af8
2012-05-11 09:58 DenisChenu Note Added: 18692
2012-05-11 09:58 DenisChenu Resolution open => fixed
2012-05-11 11:00 DenisChenu Changeset attached => LimeSurvey Yii 591414d8
2012-05-11 11:00 DenisChenu Note Added: 18693
2012-05-11 11:00 DenisChenu Status assigned => resolved
2012-05-11 11:00 DenisChenu Fixed in Version => 1.92+
2012-05-17 10:27 c_schmitz Note Added: 18820
2012-05-17 10:27 c_schmitz Status resolved => closed