View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
05987Bug reportsSurvey takingpublic2012-05-10 20:49
ReporterMazi Assigned Totpartner  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.92+ 
Target Version1.92+Fixed in Version1.92+ 
Summary05987: prefix and suffix are misaligned for "total" field at miltiple numeric question
Description

If you set a prefix and suffix for the multiple numerical inut question, then the "total" field also includes those strings but they are color coded as well (which probably should not be the case).
See screenshot...

Steps To Reproduce

Import the attached survey and have a look at the second question of the first question group ("Multiple choice questions").

Additional Information
  • tested with "default" template
  • might be related to EM changes (if not, tpartner is the man to have a look)
  • not tested at LS 2.0, but will probably show up there as well
TagsNo tags attached.
Attached Files
prefix.png (10,509 bytes)   
prefix.png (10,509 bytes)   
prefix1.jpg (22,242 bytes)   
prefix1.jpg (22,242 bytes)   
prefix2.jpg (32,259 bytes)   
prefix2.jpg (32,259 bytes)   
Bug heat8
Complete LimeSurvey version number (& build)120405
I will donate to the project if issue is resolvedNo
BrowserFirefox 9
Database type & versionMySQL 5
Server OS (if known)Win 7
Webserver software & version (if known)Apache 2.2
PHP Version5.3.1

Users monitoring this issue

There are no users monitoring this issue.

Activities

TMSWhite

TMSWhite

2012-04-05 17:18

reporter   ~18208

What is the desired solution? Should prefix/suffix appear at all?

When I move prefix/suffix out of the <span class='dynamic_sum'>, it looks like this, which clearly is bad alignment (but must be CSS related)

TMSWhite

TMSWhite

2012-04-05 17:23

reporter   ~18209

Other than that, the reason for the newlines between prefix and suffix must be CSS-related. The generated HTML for prefix.png is this - there are no embedded newlines:

<label for="totalvalue_2171">Total: </label><span id="totalvalue_2171" class="dynamic_sum">prefix<span id='LEMtailor_Q_2171_48'>0</span>suffix</span></li>

Mazi

Mazi

2012-04-05 18:13

updater   ~18210

I think we can just show the raw value there without prefix or suffix?

TMSWhite

TMSWhite

2012-04-05 19:08

reporter   ~18211

Without the prefix/suffix, it looks like this (prefix2.jpg). Presumably CSS styles could be changed to center the value, but might be tricky since would want to be relative to the input boxes. That level of CSS customization is beyond me.

c_schmitz

c_schmitz

2012-04-05 21:13

administrator   ~18239

Let's have Tony a look at it once he is back since it is strongly CSS related
I think the prefix/sufix should appear with the sum, too.

tpartner

tpartner

2012-05-01 17:00

partner   ~18522

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=8287

tpartner

tpartner

2012-05-01 17:00

partner   ~18523

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=8288

tpartner

tpartner

2012-05-01 17:02

partner   ~18524

Fixed in 1.92 and 2.x

Related Changesets

LimeSurvey: master cc46cc1c

2012-05-01 07:59:45

tpartner

Details Diff
Fixed issue 05987: prefix and suffix are misaligned for "total" field at miltiple numeric question
Dev Cleaned up CSS
Affected Issues
05987
mod - templates/basic/template.css Diff File
mod - templates/bluengrey/template.css Diff File
mod - templates/clear_logo/template.css Diff File
mod - templates/default/template.css Diff File
mod - templates/eirenicon/template.css Diff File
mod - templates/limespired/template.css Diff File
mod - templates/mint_idea/template.css Diff File
mod - templates/sherpa/template.css Diff File
mod - templates/vallendar/template.css Diff File

LimeSurvey: Yii 94ee65b8

2012-05-01 08:00:28

tpartner

Details Diff
Fixed issue 05987: prefix and suffix are misaligned for "total" field at miltiple numeric question
Dev Cleaned up CSS
Affected Issues
05987
mod - templates/basic/template.css Diff File
mod - templates/bluengrey/template.css Diff File
mod - templates/clear_logo/template.css Diff File
mod - templates/default/template.css Diff File
mod - templates/eirenicon/template.css Diff File
mod - templates/limespired/template.css Diff File
mod - templates/mint_idea/template.css Diff File
mod - templates/sherpa/template.css Diff File
mod - templates/vallendar/template.css Diff File

Issue History

Date Modified Username Field Change
2012-04-05 16:00 Mazi New Issue
2012-04-05 16:00 Mazi Status new => assigned
2012-04-05 16:00 Mazi Assigned To => TMSWhite
2012-04-05 16:00 Mazi File Added: prefix.png
2012-04-05 16:01 Mazi File Added: limesurvey_survey_98478.lss
2012-04-05 17:18 TMSWhite Note Added: 18208
2012-04-05 17:19 TMSWhite File Added: prefix1.jpg
2012-04-05 17:23 TMSWhite Note Added: 18209
2012-04-05 18:13 Mazi Note Added: 18210
2012-04-05 19:08 TMSWhite Note Added: 18211
2012-04-05 19:08 TMSWhite File Added: prefix2.jpg
2012-04-05 21:13 c_schmitz Assigned To TMSWhite => tpartner
2012-04-05 21:13 c_schmitz Note Added: 18239
2012-05-01 17:00 tpartner Changeset attached => LimeSurvey master cc46cc1c
2012-05-01 17:00 tpartner Note Added: 18522
2012-05-01 17:00 tpartner Resolution open => fixed
2012-05-01 17:00 tpartner Changeset attached => LimeSurvey Yii 94ee65b8
2012-05-01 17:00 tpartner Note Added: 18523
2012-05-01 17:02 tpartner Note Added: 18524
2012-05-01 17:02 tpartner Status assigned => resolved
2012-05-10 20:49 c_schmitz Status resolved => closed
2012-05-10 20:49 c_schmitz Fixed in Version => 1.92+