View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
05936 | Bug reports | Survey taking | public | 2012-03-21 13:27 | 2012-03-23 13:04 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 1.92+ | ||||
Fixed in Version | 1.92+ | ||||
Summary | 05936: INSERTANS cannot be used in "Send basic admin notification email to:" | ||||
Description | With 1.91, a lot of user use INSERTANS in basic email notfication to the respondant. Actually it isn't possible. I test with {QMAIL};{INSERTANS};QMAIL. In replacement.php we have: | ||||
Steps To Reproduce | Try to put some INSERTANS in basic admin notification | ||||
Additional Information | Tested with : With an anonymous survey, without printing answer, and it's OK for 120321 | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 120321 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
Fix looks fine. Please commit to 1.92 and 2.0 |
|
See to use ReplaceFields and LimeExpressionManager::ProcessString directly. Maybe some "anonymous issue" else. |
|
Instead of just doing this: function dTexts__run($text,$questionNum=NULL) it's worth seeing where dTexts_run() is called - otherwise you can get significant slow-down since EM will be called many more times than is needed. I think core problem is that emails aren't being processed through templatereplace(), which internally calls EM. |
|
Yep, It's what i see, think use ReplaceFields is the best solution. Did anonimity ( TOKEN not replaced ) are set in ReplaceFields or in LimeExpressionManager. Or in ReplaceFields parameter only. I can look at the code, but think you can answer directly (if my sentence are compréhensible ... PS: I already have a look at dTexts_run to remove it, there are a lot in index.php and some other. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8003 |
|
LimeSurvey: master d654c487 2012-03-21 17:46:28 Details Diff |
Fixed issue 05936 : INSERTANS or TOKEN cannot be used in mail adress notification Dev : replace old dTexts::Run by ReplaceFields Dev : Remove anonymized dtexts : already done with ReplaceFields ExpressionManager functionnality |
Affected Issues 05936 |
|
mod - index.php | Diff File | ||
mod - replacements.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-03-21 13:27 | DenisChenu | New Issue | |
2012-03-21 14:49 | c_schmitz | Assigned To | => DenisChenu |
2012-03-21 14:49 | c_schmitz | Status | new => assigned |
2012-03-21 14:49 | c_schmitz | Note Added: 18021 | |
2012-03-21 16:20 | DenisChenu | Note Added: 18024 | |
2012-03-21 17:38 | TMSWhite | Note Added: 18026 | |
2012-03-21 19:46 | DenisChenu | Note Added: 18027 | |
2012-03-21 19:47 | DenisChenu | Note Edited: 18027 | |
2012-03-22 01:47 | DenisChenu | Changeset attached | => LimeSurvey master d654c487 |
2012-03-22 01:47 | DenisChenu | Note Added: 18037 | |
2012-03-22 01:47 | DenisChenu | Resolution | open => fixed |
2012-03-22 01:59 | DenisChenu | Status | assigned => resolved |
2012-03-23 13:04 | c_schmitz | Status | resolved => closed |
2012-03-23 13:04 | c_schmitz | Fixed in Version | => 1.92+ |