View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
05898Bug reportsSurvey takingpublic2012-03-11 16:152012-03-15 01:32
ReporterTMSWhite Assigned ToTMSWhite  
PrioritylowSeverityminor 
Status closedResolutionfixed 
Product Version1.92+ 
Target Version1.92+Fixed in Version1.92+ 
Summary05898: {GOOGLE_ANALYTICS_JAVASCRIPT} integration errors
Description

(1) Should be in startpage.pstpl before </head> for all templates
(2) replacements.php - "catch (err) {}" throws error - needs to be "catch (err) { }"
(3) should be blank if there is no {GOOGLE_ANALYTICS_API_KEY}
(4) if {GOOGLE_ANALYTICS_API_KEY} for survey is blank, should use global googleanalyticsapikey value.
(5) Type 2 $_googleAnalyticsStyle, "SurveyName-[SID]/GroupName" style, should also show GSEQ, and whether on welcome or ending page for easier tracking of navigation path

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)120311
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql 5.3
Server OS (if known)Windows XP
Webserver software & version (if known)XAMPP
PHP Version5.3

Users monitoring this issue

There are no users monitoring this issue.

Activities

TMSWhite

TMSWhite

2012-03-11 20:40

reporter   ~17883

Fixed with commit https://github.com/LimeSurvey/LimeSurvey/commit/698b38a80f62388969d694d897178b46a5139503

Related Changesets

LimeSurvey: master 698b38a8

2012-03-11 12:41:19

TMSWhite

Details Diff 		Fixed issue 05898: {GOOGLE_ANALYTICS_JAVASCRIPT} integration errors Affected Issues
05898
mod - classes/expressions/LimeExpressionManager.php Diff File
mod - group.php Diff File
mod - replacements.php Diff File
mod - templates/basic/startpage.pstpl Diff File
mod - templates/bluengrey/startpage.pstpl Diff File
mod - templates/citronade/startpage.pstpl Diff File
mod - templates/clear_logo/startpage.pstpl Diff File
mod - templates/default/startpage.pstpl Diff File
mod - templates/eirenicon/startpage.pstpl Diff File
mod - templates/limespired/startpage.pstpl Diff File
mod - templates/mint_idea/startpage.pstpl Diff File
mod - templates/sherpa/startpage.pstpl Diff File
mod - templates/vallendar/startpage.pstpl Diff File

LimeSurvey: Yii 98bde57e

2012-03-12 19:37:08

TMSWhite

Details Diff 		Fixed issue 05898: {GOOGLE_ANALYTICS_JAVASCRIPT} integration errors
Dev upgraded Goggle Analytics JavaScript to use recommended async code		 Affected Issues
05898
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/helpers/replacements_helper.php Diff File
mod - templates/basic/startpage.pstpl Diff File
mod - templates/bluengrey/startpage.pstpl Diff File
mod - templates/citronade/startpage.pstpl Diff File
mod - templates/clear_logo/startpage.pstpl Diff File
mod - templates/default/startpage.pstpl Diff File
mod - templates/eirenicon/startpage.pstpl Diff File
mod - templates/limespired/startpage.pstpl Diff File
mod - templates/mint_idea/startpage.pstpl Diff File
mod - templates/sherpa/startpage.pstpl Diff File
mod - templates/vallendar/startpage.pstpl Diff File

Issue History

Date Modified Username Field Change
2012-03-11 16:15 TMSWhite New Issue
2012-03-11 16:15 TMSWhite Status new => assigned
2012-03-11 16:15 TMSWhite Assigned To => TMSWhite
2012-03-11 20:40 TMSWhite Note Added: 17883
2012-03-11 20:40 TMSWhite Status assigned => resolved
2012-03-11 20:40 TMSWhite Fixed in Version => 1.92+
2012-03-11 20:40 TMSWhite Resolution open => fixed
2012-03-14 18:14 TMSWhite Changeset attached => Import 2012-03-09 13:30:34 master 698b38a8
2012-03-14 21:08 TMSWhite Changeset attached => Import 2012-03-09 13:30:34 Yii 98bde57e
2012-03-15 01:32 c_schmitz Status resolved => closed