05776: survey_runtime.js should not need to call check_conditions at startup - LimeSurvey bugs, patches and feature requests

LimeSurvey issue tracker

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

05776

Development

Survey taking

public

2012-02-08 04:37

2013-02-01 11:22

Reporter

TMSWhite

Assigned To

TMSWhite

Priority

low

Severity

tweak

Status

assigned

Resolution

open

Product Version

Target Version

Fixed in Version

Summary

05776: survey_runtime.js should not need to call check_conditions at startup

Description

All text should be properly tailored; validations applied; and relevance criteria evaluated in PHP - should not need to also be called from JavaScript

Steps To Reproduce

comment out line:

if (typeof checkconditions!='undefined') checkconditions();

from survey_runtime.js and see (when running ls2_validation_tests.lss) that without running that function at startup, get validation tips in black (instead of color) that are missing their tailoring (e.g. "Please enter a number greater than" without the tailored number value)

Additional Information

This is just a performance issue. It might be possible to speed up load a fraction of a second if this is resolved.

Tags

No tags attached.

Relationships

Notes
(23932) DenisChenu (developer) 2013-02-01 11:20 edited on: 2013-02-01 11:22	Hello Thomas, Think we had to remove all inline condition function. And put this in external javascript with $.delegate system. For exemple for text input: $("#limesurvey").delegate("input.text","keyup focusout",function(event){ value=$(this).val(); name=$(this).attr("name"); type='text'; evt_type=event; // Do the function } Etc .... $.delegate is really better than included javascript, more robust javascript. But need a lot of time to update this ;). Use the .text class for restrict to only needed input, can test if numeric or if integeronly with: numeric=$(this).hasClass("numeric"); integeronly=$(this).hasClass("integeronly"); Etc ....

Issue History
Date Modified	Username	Field	Change
2012-02-08 04:37	TMSWhite	New Issue
2012-02-09 09:43	Mazi	Assigned To	=> TMSWhite
2012-02-09 09:43	Mazi	Status	new => assigned
2012-02-23 16:43	TMSWhite	Project	Bug reports => Development
2013-02-01 11:20	DenisChenu	Note Added: 23932
2013-02-01 11:22	DenisChenu	Note Edited: 23932	View Revisions

Copyright © 2000 - 2013 MantisBT Team