View Issue Details

This issue affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
05776Bug reportspublic2026-11-19 23:12
ReporterTMSWhite Assigned ToTMSWhite  
PrioritylowSeveritytweak 
Status closedResolutionwon't fix 
Summary05776: survey_runtime.js should not need to call check_conditions at startup
Description

All text should be properly tailored; validations applied; and relevance criteria evaluated in PHP - should not need to also be called from JavaScript

Steps To Reproduce

comment out line:

if (typeof checkconditions!='undefined') checkconditions();

from survey_runtime.js and see (when running ls2_validation_tests.lss) that without running that function at startup, get validation tips in black (instead of color) that are missing their tailoring (e.g. "Please enter a number greater than" without the tailored number value)

Additional Information

This is just a performance issue. It might be possible to speed up load a fraction of a second if this is resolved.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)12401
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql 5.3
Server OS (if known)Windows XP
Webserver software & version (if known)XAMPP
PHP Version5.3
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-02-01 11:20

developer   ~23932

Last edited: 2013-02-01 11:22

Hello Thomas,

Think we had to remove all inline condition function.
And put this in external javascript with $.delegate system.

For exemple for text input:
$("#limesurvey").delegate("input.text","keyup focusout",function(event){
value=$(this).val();
name=$(this).attr("name");
type='text';
evt_type=event;
// Do the function
}

Etc ....
$.delegate is really better than included javascript, more robust javascript.
But need a lot of time to update this ;).

Use the .text class for restrict to only needed input, can test if numeric or if integeronly with:
numeric=$(this).hasClass("numeric");
integeronly=$(this).hasClass("integeronly");

Etc ....

DenisChenu

DenisChenu

2013-09-21 15:15

developer   ~26302

Think better to use data css3 function.

c_schmitz

c_schmitz

2026-11-19 23:12

administrator   ~87774

Closing this. The page still needs this check when it loads, and removing it would mean a big and risky rewrite for a very small speed gain.

Issue History

Date Modified Username Field Change
2012-02-08 04:37 TMSWhite New Issue
2012-02-09 09:43 Mazi Assigned To => TMSWhite
2012-02-09 09:43 Mazi Status new => assigned
2012-02-23 16:43 TMSWhite Project Bug reports => @10@
2013-02-01 11:20 DenisChenu Note Added: 23932
2013-02-01 11:22 DenisChenu Note Edited: 23932
2013-09-21 15:15 DenisChenu Note Added: 26302
2026-11-19 23:12 c_schmitz Note Added: 87774
2026-11-19 23:12 c_schmitz Bug heat 2 => 4
2026-11-19 23:12 c_schmitz Status assigned => closed
2026-11-19 23:12 c_schmitz Resolution open => @0@
2026-11-19 23:12 c_schmitz Product Version 1.92RC3 =>
2026-11-19 23:12 c_schmitz Resolution @0@ => won't fix
2026-11-20 10:33 c_schmitz Category Survey taking => (No Category)