View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
05159 | Bug reports | Other | public | 2011-05-11 05:47 | 2011-05-25 12:21 |
Reporter | Assigned To | c_schmitz | |||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 1.91 | ||||
Fixed in Version | 1.91+ | ||||
Summary | 05159: code printing when using showprintablesurvey with radio button | ||||
Description | " class="input-radio" /> will print between the button image and the option supposed to be next to it. | ||||
Steps To Reproduce | -create a new question | ||||
Tags | No tags attached. | ||||
Attached Files | 5159.diff (856 bytes)
### Eclipse Workspace Patch 1.0 #P Limesurvey 1.x trunk stable Index: admin/printablesurvey.php =================================================================== --- admin/printablesurvey.php (revision 10061) +++ admin/printablesurvey.php (working copy) @@ -329,7 +329,7 @@ // define('IMAGE_'.$type.'_SIZE' , ' width="'.$image_dimensions[0].'" height="'.$image_dimensions[1].'"'); define('IMAGE_'.$type.'_SIZE' , ' width="14" height="14"'); } - $output = '<img src="'.PRINT_TEMPLATE_URL.'print_img_'.$type.'.png"'.constant('IMAGE_'.$type.'_SIZE').' alt="'.$title.'" class="input-'.$type.'" />'; + $output = '<img src="'.PRINT_TEMPLATE_URL.'print_img_'.$type.'.png"'.constant('IMAGE_'.$type.'_SIZE').' alt="'.htmlspecialchars($title).'" class="input-'.$type.'" />'; break; case 'rank': 5159.2.diff (1,574 bytes)
### Eclipse Workspace Patch 1.0 #P Limesurvey 1.x trunk stable Index: admin/printablesurvey.php =================================================================== --- admin/printablesurvey.php (revision 10061) +++ admin/printablesurvey.php (working copy) @@ -121,7 +121,7 @@ $pdf_form = ' <form action="'.$scriptname.'?action=showprintablesurvey&sid='.$surveyid.'&lang='.$surveyprintlang.'" method="post"> <input type="submit" value="'.$clang->gT('PDF Export').'"/> - <input type="hidden" name="checksessionbypost" value="'.$_SESSION['checksessionpost'].'"/> + <input type="hidden" name="checksessionbypost" value="'.htmlspecialchars($_SESSION['checksessionpost']).'"/> <input type="hidden" name="printableexport" value="true"/> </form> '; @@ -306,7 +306,7 @@ if(!empty($title)) { - $div_title = ' title="'.$title.'"'; + $div_title = ' title="'.htmlspecialchars($title).'"'; } else { @@ -329,7 +329,7 @@ // define('IMAGE_'.$type.'_SIZE' , ' width="'.$image_dimensions[0].'" height="'.$image_dimensions[1].'"'); define('IMAGE_'.$type.'_SIZE' , ' width="14" height="14"'); } - $output = '<img src="'.PRINT_TEMPLATE_URL.'print_img_'.$type.'.png"'.constant('IMAGE_'.$type.'_SIZE').' alt="'.$title.'" class="input-'.$type.'" />'; + $output = '<img src="'.PRINT_TEMPLATE_URL.'print_img_'.$type.'.png"'.constant('IMAGE_'.$type.'_SIZE').' alt="'.htmlspecialchars($title).'" class="input-'.$type.'" />'; break; case 'rank': | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 10060 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | firefox 4 | ||||
Database type & version | mysql 5.0.82 | ||||
Server OS (if known) | sme server 7.5.1 | ||||
Webserver software & version (if known) | php 5.1.6-3.el4s1.10 | ||||
PHP Version | 5.1.6-3.el4s1.10 | ||||
note sure if it can help here is the source code of one answer in the browser : <li> you can see some problem starting with the alt= |
|
Looks like the text get's inserted there unencoded, but the attribute will need html encoding for attributes. I'll take a look if this is easy to patch. |
|
i have searched further and found the file responsible of this : admin/ printablesurvey.php The incriminated line is the 313 It could be : However it seems that the variable $title contain exactly what will be print next to the radio button. I am not sure i want to see twice my answer if the button image is not found. I rather see something that is like a radio button like a O It should be better to see sommething like this ( a "-" or a "O"): $output = '<img src="'.PRINT_TEMPLATE_URL.'printimg'.$type.'.png"'.constant('IMAGE_'.$type.'_SIZE').' alt="-" class="input-'.$type.'" />'; |
|
Thanks for providing that additional information. I had a hard time to locate it so far because I needed to setup my development environment first. I'll upload a patch. However option titles IIRC do only support HTML fragments when displayed on the online version. The hard copy version will only allow to display text next to the checkbox/radio picture, not pictures or other HTML. So it will display just a radio with nothing next to it. What you want to achieve looks like a feature request to me, but I think it's not trivial to implement. |
|
Quickly scanned the file for similar issues and found another two. |
|
Fixed in rev 10067 |
|
Thx. |
|
Thank YOU! |
|
Released new 1.91+ version. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2011-05-11 05:47 |
|
New Issue | |
2011-05-11 06:27 |
|
Note Added: 14980 | |
2011-05-11 16:24 | mot | Note Added: 14983 | |
2011-05-11 16:46 |
|
Note Added: 14984 | |
2011-05-12 00:35 | mot | Note Added: 14985 | |
2011-05-12 00:47 | mot | File Added: 5159.diff | |
2011-05-12 00:50 | mot | File Added: 5159.2.diff | |
2011-05-12 00:51 | mot | Note Added: 14986 | |
2011-05-12 00:51 | mot | Issue Monitored: mot | |
2011-05-12 00:51 | mot | Issue End Monitor: mot | |
2011-05-12 17:16 | c_schmitz | Assigned To | => c_schmitz |
2011-05-12 17:16 | c_schmitz | Status | new => assigned |
2011-05-15 12:13 | c_schmitz | Note Added: 15005 | |
2011-05-15 12:13 | c_schmitz | Status | assigned => resolved |
2011-05-15 12:13 | c_schmitz | Fixed in Version | => 1.91+ |
2011-05-15 12:13 | c_schmitz | Resolution | open => fixed |
2011-05-16 16:40 | mot | Note Added: 15036 | |
2011-05-16 16:42 | c_schmitz | Note Added: 15037 | |
2011-05-25 12:21 | c_schmitz | Note Added: 15103 | |
2011-05-25 12:21 | c_schmitz | Status | resolved => closed |