View Issue Details

This bug affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
05129Bug reportsOtherpublic2011-05-04 19:50
Reporteruser13655Assigned Totpartner  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.90+ 
Fixed in Version1.91 
Summary05129: In userrighthandling.php form and table are badly imbricated
Description

In userrighthandling.php line 308 the form <form method='post' action='$scriptname'> is inside a table, which is not correct. Moreover the form is closed line 367 in a different <tr>. This will cause problems when running behind a reverse proxy.

Additional Information

When running behind an apache reverse proxy, the code will not work because the reverse proxy will "correct" the code by adding a </form> just behind the <form> on line 308 and delete the </form> on line 367. The validate button will thus be outside the form and will have no effect.

This can be corrected easily by moving the form opening tag to line 264 :
$usersummary = "<form method='post' action='$scriptname'><table width='100%' border='0'>\n<tr><td colspan='8' class='header' align='center'>\n"

and moving the closing form tag after the closing table tag (i.e. switching lines 367 and 368.

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)9642
I will donate to the project if issue is resolvedNo
BrowserAll
Database type & versionMysql
Server OS (if known)Linux
Webserver software & version (if known)apache
PHP Version5

Users monitoring this issue

There are no users monitoring this issue.

Activities

tpartner

tpartner

2011-04-26 14:42

partner   ~14864

Fixed in revision 10020.

Thanks for the report ifleg.

Issue History

Date Modified Username Field Change
2011-04-26 12:26 user13655 New Issue
2011-04-26 14:23 tpartner Assigned To => tpartner
2011-04-26 14:23 tpartner Status new => assigned
2011-04-26 14:42 tpartner Note Added: 14864
2011-04-26 14:42 tpartner Status assigned => resolved
2011-04-26 14:42 tpartner Resolution open => fixed
2011-05-04 19:50 c_schmitz Status resolved => closed
2011-05-04 19:50 c_schmitz Fixed in Version => 1.91