View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
05043 | Bug reports | Import/Export | public | 2011-03-19 17:16 | 2011-04-11 11:30 |
Reporter | dionet | Assigned To | DenisChenu | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 1.91RC5 | ||||
Fixed in Version | 1.91RC6 | ||||
Summary | 05043: HTML UI defect when importing surveys | ||||
Description | The import survey function that displayed a message when the import failed wasn't implemented in the HTTP part, so the page looked broken. I've attached a patch that fixes the problem. | ||||
Steps To Reproduce | Open Administration Panel, create a new survey, click Import and select an invalid file. | ||||
Tags | No tags attached. | ||||
Attached Files | htmlfix.diff (667 bytes)
Index: admin/importsurvey.php =================================================================== --- admin/importsurvey.php (revision 9890) +++ admin/importsurvey.php (working copy) @@ -110,6 +110,13 @@ unlink($sFullFilepath); } } +elseif (isset($bImportFailed) && $bImportFailed==true && $importingfrom == "http") +{ + $importsurvey .= "<strong>".$clang->gT("Error")."</strong><br />\n"; + $importsurvey .= $clang->gT("Import failed. You specified an invalid file.")."\n"; + $importsurvey .= "</div><br />\n"; + +} elseif (isset($bImportFailed) && $bImportFailed==true) { echo "\n".$clang->gT("Error")."\n\n"; | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 9890 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | MySQL 5.1.49 | ||||
Server OS (if known) | Ubuntu 10.10 | ||||
Webserver software & version (if known) | Apache/2.2.16 | ||||
PHP Version | 5.3.3 | ||||
Shnoulle, can you check the problem and attached patch? |
|
OK, And have some other correction for HTML alert (replacing alert by the new html . I trye to look for this thurday. |
|
Hello, I look for the patch , and this one work good, but i think there are some problem. Actually , we have http_importsurvey.php with the import function, and at the end of this one : include("importsurvey.php"); I don't understand.... I can put all import functionnality in http_importsurvey.php, and remove importsurvey.php . And there are another problem: I think the best is to put whole import survey traitment in http_importsurvey.php. Carsten, i need your advice, after you can put it to me. |
|
Shnoulle, I agree. PLease go ahead. |
|
Fixed in 9946 and 9948 for dev version Maybe had to remove or review importsurvey.php file to be standalone |
|
1.91RC6 released. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2011-03-19 17:16 | dionet | New Issue | |
2011-03-19 17:16 | dionet | File Added: htmlfix.diff | |
2011-03-21 00:33 | Mazi | Assigned To | => DenisChenu |
2011-03-21 00:33 | Mazi | Status | new => assigned |
2011-03-21 00:34 | Mazi | Note Added: 14482 | |
2011-03-21 08:52 | DenisChenu | Note Added: 14494 | |
2011-03-27 16:08 | DenisChenu | Note Added: 14557 | |
2011-03-27 16:08 | DenisChenu | Assigned To | DenisChenu => c_schmitz |
2011-03-29 19:34 | c_schmitz | Note Added: 14603 | |
2011-03-29 19:35 | c_schmitz | Assigned To | c_schmitz => DenisChenu |
2011-04-03 18:31 | DenisChenu | Note Added: 14637 | |
2011-04-03 18:31 | DenisChenu | Status | assigned => resolved |
2011-04-03 18:31 | DenisChenu | Fixed in Version | => 1.91RC6 |
2011-04-03 18:31 | DenisChenu | Resolution | open => fixed |
2011-04-11 11:30 | c_schmitz | Note Added: 14752 | |
2011-04-11 11:30 | c_schmitz | Status | resolved => closed |