View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
04948Bug reportsAccessibilitypublic2011-02-10 23:112012-02-24 09:41
Reporterlstrange Assigned Tomagiclko 
PriorityhighSeveritypartial_block 
Status closedResolutionfixed 
Product Version1.90+ 
Target Version2.00a2Fixed in Version1.92RC4 
Summary04948: "label for' tags for certain forms fields
Description

Hello - in generating a report, I noticed that 'label for' tags were generated for radio buttons, checkboxes and arrays but not for text boxes and textareas.

Here is a sample of label for tagging with a radio button:

<li>

<input class="radio" type="radio" name="74761X2X4" id="answer74761X2X4Y" value="Y" onclick="noop_checkconditions(this.value, this.name, this.type)" />
<label for="answer74761X2X4Y" class="answertext">
Yes
</label>

Steps To Reproduce

Here is a textbox example with no label for tagging:

&lt;span class=&quot;asterisk&quot;>*&lt;/span>What is your name?<br /><br />&lt;span class=&quot;questionhelp&quot;>&lt;/span>

        &lt;/td>
    &lt;/tr>
    &lt;tr>
        &lt;td class=&quot;answer&quot;>
            &lt;p class=&quot;question&quot;>

&lt;input class=&quot;text&quot; type=&quot;text&quot; size=&quot;50&quot; name=&quot;74761X1X1&quot; id=&quot;answer74761X1X1&quot; value=&quot;&quot; maxlength=&quot;40&quot; onkeyup=&quot;noop_checkconditions(this.value, this.name, this.type)&quot;  />

</p>

Textarea example:

<span class="asterisk"></span>Please describe if you were able to use this survey tool what data you would collect?<br /><br /><span class="questionhelp"></span>

        &lt;/td>
    &lt;/tr>
    &lt;tr>
        &lt;td class=&quot;answer&quot;>
            &lt;script type='text/javascript'>
           &lt;!--
           function textLimit(field, maxlen) {
            if (document.getElementById(field).value.length > maxlen)
            document.getElementById(field).value = document.getElementById(field).value.substring(0, maxlen);
            }
           //-->
           &lt;/script>

<textarea class="textarea" name="74761X2X29" id="answer74761X2X29" alt="Answer" rows="5" cols="40" onkeyup="textLimit('answer74761X2X29', 65525); noop_checkconditions(this.value, this.name, this.type)"></textarea>

Additional Information

We are planning to use this in a state government/higher ed. environment and are required to comply with Section 508 compliance, thus the reason for the request. Is there any chance this feature can be added? I appreciate it.

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)9642
I will donate to the project if issue is resolvedNo
BrowserInternet Explorer 8
Database type & versionMySQL 5.0.89
Server OS (if known)Apache
Webserver software & version (if known)Unix
PHP Version5.2.10

Relationships

Relationship GraphDependency Graph
parent of 05846 closedDenisChenu Label on question texte can be a bad solution 

Users monitoring this issue

DenisChenu

Activities

c_schmitz

c_schmitz

2011-03-11 13:12

administrator   ~14401

Evan, can you have a look at this. I am not sure this should be generally done as an additional "label for" attribute encapsulating the question text might be limiting rgearding other purposes. Maybe this should be an advanced question setting for the related question types?
lstrange

lstrange

2012-01-24 21:02

reporter   ~16953

Any status on this issue? Thanks. Lainie
c_schmitz

c_schmitz

2012-02-02 17:15

administrator   ~17172

Shubham: Please implement in 2.0 a question attribute which is activated by default which encapsulates the question text for single choice question types with an according <label for> tag
TMSWhite

TMSWhite

2012-02-02 21:02

reporter   ~17188

FYI, <label> tag is missing for these question types:
(1) List dropdown
(2) Date
(3) File Upload
(4) Language
(5) Numerical
(6) Text
(7) Huge
(8) Long
(9) Short

(at least in 1.92 RC3)
TMSWhite

TMSWhite

2012-02-02 22:45

reporter   ~17191

fixed in revision 12317
c_schmitz

c_schmitz

2012-02-02 23:32

administrator   ~17193

Shubham, can you please modify the solution so that instead of the <label> tag surrounding the control it is using the for='' attribute? Also this still must be ported to Yii. Thank you!
DenisChenu

DenisChenu

2012-02-03 09:14

developer   ~17200

Hello,

See the solution for 12317 , but one question:

Did the label don't have an text information, explain more:
<label for="day'.$ia[1].'"><select id="day'.$ia[1].'" name="day'.$ia[1].'" class="day">....</select></label> : good but not perfect.

<label for="day'.$ia[1].'" class="hide">Choose the day</label><select id="day'.$ia[1].'" name="day'.$ia[1].'" class="day">....</select> : Perfect.

We have already hide class in a lot of template.css file.

I can make the patch.

PS: same think for other input.text
magiclko

magiclko

2012-02-03 19:38

reporter   ~17214

Fixed in rev 12329. Please check!
c_schmitz

c_schmitz

2012-02-14 14:10

administrator   ~17422

1.92RC4 released

Issue History

Date Modified Username Field Change
2011-02-10 23:11 lstrange New Issue
2011-02-10 23:11 lstrange Status new => assigned
2011-02-10 23:11 lstrange Assigned To => Evan
2011-02-15 21:33 c_schmitz Assigned To Evan => c_schmitz
2011-03-08 14:52 c_schmitz Category Accessibility => (No Category)
2011-03-11 13:10 c_schmitz Category (No Category) => Accessibility
2011-03-11 13:10 c_schmitz Assigned To c_schmitz => Evan
2011-03-11 13:12 c_schmitz Note Added: 14401
2011-03-11 13:12 c_schmitz Project Bug reports => Development
2011-04-17 16:29 c_schmitz Assigned To Evan => c_schmitz
2012-01-24 21:01 lstrange Issue Monitored: lstrange
2012-01-24 21:01 lstrange Issue End Monitor: lstrange
2012-01-24 21:02 lstrange Note Added: 16953
2012-01-24 21:22 c_schmitz Project Development => Bug reports
2012-02-02 01:17 c_schmitz Target Version => 2.00a2
2012-02-02 17:13 c_schmitz Assigned To c_schmitz => magiclko
2012-02-02 17:15 c_schmitz Note Added: 17172
2012-02-02 21:02 TMSWhite Note Added: 17188
2012-02-02 22:45 TMSWhite Note Added: 17191
2012-02-02 22:45 TMSWhite Status assigned => resolved
2012-02-02 22:45 TMSWhite Fixed in Version => 1.92RC4
2012-02-02 22:45 TMSWhite Resolution open => fixed
2012-02-02 22:45 TMSWhite Assigned To magiclko => TMSWhite
2012-02-02 23:31 c_schmitz Assigned To TMSWhite => magiclko
2012-02-02 23:31 c_schmitz Status resolved => assigned
2012-02-02 23:32 c_schmitz Note Added: 17193
2012-02-03 09:14 DenisChenu Note Added: 17200
2012-02-03 19:38 magiclko Note Added: 17214
2012-02-03 19:38 magiclko Status assigned => resolved
2012-02-04 13:33 DenisChenu Issue Monitored: DenisChenu
2012-02-14 14:10 c_schmitz Note Added: 17422
2012-02-14 14:10 c_schmitz Status resolved => closed
2012-02-24 09:41 DenisChenu Relationship added parent of 05846