View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
04928Bug reportsSurvey editingpublic2011-02-04 10:212011-03-08 16:53
Reporterftrifoglio Assigned Totpartner  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.91RC2 
Target Version1.91RC4Fixed in Version1.91RC4 
Summary04928: GSoC - answer options in list radio don't work well
Description

FIRST ROW BUG

The first row of the answer option doesn't allow to open the html editor.
You have to add a second row and save to let it work properly.

DRAG-N-DROP ORDERING BUG

Let's that you have two rows

#1 - Row 1 Description
#2 - Row 2 Description

You drag the #1 and drop it in replace of the #2. This is what happens next

#2 - Row 1 Description
#1 -

It changes the row id order, keeps the description order and delete the description of the row you replaced.

TagsNo tags attached.
Attached Files
04928_fix.patch (1,766 bytes)    
Index: htmleditor-functions.php
===================================================================
--- htmleditor-functions.php	(revision 9767)
+++ htmleditor-functions.php	(working copy)
@@ -291,7 +291,10 @@
     }
 
     $htmlcode .= ""
-    . "<a href=\"javascript:start_popup_editor('".$fieldname."','".$fieldtext."','".$surveyID."','".$gID."','".$qID."','".$fieldtype."','".$action."')\" id='".$fieldname."_ctrl' title=\"".$clang->gTview("Start HTML Editor in a Popup Window")."\"><img alt=\"".$clang->gT("Start HTML Editor in a Popup Window")."\" id='".$fieldname."_popupctrlena' name='".$fieldname."_popupctrlena' border='0' src='".$imageurl."/edithtmlpopup.png'  $imgopts /><img alt=\"".$clang->gT("Give focus to the HTML Editor Popup Window")."\" id='".$fieldname."_popupctrldis' name='".$fieldname."_popupctrldis' border='0' src='".$imageurl."/edithtmlpopup_disabled.png' style='display: none'  $imgopts align='top'/></a>";
+    . "<a href=\"javascript:start_popup_editor('".$fieldname."','".$fieldtext."','".$surveyID."','".$gID."','".$qID."','".$fieldtype."','".$action."')\" id='".$fieldname."_ctrl' title=\"".$clang->gTview("Start HTML Editor in a Popup Window")."\" class='editorLink'>\n"
+	. "\t<img alt=\"".$clang->gT("Start HTML Editor in a Popup Window")."\" id='".$fieldname."_popupctrlena' name='".$fieldname."_popupctrlena' border='0' src='".$imageurl."/edithtmlpopup.png'  $imgopts class='btneditanswerena' />\n"
+	. "\t<img alt=\"".$clang->gT("Give focus to the HTML Editor Popup Window")."\" id='".$fieldname."_popupctrldis' name='".$fieldname."_popupctrldis' border='0' src='".$imageurl."/edithtmlpopup_disabled.png' style='display: none'  $imgopts align='top' class='btneditanswerdis' />\n"
+	. "</a>\n";
 
     return $htmlcode;
 }
04928_fix.patch (1,766 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)9672
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL: 5.0.91-community
Server OS (if known)Linux
Webserver software & version (if known)Apache 2.2.17
PHP Version5.2.16

Users monitoring this issue

There are no users monitoring this issue.

Activities

tpartner

tpartner

2011-02-11 15:35

partner   ~14148

Carsten, regarding problem 1 - this is because no classes are assigned to the editor link or images in htmleditor-functions.php. This means that their IDs are not modified correctly on page load by function updaterowproperties() in answers.js. I believe my patch should fix it up.

I cannot reproduce problem 2 in Chrome or FF.
c_schmitz

c_schmitz

2011-02-11 17:03

administrator   ~14152

Last edited: 2011-02-11 17:04

Hello Tony, looks great. Please apply. I can't reproduce problem 2 so I guess it is already fixed. Please set to resolved after you applied.
tpartner

tpartner

2011-02-11 20:36

partner   ~14158

Fixed in revision 9773

Issue History

Date Modified Username Field Change
2011-02-04 10:21 ftrifoglio New Issue
2011-02-09 15:59 Mazi Assigned To => c_schmitz
2011-02-09 15:59 Mazi Status new => assigned
2011-02-09 15:59 Mazi Target Version => 1.91RC4
2011-02-09 15:59 Mazi Summary answer options in list radio don't work well => GSoC - answer options in list radio don't work well
2011-02-11 15:35 tpartner Note Added: 14148
2011-02-11 15:36 tpartner File Added: 04928_fix.patch
2011-02-11 17:02 c_schmitz Assigned To c_schmitz => tpartner
2011-02-11 17:03 c_schmitz Note Added: 14152
2011-02-11 17:04 c_schmitz Note Edited: 14152
2011-02-11 20:36 tpartner Note Added: 14158
2011-02-11 20:36 tpartner Status assigned => resolved
2011-02-11 20:36 tpartner Resolution open => fixed
2011-03-08 16:53 c_schmitz Status resolved => closed
2011-03-08 16:53 c_schmitz Fixed in Version => 1.91RC4
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing