View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
04398 | Bug reports | Survey taking | public | 2010-06-07 20:16 | 2010-06-16 22:30 |
Reporter | jdalegonzalez | Assigned To | c_schmitz | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 1.87+ | ||||
Fixed in Version | 1.90RC2 | ||||
Summary | 04398: limesurvey/index.php at line 803 retests $column over and over when it doesn't need to. | ||||
Description | When reloading a survey, data is pulled from the table into the session. Most of the time, the column name is the same as the session variable and so the load is as simple as $_SESSION[$column] = $value. Sometimes, either the value from the table doesn't go in session, column name in session isn't the same or the column name isn't in the insertarray list. In those cases, there are special if blocks designed to do the right thing with the column and value. However, they're structured as independent if's when they all test column and so could be if (column == 'xxx') ELSEIF (column == 'YYY') ELSEIF (etc...) Alternatively, most of the column tests could be collapsed into something like... if ($column == "token") OR just put scid, srid, datestamp and startdate into insertarray and remove the tests but I don't really understand the system enough to know what the side effects of putting something in insertarray are. | ||||
Steps To Reproduce | Look at line 803 | ||||
Tags | No tags attached. | ||||
Bug heat | 2 | ||||
Complete LimeSurvey version number (& build) | 8488 | ||||
I will donate to the project if issue is resolved | |||||
Browser | all | ||||
Database type & version | all | ||||
Server OS (if known) | all | ||||
Webserver software & version (if known) | all | ||||
PHP Version | all | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2010-06-07 20:16 | jdalegonzalez | New Issue | |
2010-06-07 20:16 | jdalegonzalez | Status | new => assigned |
2010-06-07 20:16 | jdalegonzalez | Assigned To | => user372 |
2010-06-10 11:27 | c_schmitz | Assigned To | user372 => c_schmitz |
2010-06-16 22:30 | c_schmitz | Note Added: 12234 | |
2010-06-16 22:30 | c_schmitz | Status | assigned => closed |
2010-06-16 22:30 | c_schmitz | Resolution | open => fixed |
2010-06-16 22:30 | c_schmitz | Fixed in Version | => 1.90RC2 |
2010-10-25 00:18 | c_schmitz | Category | Survey at Runtime => Survey taking |