View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
04393Bug reportsOtherpublic2010-06-06 02:542010-06-16 22:22
Reporterjdalegonzalez Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.87+ 
Fixed in Version1.90RC2 
Summary04393: getQuestions in common.php declares globals it never uses.
Description

The first line in getQuestions is global $dbprefix, $scriptname, $connect, $clang;

Of these, only $scriptname is referenced in the function. $dbprefix is declared as a global quite a bit in common.php and almost never used. I have a feeling a new function was created to return the name of a table but the person that created it didn't clean up the global declarations.

Steps To Reproduce

search for global $ in common.php and verify that the variables declared as global are actually used by the functions that declare them.

Additional Information

I doubt it hurts anything to leave the globals in. So, feel free to ignore this bug if you like.

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)8513
I will donate to the project if issue is resolved
BrowserAll
Database type & versionAll
Server OS (if known)All
Webserver software & version (if known)All
PHP VersionAll

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2010-06-16 22:21

administrator   ~12232

Thank you.

Issue History

Date Modified Username Field Change
2010-06-06 02:54 jdalegonzalez New Issue
2010-06-06 02:54 jdalegonzalez Status new => assigned
2010-06-06 02:54 jdalegonzalez Assigned To => user372
2010-06-06 17:02 user372 Assigned To user372 => c_schmitz
2010-06-16 22:21 c_schmitz Note Added: 12232
2010-06-16 22:21 c_schmitz Status assigned => resolved
2010-06-16 22:21 c_schmitz Fixed in Version => 1.90RC2
2010-06-16 22:21 c_schmitz Resolution open => fixed
2010-06-16 22:22 c_schmitz Status resolved => closed