View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
04392Bug reportsOtherpublic2010-06-04 21:462010-06-08 21:51
Reporterjdalegonzalez Assigned Tolemeur  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.87 
Fixed in Version1.90RC1 
Summary04392: limesurvey/admin/html.php forces a second lookup of question type
Description

Around line 1191, html.php calls getQuestionAttributes passing in just the QID. Two things. First, because the question type isn't also passed in, getQuestionAttributes looks up the question type in the DB. This lookup isn't necessary since question type is available in $qrrow['type'] and could be passed to getQuestionAttributes.

Second, $qid_attributes (the variable that stores the return from getQuestionAttributes) isn't ever used. Seems like the entire call to getQuestionAttributes on line 1191 could be dumped.

Steps To Reproduce

Pull up limesurvey/admin/html.php
Scroll down to line 1191 or search for getQuestionAttributes
Verify that type isn't being passed in and the result isn't being used.

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)8516
I will donate to the project if issue is resolved
BrowserAll
Database type & versionAll
Server OS (if known)All
Webserver software & version (if known)All
PHP VersionAll

Users monitoring this issue

There are no users monitoring this issue.

Activities

lemeur

lemeur

2010-06-04 22:14

developer   ~12177

Fixed in rev 8800.
Thanks for the report.

Issue History

Date Modified Username Field Change
2010-06-04 21:46 jdalegonzalez New Issue
2010-06-04 21:46 jdalegonzalez Status new => assigned
2010-06-04 21:46 jdalegonzalez Assigned To => user372
2010-06-04 22:08 lemeur Assigned To user372 => lemeur
2010-06-04 22:14 lemeur Note Added: 12177
2010-06-04 22:14 lemeur Status assigned => resolved
2010-06-04 22:14 lemeur Fixed in Version => 1.90RC1
2010-06-04 22:14 lemeur Resolution open => fixed
2010-06-08 21:51 c_schmitz Status resolved => closed
2010-10-25 00:21 c_schmitz Category Data Access => (No Category)