View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
04048Bug reportsSurvey participants (Tokens)public2010-01-14 22:532010-02-04 18:40
Reporteruser6098Assigned Toharsha  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.87+ 
Fixed in Version1.87+ 
Summary04048: + (plus) character in email not allowed when importing tokens
Description

when importing tokens, email-addresses containing a + (plus) are rejected as invalid addresses. But as of RFC 5322 they are valid.

Example: me+myself@host.de

Additional Information

http://en.wikipedia.org/wiki/E-mail_address#RFC_specification

http://tools.ietf.org/html/rfc5322

TagsNo tags attached.
Attached Files
token-import.patch (876 bytes)    
Index: admin/tokens.php
===================================================================
--- admin/tokens.php	(revision 8326)
+++ admin/tokens.php	(working copy)
@@ -2295,7 +2295,7 @@
 						$invalidemaillist[]=$line[0]." ".$line[1]." (".$line[2].")";
 					}
 
-                    if (!$dupfound)
+                    if (!$dupfound && !$invalidemail)
 					{
 					    if (!isset($writearray['emailstatus']) || $writearray['emailstatus']=='') $writearray['emailstatus'] = "OK";
 					    if (!isset($writearray['token'])) {
@@ -2313,11 +2313,9 @@
 					    if (!$ir)
                         {
                             $duplicatelist[]=$writearray['firstname']." ".$writearray['lastname']." (".$writearray['email'].")";
-                        }
-			else
-			{
-				$xz++;
-			}
+                        } else {
+							$xz++;
+						}
 					}
 					$xv++;
 				}
token-import.patch (876 bytes)   
Bug heat8
Complete LimeSurvey version number (& build)8243
I will donate to the project if issue is resolved
Browser
Database type & versionmysql 5.1
Server OS (if known)Debian 5 x68_64
Webserver software & version (if known)apache 2.2
PHP Versionphp 5.2

Relationships

Relationship GraphDependency Graph
related to 03901 closedharsha validate_email too restrictive 

Users monitoring this issue

harsha

Activities

user6098

2010-01-14 22:54

  ~10781

yes I know that is a stupid bug... but trust me I do have users with a plus in their mail address... ;-)

user6098

2010-01-14 23:19

  ~10782

"Bug" is maybe not a bug... sorry. It's just displayed as invalid but still imported and emails are sent to such addresses. So just only a display issue.
c_schmitz

c_schmitz

2010-01-16 16:21

administrator   ~10802

Well, if an email is marked as invalid it should not be imported.
c_schmitz

c_schmitz

2010-01-25 01:17

administrator   ~10872

Reminder sent to: harsha

Hi!

Why did you un-assign it?
harsha

harsha

2010-01-28 20:53

reporter   ~10925

It is indeed a mistake.. I am sorry about it.
harsha

harsha

2010-01-30 09:01

reporter   ~10937

Should it discard whole record having invalid email or only the email field in the record.
c_schmitz

c_schmitz

2010-01-30 11:27

administrator   ~10938

Discard the whole record.
harsha

harsha

2010-01-30 13:43

reporter   ~10939

ok , patch is attached. Please verify.
harsha

harsha

2010-01-31 14:41

reporter   ~10944

Resolved the issue for importing tokens with invalid email addresses.

Issue History

Date Modified Username Field Change
2010-01-14 22:53 user6098 New Issue
2010-01-14 22:53 user6098 Status new => assigned
2010-01-14 22:53 user6098 Assigned To => user372
2010-01-14 22:53 user6098 LimeSurvey build number => 8243
2010-01-14 22:53 user6098 Database & DB-Version => mysql 5.1
2010-01-14 22:53 user6098 Operating System (Server) => Debian 5 x68_64
2010-01-14 22:53 user6098 Webserver => apache 2.2
2010-01-14 22:53 user6098 PHP Version => php 5.2
2010-01-14 22:54 user6098 Note Added: 10781
2010-01-14 23:19 user6098 Note Added: 10782
2010-01-16 16:18 c_schmitz Assigned To user372 => harsha
2010-01-16 16:19 c_schmitz Relationship added related to 03901
2010-01-16 16:21 c_schmitz Note Added: 10802
2010-01-17 08:18 harsha Assigned To harsha =>
2010-01-25 01:17 c_schmitz Issue Monitored: harsha
2010-01-25 01:17 c_schmitz Note Added: 10872
2010-01-27 23:30 c_schmitz Assigned To => harsha
2010-01-28 20:53 harsha Note Added: 10925
2010-01-30 09:01 harsha Note Added: 10937
2010-01-30 11:27 c_schmitz Note Added: 10938
2010-01-30 13:41 harsha File Added: token-import.patch
2010-01-30 13:43 harsha Note Added: 10939
2010-01-31 14:41 harsha Note Added: 10944
2010-01-31 14:41 harsha Status assigned => resolved
2010-01-31 14:41 harsha Fixed in Version => 1.87+
2010-01-31 14:41 harsha Resolution open => fixed
2010-02-04 18:40 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)
2021-08-03 19:00 guest Bug heat 6 => 8