I can reproduce the issue in correctly that order, but not, when I create a survey with just one group and question - activate that survey - deactivate that survey and add a second question ==> just FYI.

I couldn't reproduce the activate+deactivate behaviour, it happens all the times whenever you want to put some question to the beginning.

"Position: at the beginning" just didn't work in any way because the sort order was wrong at the select box.
If you pay attention to the values on the select box, you can see a suspectable numbering:
At beginning = 0
After first question = also 0?

So something must be wrong with that.

Question order (at the database) begins in 0, so database.php, when inserting a new question that needs reordering makes an update of questions order after the new one but there it was a trick to somehow fix the bad order coming from the select box, it was added 1 to the first question that should be reordered:

$question_order=(sanitize_int($_POST['questionposition'])+1);
$cdquery = "UPDATE ".db_table_name('questions')." SET question_order=question_order+1 WHERE gid=".$postgid." AND question_order >= ".$question_order;

So, IMHO, the better way to fix this is to do the proper ordering when filling the select box (questionhandling.php) and taking out that tricky +1 on database.php.

Revision: 7421