Please attach a simple sample survey (survey structure as .csv-file), where we can reproduce the issue - Thx! Additionally a step-by-sep-instruction how to reproduce the issue would be very nice!

Thx- I can reproduce the issue with your instruction.
@ lemeur: can you have a look at it?

@Carsten,
I've found a bug while investigating this ticket:

• please import the survey
• then click Edit to have the First Survey edit step
• don't change any parameter and try to click the "Save and Continue >" button
  ==> I get the following error:
  Error updating
  Query was empty

Issue is in line 1133 of database.php:
$usquery=$connect->GetUpdateSQL($rs, $updatearray, get_magic_quotes_gpc());

GetUpdateSQL returns FALSE instead of a query.

Thibault: I cannot reproduce that? Are you sue your database is up to date? Can you re-run the 2 latest DB updates by setting DBVersion in settings_global to 134

Still the same pb even after forcing update from DBVersion 134 to 137.

I deleted the survey, re-imported it and still the same pb:

• import survey
• click Go to survey to select the freshly imported one
• click the Edit survey icon
• click the Save and continue button
  => Web page is blank with :
  Error updating
  Query was empty

Carsten, any clue where to track down this issue ?
Do we have to debug adodb ?

Thibault

As long as I don't get my hands on an installation where I can reproduce this I cannot track it down. Sp00ky or lemeur, can you provide access to such an installation (at least FTP access)

???

Thibault, a user in the forum wrote that this only happens if the settings were not changed on the first page - which would make sense since then there needs to be no query.
Can you check again if you get this error still if you do some changes in the first settings page?

If not then the fix is very easy - just don't execute the query if it is empty.

@Carsten: sure this is what I meant by "don't change any parameter and try to click the "Save and Continue >" button"

@Carsten: The issue is not only related to the fact that no parameter was changed because I can't reproduce this issue on other surveys set on the same instalaltion. For the moment only this specific survey causes the pb!!

The query isn't really empty, it is set to FALSE. The arrays given to GetUpdateSQL are not empty either

Hey -- just ran into this on a system of mine. The order of params to
GetUpdateSQL are rs, arrFields, forceUpdate, magicq, force

The way it's being call the return value for get_magic_quotes_gpc determines whether an update is forced or not -- could help explain the reproducing problems seen in 03274 and 03266

I modded my install to: (line 1132)
$usquery=$connect->GetUpdateSQL($rs, $updatearray, 0, get_magic_quotes_gpc());
if($usquery)
$usresult = $connect->Execute($usquery) or safe_die("Error updating<pre>".$usquery."</pre><br /><strong>".$connect->ErrorMsg() . "</strong>");

For a quick fix

Thanks awarren - that is a great fix.

Attached fixed file to this bug.

Looks like I forgot to put this fix actually in there.

Attached fixed file for 1.87+.
Fixed in rev. 8479