View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
19514Bug reportsSurvey takingpublic2024-04-15 11:16
Reportertibor.pacalat Assigned Totibor.pacalat  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version6.5.x 
Summary19514: File Upload - scrolling not possible on mobile
Description

I have tested this on production with my iphone and the issue is that the modal "Upload files" is not scrollable and thus you can not edit comment and title of the second and every next upload, plus the "Save changes" button is not visible.

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)6.5.2+240402
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known)
Webserver software & version (if known)
PHP Version.

Users monitoring this issue

There are no users monitoring this issue.

Activities

tibor.pacalat

tibor.pacalat

2024-04-08 11:37

administrator   ~79876

@DenisChenu can you please fix this as soon as possible? If not maybe @gabrieljenik can take it?

DenisChenu

DenisChenu

2024-04-08 12:16

developer   ~79877

Only on iphone ? If yes : I don't have a way to test …

It's OK on 5.X or 3.X ?

tibor.pacalat

tibor.pacalat

2024-04-08 12:40

administrator   ~79879

This is on any mobile device. I just provided explanation how I tested it. We don't need a fix for older versions.

DenisChenu

DenisChenu

2024-04-08 12:44

developer   ~79880

This is on any mobile device. I just provided explanation how I tested it. We don't need a fix for older versions.

If it broken on Android too : i can check it :)

gabrieljenik

gabrieljenik

2024-04-08 20:39

manager   ~79884

@twillig, May I ask for your help here?

https://github.com/LimeSurvey/LimeSurvey/commit/310aec05e075bd6d7fa7492dd20bcdf496acbf98#diff-bfe479b6903f2c4ab31aab33da24a491d667ccddc269018d282c6c9abf20b755R39

This css definition added seems to be messing with bootstrap default options.
Still, after removing those definitions, situation doesn't get better.

On the other side, std bootstrap classes as .modal-dialog-centered doesn't seem to work.

As you have already been playing around with positioning, do you have any idea what could be going on?

gabrieljenik

gabrieljenik

2024-04-09 19:42

manager   ~79898

https://github.com/LimeSurvey/LimeSurvey/pull/3810
Dialog is scrollable and visible on mobile. Doesn't center it yet on large screens.

guest

guest

2024-04-10 09:23

viewer   ~79899

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36243

guest

guest

2024-04-10 09:23

viewer   ~79900

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36242

LimeBot

LimeBot

2024-04-15 11:16

administrator   ~79920

Fixed in Release 6.5.3+240415

Related Changesets

LimeSurvey: master dbc2b047

2024-04-10 09:23:40

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 19514: File Upload - scrolling not possible on mobile (03810)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
19514
mod - application/views/survey/questions/answer/file_upload/answer.twig Diff File

LimeSurvey: master dbc2b047

2024-04-10 09:23:40

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 19514: File Upload - scrolling not possible on mobile (03810)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
19514
mod - application/views/survey/questions/answer/file_upload/answer.twig Diff File

Issue History

Date Modified Username Field Change
2024-04-08 11:36 tibor.pacalat New Issue
2024-04-08 11:37 tibor.pacalat Note Added: 79876
2024-04-08 11:37 tibor.pacalat Bug heat 0 => 2
2024-04-08 12:16 DenisChenu Note Added: 79877
2024-04-08 12:16 DenisChenu Bug heat 2 => 4
2024-04-08 12:40 tibor.pacalat Note Added: 79879
2024-04-08 12:40 tibor.pacalat Assigned To => gabrieljenik
2024-04-08 12:40 tibor.pacalat Status new => assigned
2024-04-08 12:44 DenisChenu Note Added: 79880
2024-04-08 20:39 gabrieljenik Note Added: 79884
2024-04-08 20:39 gabrieljenik Bug heat 4 => 6
2024-04-09 19:42 gabrieljenik Note Added: 79898
2024-04-09 19:43 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2024-04-09 19:43 gabrieljenik Status assigned => ready for code review
2024-04-10 09:23 Changeset attached => LimeSurvey master dbc2b047
2024-04-10 09:23 Changeset attached => LimeSurvey master dbc2b047
2024-04-10 09:23 guest Note Added: 79899
2024-04-10 09:23 guest Note Added: 79900
2024-04-10 09:23 guest Bug heat 6 => 8
2024-04-10 09:23 guest Bug heat 6 => 8
2024-04-10 10:07 tibor.pacalat Status ready for code review => resolved
2024-04-10 10:07 tibor.pacalat Resolution open => fixed
2024-04-15 11:16 LimeBot Note Added: 79920
2024-04-15 11:16 LimeBot Status resolved => closed
2024-04-15 11:16 LimeBot Bug heat 8 => 10