View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 19231 | Bug reports | Other | public | 2023-11-10 11:41 | 2023-12-04 12:58 |
| Reporter | ollehar | Assigned To | ollehar | ||
| Priority | none | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Summary | 19231: (array) json_decode($j) is not equivalent to json_decode($j, true) | ||||
| Description | Lots of code seems to assume you can recursively cast an object to an array using Question is if it can be fixed without causing any issues. Affected places application/helpers/export_helper.php: $attribute = (array)json_decode((string) $attribute); | ||||
| Tags | No tags attached. | ||||
| Bug heat | 6 | ||||
| Complete LimeSurvey version number (& build) | master | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | - | ||||
| Database type & version | - | ||||
| Server OS (if known) | - | ||||
| Webserver software & version (if known) | - | ||||
| PHP Version | - | ||||
|
Question : why we don't use If we find the reason : we can create test :) |
|
My only guess is that the devs at the time thought it was the same thing. Tests would be really nice, yes... |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35791 |
|
|
Fixed in Release 6.3.8+231204 |
|
|
LimeSurvey: master d7df1782 2023-11-28 18:33 Committer: GitHub Details Diff |
Fixed issue 19231: (array) json_decode() is not equivalent to json_decode(, true) (#3615) |
Affected Issues 19231 |
|
| mod - application/core/LSETwigViewRenderer.php | Diff File | ||
| mod - application/helpers/admin/import_helper.php | Diff File | ||
| mod - application/helpers/export_helper.php | Diff File | ||
| mod - application/models/TemplateConfiguration.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-11-10 11:41 | ollehar | New Issue | |
| 2023-11-10 11:41 | ollehar | Description Updated | |
| 2023-11-10 12:22 | ollehar | Description Updated | |
| 2023-11-10 12:23 | ollehar | Description Updated | |
| 2023-11-10 14:36 | ollehar | Assigned To | => ollehar |
| 2023-11-10 14:36 | ollehar | Status | new => assigned |
| 2023-11-10 14:36 | ollehar | Status | assigned => ready for code review |
| 2023-11-10 15:43 | DenisChenu | Note Added: 78392 | |
| 2023-11-10 15:43 | DenisChenu | Bug heat | 0 => 2 |
| 2023-11-13 18:28 | ollehar | Note Added: 78434 | |
| 2023-11-13 18:28 | ollehar | Bug heat | 2 => 4 |
| 2023-11-28 18:23 | ollehar | Changeset attached | => LimeSurvey master d7df1782 |
| 2023-11-28 18:23 | ollehar | Note Added: 78794 | |
| 2023-11-28 18:23 | ollehar | Resolution | open => fixed |
| 2023-12-04 12:58 | LimeBot | Note Added: 78861 | |
| 2023-12-04 12:58 | LimeBot | Status | ready for code review => closed |
| 2023-12-04 12:58 | LimeBot | Bug heat | 4 => 6 |