View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 2 person(s).
 16
IDProjectCategoryView StatusDate SubmittedLast Update
19177Bug reportsTheme editorpublic2023-10-17 14:182023-10-30 14:00
ReporterOMdev Assigned Tomfavetti  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version6.2.x 
Summary19177: no able to change admin theme
Description

We are not able to select change admin theme. The default one [Sea Green] always remains selected.

Steps To Reproduce

Steps to reproduce

Make Copy to of [Sea Green] admin template. Try to select it. It wont get selected.

Expected result

Should be able to change theme.

Actual result

Default remains selected.

TagsNo tags attached.
Attached Files
Animation.gif (47,560 bytes)   
Animation.gif (47,560 bytes)   
Bug heat16
Complete LimeSurvey version number (& build)Community Edition Version 6.2.9+230925
I will donate to the project if issue is resolvedNo
Browser
Database type & versionNA
Server OS (if known)
Webserver software & version (if known)
PHP VersionNA

Users monitoring this issue

mfavetti

Activities

Mazi

Mazi

2023-10-17 22:34

updater   ~77760

@tibor.pacalat, we are facing the same issue. If you just copy an admin theme and upload it, it can not be select at the interface. It always keeps the default one.
mfavetti

mfavetti

2023-10-17 22:59

developer   ~77762

I see the same behavior. I'll take a look.
mfavetti

mfavetti

2023-10-17 23:41

developer   ~77763

okay theme options was sending the path of the theme instead of the name, the admintheme class checks for a valid theme on instantiation and resets to Sea_Green if the theme is invalid. It checks the name and since the name is the path, it is invalid. global settings admin theme selector works fine.

https://github.com/LimeSurvey/LimeSurvey/pull/3548
mfavetti

mfavetti

2023-10-17 23:46

developer   ~77764

by the way if you go to global settings and change the admin theme there, that works right now. so you can use that as a workaround until this makes it into a release
DenisChenu

DenisChenu

2023-10-23 11:46

developer   ~77862

We have same issue for plugin for example : you need to update Plugin name + file + name in config etc …
What is updated in theme currently ?

The fix is OK : it's needed like that.
DenisChenu

DenisChenu

2023-10-23 11:48

developer   ~77864

Why it show 'Core admin theme' on Animation ?

More detail on way to reproduce please
mfavetti

mfavetti

2023-10-24 18:27

developer   ~77941

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35663
LimeBot

LimeBot

2023-10-30 14:00

administrator   ~78137

Fixed in Release 6.3.2+231031

Related Changesets

LimeSurvey: master ecd54534

2023-10-24 20:07

mfavetti

Committer: GitHub


Details Diff		 Fixed issue 19177: no able to change admin theme (03548)

Co-authored-by: Matthew Favetti <mpfavetti@ucdavis.edu>		 Affected Issues
19177
mod - application/views/themeOptions/index.php Diff File

Issue History

Date Modified Username Field Change
2023-10-17 14:18 OMdev New Issue
2023-10-17 14:18 OMdev File Added: Animation.gif
2023-10-17 22:32 Mazi Bug heat 0 => 6
2023-10-17 22:34 Mazi Note Added: 77760
2023-10-17 22:34 Mazi Bug heat 6 => 8
2023-10-17 22:59 mfavetti Note Added: 77762
2023-10-17 22:59 mfavetti Bug heat 8 => 10
2023-10-17 22:59 mfavetti Assigned To => mfavetti
2023-10-17 22:59 mfavetti Status new => assigned
2023-10-17 23:41 mfavetti Note Added: 77763
2023-10-17 23:46 mfavetti Note Added: 77764
2023-10-17 23:46 mfavetti Issue Monitored: mfavetti
2023-10-17 23:46 mfavetti Bug heat 10 => 12
2023-10-18 00:35 mfavetti Status assigned => ready for code review
2023-10-18 00:39 mfavetti Status ready for code review => assigned
2023-10-20 21:51 mfavetti Assigned To mfavetti =>
2023-10-20 21:54 mfavetti Assigned To => mfavetti
2023-10-20 21:54 mfavetti Status assigned => ready for code review
2023-10-20 21:54 mfavetti Assigned To mfavetti =>
2023-10-20 22:07 mfavetti Assigned To => DenisChenu
2023-10-23 11:46 DenisChenu Note Added: 77862
2023-10-23 11:46 DenisChenu Bug heat 12 => 14
2023-10-23 11:47 DenisChenu Assigned To DenisChenu => tibor.pacalat
2023-10-23 11:47 DenisChenu Status ready for code review => ready for testing
2023-10-23 11:48 DenisChenu Note Added: 77864
2023-10-24 18:07 tibor.pacalat Status ready for testing => resolved
2023-10-24 18:07 tibor.pacalat Resolution open => fixed
2023-10-24 18:27 mfavetti Changeset attached => LimeSurvey master ecd54534
2023-10-24 18:27 mfavetti Note Added: 77941
2023-10-24 18:27 mfavetti Assigned To tibor.pacalat => mfavetti
2023-10-30 14:00 LimeBot Note Added: 78137
2023-10-30 14:00 LimeBot Status resolved => closed
2023-10-30 14:00 LimeBot Bug heat 14 => 16