View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
19149Bug reportsUsability/user experiencepublic2024-02-22 11:31
Reporterak125199 Assigned Tomfavetti  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version6.2.x 
Summary19149: fruity_23: can't change language (languages are not displayed) in nagvigation bar (three dots) in survey list
Description

in Fruity TwentyThree theme only one language is displayed (although all languages are loaded in html ul).
we figured out, that views/subviews/navigation/language_changer_top_menu.twig has to deal with it and made a workaround:

{# There is many condition where the language changer should not be shown. Eg: there is only one language available #}
{% if aSurveyInfo.alanguageChanger.show == true %}

{# we set a shortcut for aSurveyInfo.alanguageChangerDatas #}
{% set aLCD  = aSurveyInfo.alanguageChanger.datas %}

<!-- Language Changer, top menu version -->
&lt;li class=&quot;dropdown-header text-uppercase&quot;>{{ gT(&quot;Select language&quot;) }}</li>
{% for value, lang in aLCD.aListLang %}
    &lt;li class=&quot;index-item&quot;>
        &lt;a href='#' data-limesurvey-lang='{{ value }}' class=&quot;dropdown-item ls-language-link&quot;>
            {{ lang }}
        &lt;/a>
    </li>
{% endfor %}

{# <li class="ls-no-js-hidden form-change-lang dropdown nav-item">#}
{# <a class="nav-link dropdown-toggle" role="button" data-bs-toggle="dropdownCustom"#}
{# data-bs-target="#language-dropdown" data-navtargetid="language-dropdown">#}
{# #}{# NOTE: {{gT( aLCD.aListLang[aLCD.sSelected] )}}: retreives the language name of the selected language and translates it #}
{# {{ aLCD.aListLang[aLCD.sSelected] }}#}

{# </a>#}
{# <ul class="dropdown-menu dropdown-menu-end" id="language-dropdown">#}
{# {{ include('./subviews/navigation/back.twig') }}#}
{# #}{# List of available languages. #}
{# {% for value, lang in aLCD.aListLang %}#}
{# <li class="index-item">#}
{# <a href='#' data-limesurvey-lang='{{ value }}' class="dropdown-item ls-language-link">#}
{# {{ lang }}#}
{# </a>#}
{# </li>#}
{# {% endfor %}#}
{# </ul>#}
{# </li>#}
{% endif %}

{{ registerScript("BasicThemeScripts-TopLanguageChanger", "basicThemeScripts.initTopMenuLanguageChanger('.ls-language-link ', 'form#limesurvey'); ", "POS_POSTSCRIPT") }}

Steps To Reproduce

Steps to reproduce

choose or extend and activate Fruity TwentyThree theme and go to the index/main site and click on the three dots

Expected result

all languages should be displayed

Actual result

only one language (the first one) is visible

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)6.2.9
I will donate to the project if issue is resolvedNo
Browser
Database type & versionpsql 14
Server OS (if known)rocky 9.2
Webserver software & version (if known)apache 2.4
PHP Versionphp 8.1

Users monitoring this issue

mfavetti

Activities

tibor.pacalat

tibor.pacalat

2023-10-20 12:00

administrator   ~77803

On the public survey list page you can't change the language even if there are surveys that have multiple languages.

ak125199

ak125199

2023-10-20 15:02

reporter   ~77810

is this behaviour a bug or a feature? is there a reason for that?

tibor.pacalat

tibor.pacalat

2023-10-20 15:21

administrator   ~77812

This is a bug, I just provided screenshots, so that it is easier to see where the issue exists.

ak125199

ak125199

2023-11-02 06:44

reporter   ~78203

ah thanks, will this be solved soon? thanks a lot!

mfavetti

mfavetti

2023-11-18 10:40

developer   ~78521

@ak125199

i made pr, as soon as its code reviewed, tested, and merged it will make it into the next release. it's a simple change if you need to get it working before the fix makes it into a release, just look at the pr and make the same change on your install

ak125199

ak125199

2023-11-18 15:40

reporter   ~78522

@https://bugs.limesurvey.org/view_user_page.php?id=32352
thanks! we did it already with above code. But will of course better, if the fix makes it into a release...

Thanks a lot!

tibor.pacalat

tibor.pacalat

2023-11-20 13:46

administrator   ~78537

@mfavetti the dropdown should be scrollable and probably have some reasonable height, currently you don't see all the languages.

mfavetti

mfavetti

2023-11-20 20:28

developer   ~78553

yeah I made an issue here with the fix https://bugs.limesurvey.org/view.php?id=19250

mfavetti

mfavetti

2023-11-22 09:27

developer   ~78618

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=35767

Related Changesets

LimeSurvey: master 2e74c7ae

2023-11-22 09:23:30

mfavetti


Committer: GitHub Details Diff
Fixes issue 19149: fruity_23: can't change language (languages are not displayed) in nagvigation bar (three dots) in survey list (#3626) Affected Issues
19149
mod - themes/survey/fruity_twentythree/views/layout_survey_list.twig Diff File

Issue History

Date Modified Username Field Change
2023-10-03 11:38 ak125199 New Issue
2023-10-20 12:00 tibor.pacalat Note Added: 77803
2023-10-20 12:00 tibor.pacalat File Added: Screenshot 2023-10-20 at 11.58.46.png
2023-10-20 12:00 tibor.pacalat File Added: Screenshot 2023-10-20 at 11.54.18.png
2023-10-20 12:00 tibor.pacalat Bug heat 0 => 2
2023-10-20 12:00 tibor.pacalat Assigned To => tibor.pacalat
2023-10-20 12:00 tibor.pacalat Status new => confirmed
2023-10-20 15:02 ak125199 Note Added: 77810
2023-10-20 15:02 ak125199 Bug heat 2 => 4
2023-10-20 15:21 tibor.pacalat Note Added: 77812
2023-10-23 11:48 tibor.pacalat Assigned To tibor.pacalat =>
2023-11-02 06:44 ak125199 Note Added: 78203
2023-11-18 08:09 mfavetti Assigned To => mfavetti
2023-11-18 08:09 mfavetti Status confirmed => assigned
2023-11-18 08:13 mfavetti Issue Monitored: mfavetti
2023-11-18 08:13 mfavetti Bug heat 4 => 6
2023-11-18 08:13 mfavetti Assigned To mfavetti => DenisChenu
2023-11-18 08:13 mfavetti Status assigned => ready for code review
2023-11-18 10:20 DenisChenu Assigned To DenisChenu => tibor.pacalat
2023-11-18 10:20 DenisChenu Status ready for code review => ready for testing
2023-11-18 10:40 mfavetti Note Added: 78521
2023-11-18 10:40 mfavetti Bug heat 6 => 8
2023-11-18 15:40 ak125199 Note Added: 78522
2023-11-20 13:46 tibor.pacalat Note Added: 78537
2023-11-20 13:46 tibor.pacalat File Added: Screenshot 2023-11-20 at 13.44.45.png
2023-11-20 20:28 mfavetti Note Added: 78553
2023-11-22 09:24 tibor.pacalat Status ready for testing => resolved
2023-11-22 09:24 tibor.pacalat Resolution open => fixed
2023-11-22 09:27 mfavetti Changeset attached => LimeSurvey master 2e74c7ae
2023-11-22 09:27 mfavetti Note Added: 78618
2023-11-22 09:27 mfavetti Assigned To tibor.pacalat => mfavetti
2024-02-22 11:31 mfavetti Status resolved => closed