19056: save button in create dummy participants page actually saves and closes

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

19056	Bug reports	Survey participants (Tokens)	public	2023-08-29 09:47	2023-09-18 09:10

Reporter	ritapas	Assigned To	tibor.pacalat
Priority	none	Severity	trivial
Status	closed	Resolution	fixed
Product Version	5.6.x

Summary	19056: save button in create dummy participants page actually saves and closes
Description	in create dummy participants page, there are both the save button and the save and close button. However, they do the same thing (save and close).
Steps To Reproduce	Steps to reproduce inside a closed survey, go to create dummy participants. Fill the fields in order to get at least one. Press "save" and not save and close. Expected result participant is created and edit participant form stays in place Actual result the same as "save and close"
Tags	No tags attached.

Bug heat	10
Complete LimeSurvey version number (& build)	5.6.33 (build 230808)
I will donate to the project if issue is resolved	No
Browser
Database type & version	n/a
Server OS (if known)
Webserver software & version (if known)
PHP Version	n/a

User List	There are no users monitoring this issue.

gabrieljenik 2023-09-06 17:21 manager ~76893	Master: https://github.com/LimeSurvey/LimeSurvey/pull/3426 Removed the save button. Useless and confusing

DenisChenu 2023-09-07 16:54 developer ~76902	Maybe we can rename Save and close as «Create» ? More clear for user

DenisChenu 2023-09-07 16:57 developer ~76903	Fix is OK, Did we need an UX issue about "Create particpants" rename button ?

gabrieljenik 2023-09-07 17:47 manager ~76904 Last edited: 2023-09-07 17:48	I would tackle that on a different ticket. Buttons are named like that for consistency

guest 2023-09-13 13:31 viewer ~76978	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35459

guest 2023-09-13 13:31 viewer ~76979	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35460

tibor.pacalat 2023-09-13 13:32 administrator ~76980	Tested and merged, "Save" button was removed from view. "Save and Close" button remained and is functional.

LimeBot 2023-09-18 09:10 administrator ~77088	Fixed in Release 6.2.7+230918

LimeSurvey: master 33bf513c 2023-09-13 15:31 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 19056: save button in create dummy participants page actually saves and closes (#3426) Co-authored-by: Lapiu Dev <devgit@lapiu.biz>	Affected Issues 19056
	mod - application/controllers/admin/Tokens.php	Diff File
LimeSurvey: master 33bf513c 2023-09-13 15:31 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 19056: save button in create dummy participants page actually saves and closes (#3426) Co-authored-by: Lapiu Dev <devgit@lapiu.biz>	Affected Issues 19056
	mod - application/controllers/admin/Tokens.php	Diff File

Date Modified	Username	Field	Change
2023-08-29 09:47	ritapas	New Issue
2023-08-29 21:07	gabrieljenik	Assigned To	=> gabrieljenik
2023-08-29 21:07	gabrieljenik	Status	new => assigned
2023-09-06 17:21	gabrieljenik	Assigned To	gabrieljenik => DenisChenu
2023-09-06 17:21	gabrieljenik	Status	assigned => ready for code review
2023-09-06 17:21	gabrieljenik	Note Added: 76893
2023-09-06 17:21	gabrieljenik	Bug heat	0 => 2
2023-09-07 16:54	DenisChenu	Note Added: 76902
2023-09-07 16:54	DenisChenu	Bug heat	2 => 4
2023-09-07 16:57	DenisChenu	Assigned To	DenisChenu => gabrieljenik
2023-09-07 16:57	DenisChenu	Status	ready for code review => in code review
2023-09-07 16:57	DenisChenu	Note Added: 76903
2023-09-07 17:47	gabrieljenik	Note Added: 76904
2023-09-07 17:48	gabrieljenik	Note Edited: 76904
2023-09-11 15:27	gabrieljenik	Assigned To	gabrieljenik => tibor.pacalat
2023-09-11 15:27	gabrieljenik	Status	in code review => ready for merge
2023-09-13 13:31		Changeset attached	=> LimeSurvey master 33bf513c
2023-09-13 13:31		Changeset attached	=> LimeSurvey master 33bf513c
2023-09-13 13:31	guest	Note Added: 76978
2023-09-13 13:31	guest	Note Added: 76979
2023-09-13 13:31	guest	Bug heat	4 => 6
2023-09-13 13:31	guest	Bug heat	4 => 6
2023-09-13 13:32	tibor.pacalat	Status	ready for merge => resolved
2023-09-13 13:32	tibor.pacalat	Resolution	open => fixed
2023-09-13 13:32	tibor.pacalat	Note Added: 76980
2023-09-13 13:32	tibor.pacalat	Bug heat	6 => 8
2023-09-18 09:10	LimeBot	Note Added: 77088
2023-09-18 09:10	LimeBot	Status	resolved => closed
2023-09-18 09:10	LimeBot	Bug heat	8 => 10