View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18949 | Bug reports | Response browsing | public | 2023-07-11 12:13 | 2023-08-14 09:30 |
Reporter | SESSOU | Assigned To | tibor.pacalat | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.6.x | ||||
Summary | 18949: Responses filters are case sensitive | ||||
Description | Responses filters are case sensitive Using the same approach as bug 11574 seems to work but I'm not sure it does not have other implications : In file application/models/SurveyDynamic.php replace $criteria = new CDbCriteria(); by $criteria = new LSDbCriteria(); | ||||
Steps To Reproduce | Steps to reproduceGo to responses Expected resultShow responses containing "Anabel" Actual resultReturns nothing | ||||
Tags | No tags attached. | ||||
Bug heat | 10 | ||||
Complete LimeSurvey version number (& build) | 5.6.30+230711 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Firefox 102.12.0esr | ||||
Database type & version | PostgreSQL 13.11 | ||||
Server OS (if known) | Debian 11 | ||||
Webserver software & version (if known) | Apache 2.4.56 | ||||
PHP Version | 7.4.33 | ||||
Have to apply to : Token + Theme + etc … : need new issue reported
|
|
Token seems OK. Still, from a code search these models pop up:
BTW: On mysql case insensitve works fine due to the collation (ex: utf8_general_ci), right? |
|
It's about escaping https://github.com/yiisoft/yii/issues/4512 For the other: mus check real utility :) |
|
Got lost. What is about escaping? What I meant was that the LSDBCriteria implements case insensitive for pgsql.
I would just do a replacement on those files on DEV branch. |
|
Sorry : MSSQL here (not MySQL) else it's about compare function (with escaping ) public function compare($column, $value, $partialMatch = false, $operator = 'AND', $escape = true) |
|
What I mean about mysql is,
Initially it was a question. But now I have already answered myself :) |
|
Yes,
I din't understand it was a question … sorry. |
|
Tested ok on mysql |
|
Master PR: https://github.com/LimeSurvey/LimeSurvey/pull/3339 |
|
Master PR test ok on mysql |
|
I tested both successfully with Postgres database as well. |
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35331 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35333 |
|
Fixed in Release 6.2.2+230814 |
|
LimeSurvey: 5.x 408b856b 2023-08-09 15:52 Gabriel Jenik Committer: GitHub Details Diff |
Fixed issue 18949: Responses filters are case sensitive (#3311) Co-authored-by: lapiudevgit <devgit@lapiu.biz> |
Affected Issues 18949 |
|
mod - application/models/SurveyDynamic.php | Diff File | ||
LimeSurvey: master 6ac5d05f 2023-08-09 15:52 Gabriel Jenik Committer: GitHub Details Diff |
Fixed issue 18949: Responses filters are case sensitive (#3339) Co-authored-by: lapiudevgit <devgit@lapiu.biz> |
Affected Issues 18949 |
|
mod - application/models/SurveyDynamic.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-07-11 12:13 | SESSOU | New Issue | |
2023-07-13 23:46 | gabrieljenik | Assigned To | => gabrieljenik |
2023-07-13 23:46 | gabrieljenik | Status | new => assigned |
2023-07-26 19:01 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2023-07-26 19:01 | gabrieljenik | Status | assigned => ready for code review |
2023-07-26 19:01 | gabrieljenik | Note Added: 76284 | |
2023-07-26 19:01 | gabrieljenik | Bug heat | 0 => 2 |
2023-07-27 07:42 | DenisChenu | Note Added: 76288 | |
2023-07-27 07:42 | DenisChenu | Bug heat | 2 => 4 |
2023-07-27 07:42 | DenisChenu | Assigned To | DenisChenu => |
2023-07-27 07:42 | DenisChenu | Status | ready for code review => ready for testing |
2023-07-27 14:41 | gabrieljenik | Note Edited: 76284 | |
2023-07-27 14:55 | gabrieljenik | Note Added: 76297 | |
2023-07-27 14:55 | gabrieljenik | Assigned To | => tibor.pacalat |
2023-07-27 15:25 | DenisChenu | Note Added: 76301 | |
2023-07-27 15:26 | DenisChenu | Note Edited: 76301 | |
2023-07-27 15:47 | gabrieljenik | Note Added: 76305 | |
2023-07-27 17:09 | DenisChenu | Note Added: 76309 | |
2023-07-27 19:27 | gabrieljenik | Note Added: 76317 | |
2023-07-28 07:54 | DenisChenu | Note Added: 76319 | |
2023-08-03 23:30 | gabrieljenik | Status | ready for testing => ready for merge |
2023-08-03 23:30 | gabrieljenik | Note Added: 76423 | |
2023-08-03 23:32 | gabrieljenik | Note Edited: 76423 | |
2023-08-03 23:32 | gabrieljenik | Status | ready for merge => in testing |
2023-08-07 22:24 | gabrieljenik | Note Added: 76469 | |
2023-08-08 14:13 | gabrieljenik | Note Added: 76489 | |
2023-08-09 13:51 | tibor.pacalat | Note Added: 76502 | |
2023-08-09 13:51 | tibor.pacalat | Bug heat | 4 => 6 |
2023-08-09 13:52 | Changeset attached | => LimeSurvey 5.x 408b856b | |
2023-08-09 13:52 | guest | Note Added: 76503 | |
2023-08-09 13:52 | guest | Bug heat | 6 => 8 |
2023-08-09 13:52 | tibor.pacalat | Status | in testing => resolved |
2023-08-09 13:52 | tibor.pacalat | Resolution | open => fixed |
2023-08-09 14:20 | Changeset attached | => LimeSurvey master 6ac5d05f | |
2023-08-09 14:20 | guest | Note Added: 76512 | |
2023-08-14 09:30 | LimeBot | Note Added: 76555 | |
2023-08-14 09:30 | LimeBot | Status | resolved => closed |
2023-08-14 09:30 | LimeBot | Bug heat | 8 => 10 |