View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 24
IDProjectCategoryView StatusDate SubmittedLast Update
18814Bug reportsStatisticspublic2023-05-11 22:112024-03-10 15:40
Reportergabrieljenik Assigned Totibor.pacalat  
PrioritynoneSeveritycrash 
Status closedResolutionreopened 
Product Version6.0.x 
Summary18814: Array question statistics fail for Remote Control
Description

Using the export statistics in a survey with a single question of type array I get the following error:

Caught while reviewing 18798

ls\tests\RemoteControlExportStatisticsTest::testSurveyWithArrayQuestions
CException: Property "Response_669138.669138X1X12" is not defined.
/var/www/html/limesurvey/vendor/yiisoft/yii/framework/base/CComponent.php:130
/var/www/html/limesurvey/vendor/yiisoft/yii/framework/db/ar/CActiveRecord.php:145
/var/www/html/limesurvey/application/helpers/admin/statistics_helper.php:2356
/var/www/html/limesurvey/application/helpers/admin/statistics_helper.php:4046
/var/www/html/limesurvey/application/helpers/remotecontrol/remotecontrol_handle.php:615
/var/www/html/limesurvey/tests/unit/helpers/remotecontrol/ExportStatisticsTest.php:212
Steps To Reproduce

Run stats through RC using a survey with a single question of type array.

TagsNo tags attached.
Bug heat24
Complete LimeSurvey version number (& build)master
I will donate to the project if issue is resolvedNo
Browser-
Database type & version-
Server OS (if known)-
Webserver software & version (if known)-
PHP Version-

Relationships

Relationship GraphDependency Graph
related to 18798 closedollehar Out-of-memory problem in statistics export 
related to 18014 acknowledged Label list is cut off unnecessarily 
has duplicate 18368 closedtibor.pacalat export_statistics from API Yields error 

Users monitoring this issue

mikerogerz

Activities

tibor.pacalat

tibor.pacalat

2023-05-15 15:34

administrator   ~74974

Can you send a survey file with which I can reproduce this?
gabrieljenik

gabrieljenik

2023-05-15 18:23

manager   ~74988

Fix: https://github.com/LimeSurvey/LimeSurvey/commit/3fb81e51289b6ce90cd2d3749bcc62b2bbf699b5

It is part of this branch holding tests and the bug fix
https://github.com/LimeSurvey/LimeSurvey/tree/dev/rc_export_statistics_array_questions_tests

Can you send a survey file with which I can reproduce this?

https://github.com/LimeSurvey/LimeSurvey/commit/452551526838f1399980de9766b24ae3bae1320d#diff-7196ee086513f130206406511601d8b12835fb7b2d5f72de274ee62d4aa98b43
gabrieljenik

gabrieljenik

2023-05-15 18:25

manager   ~74989

This shall be merged within the merger of the 18798 tests
guest

guest

2023-05-17 11:14

viewer   ~75019

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34679
guest

guest

2023-05-17 11:14

viewer   ~75020

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34678
LimeBot

LimeBot

2023-05-22 12:06

administrator   ~75133

Fixed in Release 5.6.22+230523
guest

guest

2023-06-02 17:42

viewer   ~75402

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34770
ollehar

ollehar

2023-06-05 11:11

administrator   ~75413

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34773
ollehar

ollehar

2023-06-05 11:38

administrator   ~75416

Reverted this because CI was red. Didn't investigate why, it might have been another PR too (18808).
gabrieljenik

gabrieljenik

2023-06-05 14:51

manager   ~75419

New PR: https://github.com/LimeSurvey/LimeSurvey/pull/3191
(prior was merged and then reverted, so need a new one)
DenisChenu

DenisChenu

2023-06-06 16:46

developer   ~75444

All green => merge ?
tibor.pacalat

tibor.pacalat

2023-06-06 18:13

administrator   ~75455

merged
guest

guest

2023-06-06 18:29

viewer   ~75456

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34785

Related Changesets

LimeSurvey: 5.x fdc7abab

2023-05-17 13:12

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18814: Array question statistics fail for Remote Control. (#3141)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18814
mod - application/helpers/common_helper.php Diff File
add - tests/data/surveys/survey_statistics_one.lsa Diff File
add - tests/data/surveys/survey_statistics_three.lsa Diff File
add - tests/data/surveys/survey_statistics_two.lsa Diff File
add - tests/unit/helpers/remotecontrol/ExportStatisticsArrayQuestionsTest.php Diff File
add - tests/unit/helpers/remotecontrol/ExportStatisticsTest.php Diff File

LimeSurvey: 5.x fdc7abab

2023-05-17 13:12

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18814: Array question statistics fail for Remote Control. (#3141)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18814
mod - application/helpers/common_helper.php Diff File
add - tests/data/surveys/survey_statistics_one.lsa Diff File
add - tests/data/surveys/survey_statistics_three.lsa Diff File
add - tests/data/surveys/survey_statistics_two.lsa Diff File
add - tests/unit/helpers/remotecontrol/ExportStatisticsArrayQuestionsTest.php Diff File
add - tests/unit/helpers/remotecontrol/ExportStatisticsTest.php Diff File

LimeSurvey: master f148781e

2023-06-02 19:28

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18814: Array question statistics fail for Remote Control. (#3165)

* Dev: Remote Control export statistics tests.

Tests added for surveys with one single question and with multiple questions.

* Dev: Remote Control export statistics tests.

Asserts added to cope with error.

* Dev: Remote Control export statistics tests.

Echo added to check the html string returned by export statistics.

* Dev: Remote Control export statistics tests.

Statistics tables are now fetched depending on the question id.

* Dev: Remote Control export statistics wit array questions tests.

Tests added for surveys with array questions.

* Fixed issue 18814: Array question statistics fail for Remote Control.

Bug fixed.

* Dev: Remote Control export statistics wit array questions tests.

Asserts for specific questions added.

* Dev: Remote Control export statistics wit array questions tests.

Undefined variable bug fixed.

---------

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18814
mod - application/helpers/common_helper.php Diff File
add - tests/data/surveys/survey_statistics_three.lsa Diff File
add - tests/unit/helpers/remotecontrol/ExportStatisticsArrayQuestionsTest.php Diff File

LimeSurvey: master 582fade0

2023-06-05 13:10

ollehar


Details Diff		 Revert "Fixed issue 18814: Array question statistics fail for Remote Control. (#3165)"

This reverts commit f148781ec57fd1a02e5faa26a7465d78c9ab5dfe.		 Affected Issues
18814
mod - application/helpers/common_helper.php Diff File
rm - tests/data/surveys/survey_statistics_three.lsa Diff
rm - tests/unit/helpers/remotecontrol/ExportStatisticsArrayQuestionsTest.php Diff

LimeSurvey: master a5e20dcb

2023-06-06 20:13

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18814: Array question statistics fail for Remote Control (#3191)

* Dev: Remote Control export statistics tests.

Tests added for surveys with one single question and with multiple questions.

* Dev: Remote Control export statistics tests.

Asserts added to cope with error.

* Dev: Remote Control export statistics tests.

Echo added to check the html string returned by export statistics.

* Dev: Remote Control export statistics tests.

Statistics tables are now fetched depending on the question id.

* Dev: Remote Control export statistics wit array questions tests.

Tests added for surveys with array questions.

* Fixed issue 18814: Array question statistics fail for Remote Control.

Bug fixed.

* Dev: Remote Control export statistics wit array questions tests.

Asserts for specific questions added.

* Dev: Remote Control export statistics wit array questions tests.

Undefined variable bug fixed.

---------

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18814
mod - application/helpers/common_helper.php Diff File
add - tests/data/surveys/survey_statistics_three.lsa Diff File
add - tests/unit/helpers/remotecontrol/ExportStatisticsArrayQuestionsTest.php Diff File

Issue History

Date Modified Username Field Change
2023-05-11 22:11 gabrieljenik New Issue
2023-05-11 22:11 gabrieljenik Issue generated from: 18798
2023-05-11 22:11 gabrieljenik Relationship added related to 18798
2023-05-15 15:34 tibor.pacalat Note Added: 74974
2023-05-15 15:34 tibor.pacalat Bug heat 0 => 2
2023-05-15 18:23 gabrieljenik Note Added: 74988
2023-05-15 18:23 gabrieljenik Bug heat 2 => 4
2023-05-15 18:24 gabrieljenik Assigned To => gabrieljenik
2023-05-15 18:24 gabrieljenik Status new => assigned
2023-05-15 18:25 gabrieljenik Note Added: 74989
2023-05-17 11:14 Changeset attached => LimeSurvey 5.x fdc7abab
2023-05-17 11:14 Changeset attached => LimeSurvey 5.x fdc7abab
2023-05-17 11:14 guest Note Added: 75019
2023-05-17 11:14 guest Note Added: 75020
2023-05-17 11:14 guest Bug heat 4 => 6
2023-05-17 11:14 guest Bug heat 4 => 6
2023-05-17 23:18 gabrieljenik Assigned To gabrieljenik => ollehar
2023-05-17 23:18 gabrieljenik Status assigned => ready for merge
2023-05-22 12:06 LimeBot Note Added: 75133
2023-05-22 12:06 LimeBot Status ready for merge => closed
2023-05-22 12:06 LimeBot Resolution open => fixed
2023-05-22 12:06 LimeBot Bug heat 6 => 8
2023-05-22 23:15 gabrieljenik Relationship added related to 18014
2023-05-23 15:59 gabrieljenik Relationship added has duplicate 18368
2023-05-23 15:59 gabrieljenik Bug heat 8 => 18
2023-06-02 17:42 Changeset attached => LimeSurvey master f148781e
2023-06-02 17:42 guest Note Added: 75402
2023-06-05 11:11 ollehar Changeset attached => LimeSurvey master 582fade0
2023-06-05 11:11 ollehar Note Added: 75413
2023-06-05 11:11 ollehar Bug heat 18 => 20
2023-06-05 11:38 ollehar Note Added: 75416
2023-06-05 11:39 ollehar Status closed => new
2023-06-05 11:39 ollehar Resolution fixed => reopened
2023-06-05 14:51 gabrieljenik Assigned To ollehar => DenisChenu
2023-06-05 14:51 gabrieljenik Status new => ready for code review
2023-06-05 14:51 gabrieljenik Note Added: 75419
2023-06-06 16:46 DenisChenu Note Added: 75444
2023-06-06 16:46 DenisChenu Bug heat 20 => 22
2023-06-06 16:46 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-06-06 16:46 DenisChenu Status ready for code review => ready for merge
2023-06-06 16:55 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-06-06 18:13 tibor.pacalat Status ready for merge => closed
2023-06-06 18:13 tibor.pacalat Note Added: 75455
2023-06-06 18:29 Changeset attached => LimeSurvey master a5e20dcb
2023-06-06 18:29 guest Note Added: 75456
2024-03-10 15:40 mikerogerz Issue Monitored: mikerogerz
2024-03-10 15:40 mikerogerz Bug heat 22 => 24