View Issue Details

This bug affects 1 person(s).
 16
IDProjectCategoryView StatusLast Update
18776Bug reportsSurvey editingpublic2023-10-17 22:31
Reporterasshank Assigned Tomfavetti  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version6.0.x 
Summary18776: Question ordering not correct
Description

The question ordering in the [structure] pane is incorrect.
If you reorder the questions in this pane,it gets saved in the database.
If you reorder via the menu-optie [questions and groups reordering], the [structure pane] is not updated correctly.

Steps To Reproduce

See attachment

TagsNo tags attached.
Attached Files
2023-04-21_13h09_08.png (63,862 bytes)   
2023-04-21_13h09_08.png (63,862 bytes)   
Bug heat16
Complete LimeSurvey version number (& build)6.0.2+230417
I will donate to the project if issue is resolvedNo
BrowserEdge
Database type & versionmariadb 10.6.12
Server OS (if known)Ubuntu 22.04.2 LTS
Webserver software & version (if known)apache
PHP Version8.2.5

Relationships

related to 19140 closedmfavetti Problem with viewing LimeSurvey notifications 

Users monitoring this issue

duvemyster, mfavetti

Activities

p_teichmann

p_teichmann

2023-04-24 10:17

administrator   ~74592

Hello,

we couldn't reproduce this issue, could you provide steps on how to reproduce this?

asshank

asshank

2023-04-24 11:08

reporter   ~74598

Thanks for looking into this.
I created a new survey, see attachment, and added a couple of questions.
click on [settings,reordering questions and groups]
click on [structure] to make the group and questions visible.
rearrange the questions in the right pane (so in [reordering questions and groups]) and save

The question-order in both panes are not in sync anymore, even after clicking on other menu-items or screenrefresh.
Closing the survey and opening another one and return to this survey doesn't fix this issue.
Strange, because as far as I know the datastructure, question-ordering is sonly tored in one field in the database (lime_questions.question_order)

limesurvey_survey_945363.lss (35,737 bytes)   
<?xml version="1.0" encoding="UTF-8"?>
<document>
 <LimeSurveyDocType>Survey</LimeSurveyDocType>
 <DBVersion>499</DBVersion>
 <languages>
  <language>nl</language>
 </languages>
 <groups>
  <fields>
   <fieldname>gid</fieldname>
   <fieldname>sid</fieldname>
   <fieldname>group_order</fieldname>
   <fieldname>randomization_group</fieldname>
   <fieldname>grelevance</fieldname>
  </fields>
  <rows>
   <row>
    <gid><![CDATA[297]]></gid>
    <sid><![CDATA[945363]]></sid>
    <group_order><![CDATA[1]]></group_order>
    <randomization_group/>
    <grelevance><![CDATA[1]]></grelevance>
   </row>
  </rows>
 </groups>
 <group_l10ns>
  <fields>
   <fieldname>id</fieldname>
   <fieldname>gid</fieldname>
   <fieldname>group_name</fieldname>
   <fieldname>description</fieldname>
   <fieldname>language</fieldname>
   <fieldname>sid</fieldname>
   <fieldname>group_order</fieldname>
   <fieldname>randomization_group</fieldname>
   <fieldname>grelevance</fieldname>
  </fields>
  <rows>
   <row>
    <id><![CDATA[297]]></id>
    <gid><![CDATA[297]]></gid>
    <group_name><![CDATA[Firstgroup]]></group_name>
    <description/>
    <language><![CDATA[nl]]></language>
    <sid><![CDATA[945363]]></sid>
    <group_order><![CDATA[1]]></group_order>
    <randomization_group/>
    <grelevance><![CDATA[1]]></grelevance>
   </row>
  </rows>
 </group_l10ns>
 <questions>
  <fields>
   <fieldname>qid</fieldname>
   <fieldname>parent_qid</fieldname>
   <fieldname>sid</fieldname>
   <fieldname>gid</fieldname>
   <fieldname>type</fieldname>
   <fieldname>title</fieldname>
   <fieldname>preg</fieldname>
   <fieldname>other</fieldname>
   <fieldname>mandatory</fieldname>
   <fieldname>encrypted</fieldname>
   <fieldname>question_order</fieldname>
   <fieldname>scale_id</fieldname>
   <fieldname>same_default</fieldname>
   <fieldname>relevance</fieldname>
   <fieldname>modulename</fieldname>
   <fieldname>question_theme_name</fieldname>
   <fieldname>same_script</fieldname>
  </fields>
  <rows>
   <row>
    <qid><![CDATA[4215]]></qid>
    <parent_qid><![CDATA[0]]></parent_qid>
    <sid><![CDATA[945363]]></sid>
    <gid><![CDATA[297]]></gid>
    <type><![CDATA[T]]></type>
    <title><![CDATA[Q001]]></title>
    <preg/>
    <other><![CDATA[N]]></other>
    <mandatory><![CDATA[N]]></mandatory>
    <encrypted><![CDATA[N]]></encrypted>
    <question_order><![CDATA[0]]></question_order>
    <scale_id><![CDATA[0]]></scale_id>
    <same_default><![CDATA[0]]></same_default>
    <relevance><![CDATA[1]]></relevance>
    <question_theme_name><![CDATA[longfreetext]]></question_theme_name>
    <same_script><![CDATA[0]]></same_script>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <parent_qid><![CDATA[0]]></parent_qid>
    <sid><![CDATA[945363]]></sid>
    <gid><![CDATA[297]]></gid>
    <type><![CDATA[S]]></type>
    <title><![CDATA[Q002]]></title>
    <preg/>
    <other><![CDATA[N]]></other>
    <mandatory><![CDATA[N]]></mandatory>
    <encrypted><![CDATA[N]]></encrypted>
    <question_order><![CDATA[2]]></question_order>
    <scale_id><![CDATA[0]]></scale_id>
    <same_default><![CDATA[0]]></same_default>
    <relevance><![CDATA[1]]></relevance>
    <modulename/>
    <question_theme_name><![CDATA[shortfreetext]]></question_theme_name>
    <same_script><![CDATA[0]]></same_script>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <parent_qid><![CDATA[0]]></parent_qid>
    <sid><![CDATA[945363]]></sid>
    <gid><![CDATA[297]]></gid>
    <type><![CDATA[S]]></type>
    <title><![CDATA[Q003]]></title>
    <preg/>
    <other><![CDATA[N]]></other>
    <mandatory><![CDATA[N]]></mandatory>
    <encrypted><![CDATA[N]]></encrypted>
    <question_order><![CDATA[1]]></question_order>
    <scale_id><![CDATA[0]]></scale_id>
    <same_default><![CDATA[0]]></same_default>
    <relevance><![CDATA[1]]></relevance>
    <modulename/>
    <question_theme_name><![CDATA[shortfreetext]]></question_theme_name>
    <same_script><![CDATA[0]]></same_script>
   </row>
  </rows>
 </questions>
 <question_l10ns>
  <fields>
   <fieldname>id</fieldname>
   <fieldname>qid</fieldname>
   <fieldname>question</fieldname>
   <fieldname>help</fieldname>
   <fieldname>script</fieldname>
   <fieldname>language</fieldname>
  </fields>
  <rows>
   <row>
    <id><![CDATA[4215]]></id>
    <qid><![CDATA[4215]]></qid>
    <question><![CDATA[firstquestion]]></question>
    <help><![CDATA[Dit is de helptekst bij een vraag.]]></help>
    <script/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <id><![CDATA[4216]]></id>
    <qid><![CDATA[4216]]></qid>
    <question><![CDATA[second question]]></question>
    <help/>
    <script/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <id><![CDATA[4217]]></id>
    <qid><![CDATA[4217]]></qid>
    <question><![CDATA[third question]]></question>
    <help/>
    <script/>
    <language><![CDATA[nl]]></language>
   </row>
  </rows>
 </question_l10ns>
 <question_attributes>
  <fields>
   <fieldname>qid</fieldname>
   <fieldname>attribute</fieldname>
   <fieldname>value</fieldname>
   <fieldname>language</fieldname>
  </fields>
  <rows>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[cssclass]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[display_rows]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[em_validation_q]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[em_validation_q_tip]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[hidden]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[hide_tip]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[input_size]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[maximum_chars]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[page_break]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[random_group]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[save_as_default]]></attribute>
    <value><![CDATA[N]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[statistics_graphtype]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[statistics_showgraph]]></attribute>
    <value><![CDATA[1]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[text_input_width]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_action]]></attribute>
    <value><![CDATA[1]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_countdown_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_disable_next]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_disable_prev]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_message_delay]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_message_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_timer_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_warning]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_warning_2]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_warning_2_display_time]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_warning_2_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_warning_2_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_warning_display_time]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_warning_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4215]]></qid>
    <attribute><![CDATA[time_limit_warning_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[cssclass]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[display_rows]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[em_validation_q]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[em_validation_q_tip]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[hidden]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[hide_tip]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[input_size]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_city]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_country]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_defaultcoordinates]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_mapheight]]></attribute>
    <value><![CDATA[300]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_mapservice]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_mapwidth]]></attribute>
    <value><![CDATA[500]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_mapzoom]]></attribute>
    <value><![CDATA[11]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_nodefaultfromip]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_postal]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[location_state]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[maximum_chars]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[numbers_only]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[page_break]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[prefix]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[random_group]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[save_as_default]]></attribute>
    <value><![CDATA[N]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[statistics_graphtype]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[statistics_showgraph]]></attribute>
    <value><![CDATA[1]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[statistics_showmap]]></attribute>
    <value><![CDATA[1]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[suffix]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[text_input_width]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_action]]></attribute>
    <value><![CDATA[1]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_countdown_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_disable_next]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_disable_prev]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_message_delay]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_message_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_timer_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_warning]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_warning_2]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_warning_2_display_time]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_warning_2_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_warning_2_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_warning_display_time]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_warning_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4216]]></qid>
    <attribute><![CDATA[time_limit_warning_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[cssclass]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[display_rows]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[em_validation_q]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[em_validation_q_tip]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[hidden]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[hide_tip]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[input_size]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_city]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_country]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_defaultcoordinates]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_mapheight]]></attribute>
    <value><![CDATA[300]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_mapservice]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_mapwidth]]></attribute>
    <value><![CDATA[500]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_mapzoom]]></attribute>
    <value><![CDATA[11]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_nodefaultfromip]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_postal]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[location_state]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[maximum_chars]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[numbers_only]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[page_break]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[prefix]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[random_group]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[save_as_default]]></attribute>
    <value><![CDATA[N]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[statistics_graphtype]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[statistics_showgraph]]></attribute>
    <value><![CDATA[1]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[statistics_showmap]]></attribute>
    <value><![CDATA[1]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[suffix]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[text_input_width]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_action]]></attribute>
    <value><![CDATA[1]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_countdown_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_disable_next]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_disable_prev]]></attribute>
    <value><![CDATA[0]]></value>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_message_delay]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_message_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_timer_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_warning]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_warning_2]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_warning_2_display_time]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_warning_2_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_warning_2_style]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_warning_display_time]]></attribute>
    <value/>
    <language/>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_warning_message]]></attribute>
    <value/>
    <language><![CDATA[nl]]></language>
   </row>
   <row>
    <qid><![CDATA[4217]]></qid>
    <attribute><![CDATA[time_limit_warning_style]]></attribute>
    <value/>
    <language/>
   </row>
  </rows>
 </question_attributes>
 <surveys>
  <fields>
   <fieldname>sid</fieldname>
   <fieldname>gsid</fieldname>
   <fieldname>admin</fieldname>
   <fieldname>expires</fieldname>
   <fieldname>startdate</fieldname>
   <fieldname>adminemail</fieldname>
   <fieldname>anonymized</fieldname>
   <fieldname>faxto</fieldname>
   <fieldname>format</fieldname>
   <fieldname>savetimings</fieldname>
   <fieldname>template</fieldname>
   <fieldname>language</fieldname>
   <fieldname>additional_languages</fieldname>
   <fieldname>datestamp</fieldname>
   <fieldname>usecookie</fieldname>
   <fieldname>allowregister</fieldname>
   <fieldname>allowsave</fieldname>
   <fieldname>autonumber_start</fieldname>
   <fieldname>autoredirect</fieldname>
   <fieldname>allowprev</fieldname>
   <fieldname>printanswers</fieldname>
   <fieldname>ipaddr</fieldname>
   <fieldname>refurl</fieldname>
   <fieldname>showsurveypolicynotice</fieldname>
   <fieldname>publicstatistics</fieldname>
   <fieldname>publicgraphs</fieldname>
   <fieldname>listpublic</fieldname>
   <fieldname>htmlemail</fieldname>
   <fieldname>sendconfirmation</fieldname>
   <fieldname>tokenanswerspersistence</fieldname>
   <fieldname>assessments</fieldname>
   <fieldname>usecaptcha</fieldname>
   <fieldname>usetokens</fieldname>
   <fieldname>bounce_email</fieldname>
   <fieldname>attributedescriptions</fieldname>
   <fieldname>emailresponseto</fieldname>
   <fieldname>emailnotificationto</fieldname>
   <fieldname>tokenlength</fieldname>
   <fieldname>showxquestions</fieldname>
   <fieldname>showgroupinfo</fieldname>
   <fieldname>shownoanswer</fieldname>
   <fieldname>showqnumcode</fieldname>
   <fieldname>bouncetime</fieldname>
   <fieldname>bounceprocessing</fieldname>
   <fieldname>bounceaccounttype</fieldname>
   <fieldname>bounceaccounthost</fieldname>
   <fieldname>bounceaccountpass</fieldname>
   <fieldname>bounceaccountencryption</fieldname>
   <fieldname>bounceaccountuser</fieldname>
   <fieldname>showwelcome</fieldname>
   <fieldname>showprogress</fieldname>
   <fieldname>questionindex</fieldname>
   <fieldname>navigationdelay</fieldname>
   <fieldname>nokeyboard</fieldname>
   <fieldname>alloweditaftercompletion</fieldname>
   <fieldname>googleanalyticsstyle</fieldname>
   <fieldname>googleanalyticsapikey</fieldname>
   <fieldname>tokenencryptionoptions</fieldname>
   <fieldname>ipanonymize</fieldname>
  </fields>
  <rows>
   <row>
    <sid><![CDATA[945363]]></sid>
    <gsid><![CDATA[1]]></gsid>
    <admin><![CDATA[inherit]]></admin>
    <adminemail><![CDATA[inherit]]></adminemail>
    <anonymized><![CDATA[N]]></anonymized>
    <format><![CDATA[I]]></format>
    <savetimings><![CDATA[I]]></savetimings>
    <template><![CDATA[inherit]]></template>
    <language><![CDATA[nl]]></language>
    <additional_languages/>
    <datestamp><![CDATA[I]]></datestamp>
    <usecookie><![CDATA[I]]></usecookie>
    <allowregister><![CDATA[I]]></allowregister>
    <allowsave><![CDATA[I]]></allowsave>
    <autonumber_start><![CDATA[0]]></autonumber_start>
    <autoredirect><![CDATA[I]]></autoredirect>
    <allowprev><![CDATA[I]]></allowprev>
    <printanswers><![CDATA[I]]></printanswers>
    <ipaddr><![CDATA[I]]></ipaddr>
    <refurl><![CDATA[I]]></refurl>
    <showsurveypolicynotice><![CDATA[0]]></showsurveypolicynotice>
    <publicstatistics><![CDATA[I]]></publicstatistics>
    <publicgraphs><![CDATA[I]]></publicgraphs>
    <listpublic><![CDATA[I]]></listpublic>
    <htmlemail><![CDATA[I]]></htmlemail>
    <sendconfirmation><![CDATA[I]]></sendconfirmation>
    <tokenanswerspersistence><![CDATA[I]]></tokenanswerspersistence>
    <assessments><![CDATA[I]]></assessments>
    <usecaptcha><![CDATA[E]]></usecaptcha>
    <usetokens><![CDATA[N]]></usetokens>
    <bounce_email><![CDATA[inherit]]></bounce_email>
    <emailresponseto><![CDATA[inherit]]></emailresponseto>
    <emailnotificationto><![CDATA[inherit]]></emailnotificationto>
    <tokenlength><![CDATA[-1]]></tokenlength>
    <showxquestions><![CDATA[I]]></showxquestions>
    <showgroupinfo><![CDATA[I]]></showgroupinfo>
    <shownoanswer><![CDATA[I]]></shownoanswer>
    <showqnumcode><![CDATA[I]]></showqnumcode>
    <bounceprocessing><![CDATA[N]]></bounceprocessing>
    <showwelcome><![CDATA[I]]></showwelcome>
    <showprogress><![CDATA[I]]></showprogress>
    <questionindex><![CDATA[-1]]></questionindex>
    <navigationdelay><![CDATA[-1]]></navigationdelay>
    <nokeyboard><![CDATA[I]]></nokeyboard>
    <alloweditaftercompletion><![CDATA[I]]></alloweditaftercompletion>
    <tokenencryptionoptions><![CDATA[{ "enabled":"Y","columns":{ "firstname":"N","lastname":"N","email":"N" } }]]></tokenencryptionoptions>
    <ipanonymize><![CDATA[I]]></ipanonymize>
   </row>
  </rows>
 </surveys>
 <surveys_languagesettings>
  <fields>
   <fieldname>surveyls_survey_id</fieldname>
   <fieldname>surveyls_language</fieldname>
   <fieldname>surveyls_title</fieldname>
   <fieldname>surveyls_description</fieldname>
   <fieldname>surveyls_welcometext</fieldname>
   <fieldname>surveyls_endtext</fieldname>
   <fieldname>surveyls_policy_notice</fieldname>
   <fieldname>surveyls_policy_error</fieldname>
   <fieldname>surveyls_policy_notice_label</fieldname>
   <fieldname>surveyls_url</fieldname>
   <fieldname>surveyls_urldescription</fieldname>
   <fieldname>surveyls_email_invite_subj</fieldname>
   <fieldname>surveyls_email_invite</fieldname>
   <fieldname>surveyls_email_remind_subj</fieldname>
   <fieldname>surveyls_email_remind</fieldname>
   <fieldname>surveyls_email_register_subj</fieldname>
   <fieldname>surveyls_email_register</fieldname>
   <fieldname>surveyls_email_confirm_subj</fieldname>
   <fieldname>surveyls_email_confirm</fieldname>
   <fieldname>surveyls_dateformat</fieldname>
   <fieldname>surveyls_attributecaptions</fieldname>
   <fieldname>email_admin_notification_subj</fieldname>
   <fieldname>email_admin_notification</fieldname>
   <fieldname>email_admin_responses_subj</fieldname>
   <fieldname>email_admin_responses</fieldname>
   <fieldname>surveyls_numberformat</fieldname>
   <fieldname>attachments</fieldname>
   <fieldname>surveyls_alias</fieldname>
  </fields>
  <rows>
   <row>
    <surveyls_survey_id><![CDATA[945363]]></surveyls_survey_id>
    <surveyls_language><![CDATA[nl]]></surveyls_language>
    <surveyls_title><![CDATA[questionordertest]]></surveyls_title>
    <surveyls_description/>
    <surveyls_welcometext/>
    <surveyls_endtext/>
    <surveyls_policy_notice/>
    <surveyls_policy_notice_label/>
    <surveyls_url/>
    <surveyls_urldescription/>
    <surveyls_email_invite_subj><![CDATA[Uitnodiging om deel te nemen aan een enquête]]></surveyls_email_invite_subj>
    <surveyls_email_invite><![CDATA[Geachte {FIRSTNAME},

U wordt uitgenodigd om deel te nemen aan een enquête.

De titel van de enquête is:
'{SURVEYNAME}'

'{SURVEYDESCRIPTION}'

Om aan de enquête deel te nemen kunt u op onderstaande link klikken.

Hoogachtend,

{ADMINNAME} ({ADMINEMAIL})

----------------------------------------------
Klik op 
{SURVEYURL}
 om aan de enquête deel te nemen.

Als u deze enquête niet wilt invullen en ook geen nieuwe uitnodigingen wilt ontvangen, klik dan a.u.b. op de volgende link: {OPTOUTURL}

Als u bent uitgesloten, maar toch deze enquête wilt invullen en ook nieuwe uitnodigingen wilt ontvangen, klik dan a.u.b. op de volgende link:
 {OPTINURL}]]></surveyls_email_invite>
    <surveyls_email_remind_subj><![CDATA[Herinnering om deel te nemen aan een enquête]]></surveyls_email_remind_subj>
    <surveyls_email_remind><![CDATA[Geachte {FIRSTNAME},

Recent bent u uitgenodigd om aan een enquête deel te nemen.

We hebben geconstateerd dat u nog niet aan de enquête heeft deelgenomen en willen u er bij dezen aan herinneren dat de enquête nog loopt en dat u, als u dat wilt, nog kan deelnemen. 

De enquête is getiteld: 
''{SURVEYNAME}"

''{SURVEYDESCRIPTION}"

Om deel te nemen klikt u op onderstaande link. 

Hoogachtend,

{ADMINNAME} ({ADMINEMAIL})

----------------------------------------------
Klik op:
{SURVEYURL} om aan de enquête deel te nemen.

Als u deze enquête niet wilt invullen en ook geen nieuwe uitnodigingen wilt ontvangen, klik dan a.u.b. op de volgende link: {OPTOUTURL}]]></surveyls_email_remind>
    <surveyls_email_register_subj><![CDATA[Bevestiging registratie enquête]]></surveyls_email_register_subj>
    <surveyls_email_register><![CDATA[Geachte {FIRSTNAME},

U, of iemand die uw e-mailadres gebruikt, heeft zich aangemeld voor deelname aan de online enquête getiteld {SURVEYNAME}.

Klik op onderstaande link om aan de enquête mee te doen:

{SURVEYURL}

Als u vragen heeft over de enquête, of als u zich niet heeft aangemeld voor deelname en meent dat u deze e-mail ten onrechte heeft ontvangen, kunt u contact opnemen met {ADMINNAME} via {ADMINEMAIL}.]]></surveyls_email_register>
    <surveyls_email_confirm_subj><![CDATA[Bevestiging van uw deelname aan onze enquête]]></surveyls_email_confirm_subj>
    <surveyls_email_confirm><![CDATA[Beste {FIRSTNAME},

Dit e-mail bericht bevestigt dat u de enquête {SURVEYNAME} heeft ingevuld en dat uw antwoorden zijn opgeslagen. Hartelijk dank voor uw deelname.

Als u vragen heeft over deze e-mail, neemt u dan contact op met de beheerder {ADMINNAME} via {ADMINEMAIL}.

Hoogachtend,

{ADMINNAME}]]></surveyls_email_confirm>
    <surveyls_dateformat><![CDATA[2]]></surveyls_dateformat>
    <email_admin_notification_subj><![CDATA[Respons inzending op enquête {SURVEYNAME}]]></email_admin_notification_subj>
    <email_admin_notification><![CDATA[Hallo,

Er is een nieuwe respons voor de enquête '{SURVEYNAME}'.

Klik op de volgende link om de respons te bekijken:
{VIEWRESPONSEURL}

Klik op de volgende link om de respons te bewerken:
{EDITRESPONSEURL}

Bekijk de statistieken door hier te klikken:
{STATISTICSURL}]]></email_admin_notification>
    <email_admin_responses_subj><![CDATA[Respons inzending op enquête {SURVEYNAME} met resultaten]]></email_admin_responses_subj>
    <email_admin_responses><![CDATA[Hallo,

Er is een nieuwe respons voor  de enquête '{SURVEYNAME}'.

Klik op de volgende link om de respons te bekijken:
{VIEWRESPONSEURL}

Klik op de volgende link om de respons te bewerken:
{EDITRESPONSEURL}

Bekijk statistieken door hier te klikken:
{STATISTICSURL}


De volgende antwoorden zijn door de deelnemer gegeven:
{ANSWERTABLE}]]></email_admin_responses>
    <surveyls_numberformat><![CDATA[1]]></surveyls_numberformat>
   </row>
  </rows>
 </surveys_languagesettings>
 <themes>
  <theme>
   <sid>945363</sid>
   <template_name>fruity</template_name>
   <config>
    <options>inherit</options>
   </config>
  </theme>
 </themes>
 <themes_inherited>
  <theme>
   <sid>945363</sid>
   <template_name>fruity</template_name>
   <config>
    <options>
     <ajaxmode>off</ajaxmode>
     <brandlogo>on</brandlogo>
     <brandlogofile>image::theme::files/logo.png</brandlogofile>
     <container>on</container>
     <backgroundimage>off</backgroundimage>
     <animatebody>off</animatebody>
     <bodyanimation>fadeInRight</bodyanimation>
     <bodyanimationduration>500</bodyanimationduration>
     <animatequestion>off</animatequestion>
     <questionanimation>flipInX</questionanimation>
     <questionanimationduration>500</questionanimationduration>
     <animatealert>off</animatealert>
     <alertanimation>shake</alertanimation>
     <alertanimationduration>500</alertanimationduration>
     <font>noto</font>
     <bodybackgroundcolor>#ffffff</bodybackgroundcolor>
     <fontcolor>#444444</fontcolor>
     <questionbackgroundcolor>#ffffff</questionbackgroundcolor>
     <questionborder>on</questionborder>
     <questioncontainershadow>on</questioncontainershadow>
     <checkicon>f00c</checkicon>
     <animatecheckbox>on</animatecheckbox>
     <checkboxanimation>rubberBand</checkboxanimation>
     <checkboxanimationduration>500</checkboxanimationduration>
     <animateradio>on</animateradio>
     <radioanimation>zoomIn</radioanimation>
     <radioanimationduration>500</radioanimationduration>
     <zebrastriping>off</zebrastriping>
     <stickymatrixheaders>off</stickymatrixheaders>
     <greyoutselected>off</greyoutselected>
     <hideprivacyinfo>off</hideprivacyinfo>
     <crosshover>off</crosshover>
     <showpopups>1</showpopups>
     <showclearall>off</showclearall>
     <questionhelptextposition>top</questionhelptextposition>
     <notables>1</notables>
    </options>
   </config>
  </theme>
 </themes_inherited>
</document>
limesurvey_survey_945363.lss (35,737 bytes)   
p_teichmann

p_teichmann

2023-05-23 16:18

administrator   ~75176

Did you try out the latest version? currently in 6.1 this seems to be working.

asshank

asshank

2023-09-19 10:29

reporter   ~77156

Figured it out, it's a bug.
Some of the questions in this surveys have a [question_order]=0.
The navigation-pane sorts from 1 to 0. The questions-ordering window sorts from 0-9.

The [question_order]=0 is introduced when you reorder a question to position 1 in the Reorder window.
See attached screenshots.

2023-09-19_10h20_16.png (56,886 bytes)   
2023-09-19_10h20_16.png (56,886 bytes)   
2023-09-19_10h21_43.png (25,304 bytes)   
2023-09-19_10h21_43.png (25,304 bytes)   
mfavetti

mfavetti

2023-09-29 02:27

developer   ~77430

I can reproduce the bug.

I've been running into this repeatedly, but hadn't looked into fixing it yet. I'll work on it and do a PR.

mfavetti

mfavetti

2023-09-29 03:18

developer   ~77431

ok two bugs here

first bug
the questionadministration organizer numbers questions starting from zero
the sidepanel organizer numbers questions starting from one
creating a new group and new question starts at one

so starting from one wins, i guess

second bug

the logic for ordering groups/questions in the admin sidepanel vue package changes 0 to 999999
I think the author meant that if parseint fails to parse the field, to return 999999 for order
but instead any falsy value of group_order/question_order will return 999999 for order
i changed to explicitly check the return result of parseInt, which from the mdn docs an integer or NaN
if NaN, return 999999 (couldn't parse number from group_order/question_order)
orderwise return the parsed number

so there's no technical reason here why the ordering can't start from zero, except that zero was handled incorrectly

but for consistency I will fix both

mfavetti

mfavetti

2023-09-29 03:23

developer   ~77432

parseInt(order || 999999)

order not falsy, parseInt(order)
order falsy, parseInt(999999)

can't parse, NaN returned
can parse, int returned
so 0, empty string, etc all 999999

and i thought maybe they meant this
parseInt(order) || 999999
can parse, number
can't parse, NaN

NaN returns 999999
0 returns 999999

but same problem, so

I think my explicit check for NaN solves this
can't parse, return 999999
can parse, return number (zero works too)

mfavetti

mfavetti

2023-09-29 03:41

developer   ~77433

5.x is not behaving exactly the same, I will need to dig into it more later

mfavetti

mfavetti

2023-09-30 00:59

developer   ~77444

ok the change in behavior is linked with php version

the code would have worked fine in 8.0, the issues starts with 8.1

question order is a string in 8.0 and an integer in 8.1

this is what caused the change in behavior in the javascript

0 is falsy, "0" is truthy (but loosely equal to false in boolean coercion see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean#boolean_coercion and search for "0")

so when the javascript was getting "0", this is truthy so the or 999999 didn't happen
but now its getting 0, which is falsy so the 999999 does happen

looking into what changed in php to cause this...

mfavetti

mfavetti

2023-09-30 01:04

developer   ~77445

its way down on the page, almost missed it: https://www.php.net/manual/en/migration81.incompatible.php#migration81.incompatible.pdo.mysql

mfavetti

mfavetti

2023-09-30 01:12

developer   ~77446

i also noticed the parseInt(val || 999999) appears 12 times in adminsidepanel, and my fix would only cover 2 of those, so maybe we want to consider changing them all?

tibor.pacalat

tibor.pacalat

2023-10-09 15:46

administrator   ~77578

@mfavetti After switching to your fix branch the side structure menu is broken for me. I can not drag and drop the questions like on master.

mfavetti

mfavetti

2023-10-09 21:40

developer   ~77594

thanks for taking a look @tibor.pacalat

i think I found the issue and created a new pr (completely messed up the other branch and gave up, haha. closed the old pr)

https://github.com/LimeSurvey/LimeSurvey/pull/3522

tibor.pacalat

tibor.pacalat

2023-10-11 16:18

administrator   ~77632

Works now, but it still needs code review.

DenisChenu

DenisChenu

2023-10-11 16:22

developer   ~77633

5.x is not behaving exactly the same, I will need to dig into it more later

5.X start at 0 in reorderGroup too ?
Can you fix this part for 5.X too if yes ?

mfavetti

mfavetti

2023-10-11 16:28

developer   ~77634

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35606

mfavetti

mfavetti

2023-10-11 23:23

developer   ~77640

PR for 5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3534

mfavetti

mfavetti

2023-10-12 10:12

developer   ~77650

5 and 6 behave exactly the same, the difference i was seeing was because my 5 was on php 8.0 and my 6 was on php 8.2. If both on 8.0 the second bug doesn't happen, but the first one does. If both >=8.1 both bugs happen.

DenisChenu

DenisChenu

2023-10-12 10:17

developer   ~77651

master : ready for merge,
5.X to test

tibor.pacalat

tibor.pacalat

2023-10-12 13:52

administrator   ~77660

Last edited: 2023-10-12 13:56

@mfavetti something is still wrong on 5.x, please take a look at this video.

Reordering in structure on the left doesn't save the new order.

To reproduce:

  1. open both side by side
  2. reorder in side structure, refresh (order is saved)
  3. reorder in the right pane (order is saved)
  4. reorder in side structure (loader is shown, but when you refresh you can see it is not saved)
mfavetti

mfavetti

2023-10-13 00:10

developer   ~77681

Last edited: 2023-10-13 00:20

@tibor.pacalat The order is correctly updated in the database when you do that final drag on the left side. You're just changing the order back when you do the refresh because you're resending the POST request from when you used the right side organizer to change the order.

mfavetti

mfavetti

2023-10-13 10:09

developer   ~77688

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35613

LimeBot

LimeBot

2023-10-16 08:41

administrator   ~77722

Fixed in Release 6.3.0+231016

asshank

asshank

2023-10-17 22:31

reporter   ~77759

Tested.
No 'question_order' with value '0' anymore in the database.
Thanks!!
Joost

Related Changesets

LimeSurvey: master b068b2ea

2023-10-11 18:28

mfavetti

Committer: GitHub


Details Diff
Fixed issue 18776: Question ordering not correct (#3522)

Co-authored-by: Matthew Favetti <mpfavetti@ucdavis.edu>
Affected Issues
18776
mod - application/models/services/GroupHelper.php Diff File
mod - assets/packages/adminsidepanel/build.min/js/adminsidepanel.js Diff File
mod - assets/packages/adminsidepanel/build/js/adminsidepanel.js Diff File
mod - assets/packages/adminsidepanel/src/components/subcomponents/_questionsgroups.vue Diff File

LimeSurvey: 5.x 63458357

2023-10-13 12:09

mfavetti

Committer: GitHub


Details Diff
Fixed issue 18776: Question ordering not correct (03534)

Co-authored-by: Matthew Favetti <mpfavetti@ucdavis.edu>
Affected Issues
18776
mod - application/controllers/SurveyAdministrationController.php Diff File
mod - assets/packages/adminsidepanel/build.min/js/adminsidepanel.js Diff File
mod - assets/packages/adminsidepanel/build/js/adminsidepanel.js Diff File
mod - assets/packages/adminsidepanel/src/components/subcomponents/_questionsgroups.vue Diff File

Issue History

Date Modified Username Field Change
2023-04-21 13:23 asshank New Issue
2023-04-21 13:23 asshank File Added: 2023-04-21_13h09_08.png
2023-04-24 10:17 p_teichmann Note Added: 74592
2023-04-24 10:17 p_teichmann Bug heat 0 => 2
2023-04-24 10:17 p_teichmann Status new => feedback
2023-04-24 11:08 asshank Note Added: 74598
2023-04-24 11:08 asshank File Added: limesurvey_survey_945363.lss
2023-04-24 11:08 asshank Bug heat 2 => 4
2023-04-24 11:08 asshank Status feedback => new
2023-05-23 16:18 p_teichmann Note Added: 75176
2023-05-23 16:18 p_teichmann Status new => feedback
2023-09-19 10:29 asshank Note Added: 77156
2023-09-19 10:29 asshank File Added: 2023-09-19_10h20_16.png
2023-09-19 10:29 asshank File Added: 2023-09-19_10h21_43.png
2023-09-19 10:29 asshank Status feedback => new
2023-09-29 02:27 mfavetti Note Added: 77430
2023-09-29 02:27 mfavetti Bug heat 4 => 6
2023-09-29 03:18 mfavetti Note Added: 77431
2023-09-29 03:23 mfavetti Note Added: 77432
2023-09-29 03:41 mfavetti Note Added: 77433
2023-09-30 00:59 mfavetti Note Added: 77444
2023-09-30 01:04 mfavetti Note Added: 77445
2023-09-30 01:12 mfavetti Note Added: 77446
2023-09-30 17:58 duvemyster Issue Monitored: duvemyster
2023-09-30 17:58 duvemyster Bug heat 6 => 8
2023-10-03 01:04 mfavetti Issue Monitored: mfavetti
2023-10-03 01:04 mfavetti Bug heat 8 => 10
2023-10-03 10:36 DenisChenu Assigned To => tibor.pacalat
2023-10-03 10:36 DenisChenu Status new => ready for testing
2023-10-03 10:36 DenisChenu Category _ Unknown => Survey editing
2023-10-03 20:58 mfavetti Relationship added related to 19140
2023-10-09 15:46 tibor.pacalat Note Added: 77578
2023-10-09 15:46 tibor.pacalat Bug heat 10 => 12
2023-10-09 21:40 mfavetti Note Added: 77594
2023-10-11 16:18 tibor.pacalat Note Added: 77632
2023-10-11 16:22 DenisChenu Note Added: 77633
2023-10-11 16:22 DenisChenu Bug heat 12 => 14
2023-10-11 16:22 DenisChenu Status ready for testing => ready for merge
2023-10-11 16:28 mfavetti Changeset attached => LimeSurvey master b068b2ea
2023-10-11 16:28 mfavetti Note Added: 77634
2023-10-11 16:28 mfavetti Assigned To tibor.pacalat => mfavetti
2023-10-11 16:28 mfavetti Resolution open => fixed
2023-10-11 23:23 mfavetti Note Added: 77640
2023-10-12 10:12 mfavetti Note Added: 77650
2023-10-12 10:17 DenisChenu Assigned To mfavetti => tibor.pacalat
2023-10-12 10:17 DenisChenu Status ready for merge => ready for testing
2023-10-12 10:17 DenisChenu Note Added: 77651
2023-10-12 13:52 tibor.pacalat Note Added: 77660
2023-10-12 13:52 tibor.pacalat File Added: Screen-2023-10-12-135043.mp4
2023-10-12 13:56 tibor.pacalat Note Edited: 77660
2023-10-13 00:10 mfavetti Note Added: 77681
2023-10-13 00:10 mfavetti File Added: Screencast 2023-10-12 15:09:13.mp4
2023-10-13 00:20 mfavetti Note Edited: 77681
2023-10-13 00:20 mfavetti Note Edited: 77681
2023-10-13 10:09 mfavetti Changeset attached => LimeSurvey 5.x 63458357
2023-10-13 10:09 mfavetti Note Added: 77688
2023-10-13 10:09 mfavetti Assigned To tibor.pacalat => mfavetti
2023-10-13 10:09 tibor.pacalat Status ready for testing => resolved
2023-10-16 08:41 LimeBot Note Added: 77722
2023-10-16 08:41 LimeBot Status resolved => closed
2023-10-16 08:41 LimeBot Bug heat 14 => 16
2023-10-17 22:31 asshank Note Added: 77759