View Issue Details

This issue affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18692Bug reportsOtherpublic2026-11-19 22:22
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Summary18692: GitHub Action ReOrganization
Description

Olle asked to have github actions reorganized as to have failures faster.
As to have that: Reorganize in different workflow files.


GithubActions: Separate Main from Integrity

On thing we could do before writing more test, is to break out the integrity test part into a separate github action
It's related to github actions configuration. Integrity tests and unit tests run within the same container/config, but can be split to speed it up.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URLN/A

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2023-03-17 14:55

developer   ~74167

Done here:
https://github.com/LimeSurvey/LimeSurvey/tree/dev/github-actions-review

Problem:
If a workflow fails, it doesn't cancel other workflows.

Solution:
Need to have everything in a singlw workflow, different jobs

gabrieljenik

gabrieljenik

2023-03-17 14:56

developer   ~74168

Here (https://github.com/LimeSurvey/LimeSurvey/pull/2998) I have moved code sniffer to the bottom.
That makes unit tests and functional tests to run first, and fail quicker.

That allows devs to know quicker if code fails.
Then, they will know if code needs rewritting (code sniffer).

Maybe that's enough?

ollehar

ollehar

2023-03-17 15:02

reporter   ~74169

Sure, but now the group description test is failing on that PR. I fixed that before? By adding an explicit ordering to the findAll() command.

gabrieljenik

gabrieljenik

2023-03-17 15:32

developer   ~74173

Fixed that on PR 2998

ollehar

ollehar

2023-03-23 11:12

reporter   ~74245

Last edited: 2023-03-23 11:15

Merged the PR, but still I'd like to see a proper job separation between tests that need selenium/apache and tests that do not (unit test, code sniffer).

gabrieljenik

gabrieljenik

2023-03-23 14:40

developer   ~74249

Split in between jobs or workflows?

c_schmitz

c_schmitz

2026-11-19 22:22

administrator   ~87676

The GitHub Actions are now split: unit tests and code checks run in main.yml without Selenium/Apache, functional Selenium tests run separately in functional.yml, and frontend tests in frontend.yml. Closing as fixed.

Issue History

Date Modified Username Field Change
2023-03-17 14:54 gabrieljenik New Issue
2023-03-17 14:54 gabrieljenik Assigned To => gabrieljenik
2023-03-17 14:54 gabrieljenik Status new => assigned
2023-03-17 14:55 gabrieljenik Note Added: 74167
2023-03-17 14:55 gabrieljenik Bug heat 0 => 2
2023-03-17 14:56 gabrieljenik Note Added: 74168
2023-03-17 14:57 gabrieljenik Description Updated
2023-03-17 15:02 ollehar Note Added: 74169
2023-03-17 15:02 ollehar Bug heat 2 => 4
2023-03-17 15:32 gabrieljenik Note Added: 74173
2023-03-23 11:12 ollehar Note Added: 74245
2023-03-23 11:15 ollehar Note Edited: 74245
2023-03-23 14:40 gabrieljenik Note Added: 74249
2026-11-19 22:22 c_schmitz Note Added: 87676
2026-11-19 22:22 c_schmitz Bug heat 4 => 6
2026-11-19 22:22 c_schmitz Status assigned => closed
2026-11-19 22:22 c_schmitz Resolution open => fixed