18658: Upload file question type - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

18658	Bug reports	Other	public	2023-02-27 17:23	2023-03-06 09:54

Reporter	KapilSabarwal	Assigned To	gabrieljenik
Priority	none	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	5.6.x
Fixed in Version	5.6.x

Summary	18658: Upload file question type
Description	The user's participant is facing the barrier of "upload file question", for they have the file, which has symbols along with the file name. For example (test %), which is not uploading and format error is appearing. After removing the % symbol, the participant is able to upload the file.
Steps To Reproduce	Steps to reproduce (create a survey with a "File upload" question type) Expected result (supported files should be able to upload, does not matter if the symbol contains or not) Actual result (it comes with an error, "format of the file is not supported")
Tags	No tags attached.

Bug heat	10
Complete LimeSurvey version number (& build)	5.6.8
I will donate to the project if issue is resolved	No
Browser	Chrome, Firefox, Safari
Database type & version	447
Server OS (if known)
Webserver software & version (if known)
PHP Version	NA

User List	There are no users monitoring this issue.

KapilSabarwal 2023-02-28 13:03 reporter ~73979	These two files has different names, one is supported and another one is not. MyTest percentage File-1029.png (9,670 bytes) MyTest percentage File-1029.png (9,670 bytes) MyTest%File-1029.png (9,670 bytes) MyTest%File-1029.png (9,670 bytes)

gabrieljenik 2023-02-28 13:15 manager ~73980	"MyTestpercentage_file.png" works "MyTest%_file.png" does not work

gabrieljenik 2023-02-28 15:49 manager ~73981	PR: https://github.com/LimeSurvey/LimeSurvey/pull/2952

gabrieljenik 2023-02-28 15:49 manager ~73982	Should we also remove % character from name when sanitizing?

DenisChenu 2023-02-28 16:00 developer ~73983	Should we also remove % character from name when sanitizing? No, here seems we decode an never encoded name ?

guest 2023-02-28 16:10 viewer ~73984	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34347

LimeBot 2023-03-06 09:54 administrator ~74035	Fixed in Release 5.6.9+230306

LimeSurvey: master dac6a046 2023-02-28 16:09:05 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18658: Upload file question type not accepting certain file names (#2952)	Affected Issues 18658
	mod - assets/packages/questions/upload/build/uploadquestion.js	Diff File
	mod - assets/packages/questions/upload/build/uploadquestion.min.js	Diff File
	mod - assets/packages/questions/upload/build/uploadquestion.min.js.map	Diff File
	mod - assets/packages/questions/upload/src/uploader.js	Diff File

Date Modified	Username	Field	Change
2023-02-27 17:23	KapilSabarwal	New Issue
2023-02-28 13:03	KapilSabarwal	Note Added: 73979
2023-02-28 13:03	KapilSabarwal	File Added: MyTest percentage File-1029.png
2023-02-28 13:03	KapilSabarwal	File Added: MyTest%File-1029.png
2023-02-28 13:03	KapilSabarwal	Bug heat	0 => 2
2023-02-28 13:15	gabrieljenik	Note Added: 73980
2023-02-28 13:15	gabrieljenik	Bug heat	2 => 4
2023-02-28 15:03	gabrieljenik	Assigned To	=> gabrieljenik
2023-02-28 15:03	gabrieljenik	Status	new => assigned
2023-02-28 15:49	gabrieljenik	Assigned To	gabrieljenik => DenisChenu
2023-02-28 15:49	gabrieljenik	Status	assigned => ready for code review
2023-02-28 15:49	gabrieljenik	Note Added: 73981
2023-02-28 15:49	gabrieljenik	Note Added: 73982
2023-02-28 15:57	gabrieljenik	Issue cloned: 18660
2023-02-28 16:00	DenisChenu	Note Added: 73983
2023-02-28 16:00	DenisChenu	Bug heat	4 => 6
2023-02-28 16:10		Changeset attached	=> LimeSurvey master dac6a046
2023-02-28 16:10	guest	Note Added: 73984
2023-02-28 16:10	guest	Bug heat	6 => 8
2023-03-02 19:25	DenisChenu	Assigned To	DenisChenu => gabrieljenik
2023-03-02 19:25	DenisChenu	Status	ready for code review => resolved
2023-03-02 19:25	DenisChenu	Resolution	open => fixed
2023-03-02 19:25	DenisChenu	Fixed in Version	=> 5.6.x
2023-03-06 09:54	LimeBot	Note Added: 74035
2023-03-06 09:54	LimeBot	Status	resolved => closed
2023-03-06 09:54	LimeBot	Bug heat	8 => 10