View Issue Details

This bug affects 2 person(s).
 18
IDProjectCategoryView StatusLast Update
18601Bug reportsSurvey editingpublic2023-12-04 11:05
ReporterMazi Assigned Totibor.pacalat  
PrioritynormalSeverityblock 
Status closedResolutionfixed 
Product Version5.5.x 
Summary18601: No editor available when defining quota messages
Description

For writing welcome or question text, one can make use of the integrated editor for formatting texts. For the quota messages, you can only add text without being able to format it. That looks quite bad for lengthy texts, see screenshot.

I tested changing the editor mode but still no editor was showing up.

The only workaround for this is copying the text into e.g. the survey description, format it there and then copy the source code text with all HTML tags into the quota message ... not very user friendly.

Steps To Reproduce

Steps to reproduce

Set up a quota at your survey and enter a quota message.

Expected result

See default editor icons for formatting the text.

Actual result

No editor icons visible.

TagsNo tags attached.
Attached Files
image.png (34,052 bytes)   
image.png (34,052 bytes)   
Bug heat18
Complete LimeSurvey version number (& build)Version 5.4.13+221128
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMariaDB 10.1.48
Server OS (if known)
Webserver software & version (if known)
PHP Version8.1

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2023-01-23 14:27

administrator   ~73541

Same as in LS3? Else more like a new feature, but yeah, should be fixed.

Mazi

Mazi

2023-01-23 19:45

updater   ~73542

Same for LS3, but the missing editor is really not very user friendly. I heard that from multiple customers.

gabrieljenik

gabrieljenik

2023-09-07 14:47

manager   ~76898

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3429

tibor.pacalat

tibor.pacalat

2023-09-13 15:00

administrator   ~76989

I tested the master PR and it looks good.

@gabrieljenik, shouldn't we port this to 5.x as well?

guest

guest

2023-09-13 15:39

viewer   ~76994

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35465

guest

guest

2023-09-13 15:39

viewer   ~76995

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35464

gabrieljenik

gabrieljenik

2023-09-13 16:25

manager   ~77001

@gabrieljenik, shouldn't we port this to 5.x as well?

@tibor.pacalat Not sure here. You let me know :)

tibor.pacalat

tibor.pacalat

2023-09-13 16:30

administrator   ~77005

The issue is present in 5.x, so I would say yes.

LimeBot

LimeBot

2023-09-18 09:10

administrator   ~77102

Fixed in Release 6.2.7+230918

gabrieljenik

gabrieljenik

2023-09-18 13:56

manager   ~77114

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3453

guest

guest

2023-09-22 17:55

viewer   ~77280

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35536

guest

guest

2023-09-22 17:55

viewer   ~77281

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35537

tibor.pacalat

tibor.pacalat

2023-09-22 17:56

administrator   ~77286

Tested and merged.

LimeBot

LimeBot

2023-09-25 11:04

administrator   ~77309

Fixed in Release 5.6.39+230926

Mazi

Mazi

2023-10-06 08:58

updater   ~77534

@gabrieljenik, @tibor.pacalat: Can we also adjust this at LS 3?

Mazi

Mazi

2023-10-17 22:26

updater   ~77758

@gabrieljenik, @tibor.pacalat: Can we also adjust this at LS 3? On eof our long-term customers would appreciate this a lot.
Will submitting a pull request speed things up?

Mazi

Mazi

2023-11-30 15:33

updater   ~78839

@tibor.pacalat: If we provide a pull request, would this be added to LS 3.x?

Mazi

Mazi

2023-11-30 15:33

updater   ~78840

@tibor.pacalat: If we provide a pull request, would this be added to LS 3.x?

tibor.pacalat

tibor.pacalat

2023-12-04 11:05

administrator   ~78854

@Mazi sure, but it needs to pass code review and qa. LS3 is not supported any more, we will add a notification in the application for this purpose.

Related Changesets

LimeSurvey: master 14e4d012

2023-09-13 17:00

Gabriel Jenik

Committer: GitHub


Details Diff
Fixed issue 18601: No editor available when defining quota messages. (03429)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>
Affected Issues
18601
mod - application/controllers/QuotasController.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/quotas/_form_langsetting.php Diff File
mod - application/views/quotas/_form_langsettings.php Diff File

LimeSurvey: master 14e4d012

2023-09-13 17:00

Gabriel Jenik

Committer: GitHub


Details Diff
Fixed issue 18601: No editor available when defining quota messages. (03429)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>
Affected Issues
18601
mod - application/controllers/QuotasController.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/quotas/_form_langsetting.php Diff File
mod - application/views/quotas/_form_langsettings.php Diff File

LimeSurvey: 5.x 99d5912f

2023-09-22 19:55

Gabriel Jenik

Committer: GitHub


Details Diff
Fixed issue 18601: No editor available when defining quota messages. (#3453)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>
Affected Issues
18601
mod - application/controllers/admin/Quotas.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/admin/quotas/_form_langsetting.php Diff File
mod - application/views/admin/quotas/_form_langsettings.php Diff File

LimeSurvey: 5.x 99d5912f

2023-09-22 19:55

Gabriel Jenik

Committer: GitHub


Details Diff
Fixed issue 18601: No editor available when defining quota messages. (#3453)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>
Affected Issues
18601
mod - application/controllers/admin/Quotas.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/admin/quotas/_form_langsetting.php Diff File
mod - application/views/admin/quotas/_form_langsettings.php Diff File

Issue History

Date Modified Username Field Change
2023-01-23 12:42 Mazi New Issue
2023-01-23 12:42 Mazi File Added: image.png
2023-01-23 14:26 ollehar Priority none => normal
2023-01-23 14:27 ollehar Note Added: 73541
2023-01-23 14:27 ollehar Bug heat 0 => 2
2023-01-23 19:45 Mazi Note Added: 73542
2023-01-23 19:45 Mazi Bug heat 2 => 4
2023-01-24 20:37 gabrieljenik Status new => acknowledged
2023-08-31 18:45 gabrieljenik Assigned To => gabrieljenik
2023-08-31 18:45 gabrieljenik Status acknowledged => assigned
2023-09-07 14:47 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-09-07 14:47 gabrieljenik Status assigned => ready for code review
2023-09-07 14:47 gabrieljenik Note Added: 76898
2023-09-07 14:47 gabrieljenik Bug heat 4 => 6
2023-09-07 16:52 DenisChenu Assigned To DenisChenu =>
2023-09-07 16:52 DenisChenu Status ready for code review => ready for testing
2023-09-11 15:28 gabrieljenik Assigned To => tibor.pacalat
2023-09-11 15:28 gabrieljenik Status ready for testing => ready for merge
2023-09-13 15:00 tibor.pacalat Note Added: 76989
2023-09-13 15:00 tibor.pacalat Bug heat 6 => 8
2023-09-13 15:39 Changeset attached => LimeSurvey master 14e4d012
2023-09-13 15:39 guest Note Added: 76994
2023-09-13 15:39 guest Bug heat 8 => 10
2023-09-13 15:39 Changeset attached => LimeSurvey master 14e4d012
2023-09-13 15:39 guest Note Added: 76995
2023-09-13 16:25 gabrieljenik Note Added: 77001
2023-09-13 16:30 tibor.pacalat Note Added: 77005
2023-09-18 09:10 LimeBot Note Added: 77102
2023-09-18 09:10 LimeBot Status ready for merge => closed
2023-09-18 09:10 LimeBot Resolution open => fixed
2023-09-18 09:10 LimeBot Bug heat 10 => 12
2023-09-18 13:56 gabrieljenik Assigned To tibor.pacalat => DenisChenu
2023-09-18 13:56 gabrieljenik Status closed => ready for code review
2023-09-18 13:56 gabrieljenik Note Added: 77114
2023-09-19 10:18 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-09-19 10:18 DenisChenu Status ready for code review => ready for testing
2023-09-21 23:03 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-09-22 17:55 Changeset attached => LimeSurvey 5.x 99d5912f
2023-09-22 17:55 guest Note Added: 77280
2023-09-22 17:55 Changeset attached => LimeSurvey 5.x 99d5912f
2023-09-22 17:55 guest Note Added: 77281
2023-09-22 17:56 tibor.pacalat Status ready for testing => resolved
2023-09-22 17:56 tibor.pacalat Note Added: 77286
2023-09-25 11:04 LimeBot Note Added: 77309
2023-09-25 11:04 LimeBot Status resolved => closed
2023-10-06 08:58 Mazi Note Added: 77534
2023-10-17 20:53 kansaspumpkin Bug heat 12 => 18
2023-10-17 22:26 Mazi Note Added: 77758
2023-11-30 15:33 Mazi Note Added: 78839
2023-11-30 15:33 Mazi Note Added: 78840
2023-12-04 11:05 tibor.pacalat Note Added: 78854