@ollehar, can we assign this to a developer please?

This is tricky.

The filter is "Group" and the expectation (from the bug case) is to be able to filter by any ancestor.
Am I right?

If so, I must tell it is a tricky thing as it could involve some recursion.
@ollehar, thoughts?

Thanks

Yes, when filtering for the parent group, I expect surveys of child groups to not get ignored but listed as well since they belong to the parent group.

Sorry, as to clarify: the case is you want to filter surveys not by its parent group but by an ancesotr, right?

Ex:
Survey Group: Nova
--- Survey Group: Nova Melbourne
--- --- Survey : Research Melbourne
--- Survey Group: Nova Sydney
--- --- Survey : Research Sydney

You want to filter surveys by Nova and see surveys "Research Sydney" and "Research Melbourne".
Right?

Correct!

It is a tricky thing as it could involve some recursion.

Something I have in mind for making things not DB intensive:

• Pickup selected ancestor.
• Do a full query dump of the survey groups table
• Look for all childs, recursively. (I would say on average we would have 5 levels max?)
• Filter surveys by using an in comparison.

From a technical point of view, not very fan of this type of filters.
But I understand could be usefull.
Not sure it is worth the effort now.

@ollehar, thoughts?

@gabrieljenik: Sound good. And a nesting level of 5 should definitely be sufficient.

Would love to see this implemented because if confused more than 1 customer that surveys of child groups have not been shown when filtering.

What about free text search "Nova"? Does it include survey group name too?

One possible easy fix is to join with the first parent-child relation as a default, and ignore deeper levels.

Just choose the poison, I will implement it :)

The join thing could be a workaround, although probably will always be a customer for which will fall short.

Another option could be to solve it through a new plugin event and a plugin?
Then would be easier to activate it and deactivate when customers need it?

If we're fine with having a limit, a child-parent relation can be fetched x levels down with x number of SQL JOINs.

Maybe you can check what that would look like in code, Gabriel? To just fetched the first level.

No additional plugin please. Many customers have at least one sub-group so that affects a lot of people. If I'd have to activate a plugin first to make a basic search feature work, that's not user friendly.

Alright, so many two levels to start with?

Yes, when filtering for the parent group, I expect surveys of child groups to not get ignored but listed as well since they belong to the parent group.

+1 at 100% out of plugin too (exceptional for me)

Maybe we can cache the childs, empty the cache when a group is saved, created or deleted
I write cache, not static real caching.

PR for v3: https://github.com/LimeSurvey/LimeSurvey/pull/3147
If good, will port to v5 and master

@Mazi : maybe you can test on 3.X ?

@gabrieljenik, I replaced the survey.php file with the one from your commit at my v3.28.xx version. The survey group search worked as expected.

But when I searched the survey list for "test" I got this error (see screenshot for relation to survey.php):
query parameter: index.php/admin/survey/sa/listsurveys?Survey%5Bsearched_value%5D=test&active=&gsid=&yt0=Search

CDbException
CDbCommand failed to execute the SQL statement: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'surveygroup.title' in 'where clause'. The SQL statement executed was: SELECT COUNT(DISTINCT t.sid) FROM lime_surveys t LEFT OUTER JOIN lime_surveys_languagesettings correct_relation_defaultlanguage ON (correct_relation_defaultlanguage.surveyls_language=t.language) AND (correct_relation_defaultlanguage.surveyls_survey_id=t.sid) LEFT OUTER JOIN lime_users owner ON (t.owner_id=owner.uid) WHERE (((((t.sid LIKE :ycp0) OR (t.admin LIKE :ycp1)) OR (owner.users_name LIKE :ycp2)) OR (correct_relation_defaultlanguage.surveyls_title LIKE :ycp3)) OR (surveygroup.title LIKE :ycp4))

/var/www/vhosts/my-survey.host/httpdocs/ls3dev.my-survey.host/ls/framework/db/CDbCommand.php(543)

Issue confirmed

Another issue with id=2 if group 2 have subgroups

How to reproduce

Create SurveyGroup aaa
Create Surveygroup aaaChild child of aaa
Put a surey in aaaChild
Select in dropdoxn : OK
Click on sureyGrousp
Click on aa group : NOT ok

See screencast.

Maybe time to remove this awful line … https://github.com/LimeSurvey/LimeSurvey/blob/0c9c5c8efe51b5af785c34b059c75ce206d906ad/application/models/Survey.php#LL1646C18-L1646C18
and set gid in controller

Another issue with id=2 if group 2 have subgroups

Your expectation is to have 2 surveys being shown at the end of your test?
Something like "when clicking on a survey group name on the survey group list, I should see all surveys that are child, grand child, ... fo that survey group" ?

Your expectation is to have 2 surveys being shown at the end of your test?

Yes, i think it's the expectation ping @Mazi ?

when clicking on a survey group name on the survey group list, I should see all surveys that are child, grand child, ... fo that survey group

Done

Master PR: https://github.com/LimeSurvey/LimeSurvey/pull/3167
5.x PR: https://github.com/LimeSurvey/LimeSurvey/pull/3168

3+5+6 reviewed

Did you test it too Denis, or just read the code?

Else maybe Mazi can test. :)

Did you test it too Denis, or just read the code?

I test the 3.X version, but not 5 and 6 since it's near same code.

We can test... but next week. (non labour today and tomorrow) :)

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34780

PR with extra test on v5: https://github.com/LimeSurvey/LimeSurvey/pull/3201

Fixed in Release 5.6.26+230613

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34809

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36317